From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07471C43331 for ; Tue, 12 Nov 2019 11:46:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3D522084E for ; Tue, 12 Nov 2019 11:46:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfKLLqD (ORCPT ); Tue, 12 Nov 2019 06:46:03 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60126 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727015AbfKLLp6 (ORCPT ); Tue, 12 Nov 2019 06:45:58 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xACBelmr106829; Tue, 12 Nov 2019 06:45:48 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w7shnx22v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Nov 2019 06:45:48 -0500 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id xACBeqhW106999; Tue, 12 Nov 2019 06:45:47 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w7shnx227-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Nov 2019 06:45:47 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xACBipeO017293; Tue, 12 Nov 2019 11:45:50 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01wdc.us.ibm.com with ESMTP id 2w5n36e759-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Nov 2019 11:45:50 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xACBjjvQ53412308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Nov 2019 11:45:45 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA7B5112063; Tue, 12 Nov 2019 11:45:44 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFF2D112062; Tue, 12 Nov 2019 11:45:39 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.199.45.124]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 12 Nov 2019 11:45:39 +0000 (GMT) X-Mailer: emacs 26.2 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Dan Williams , linux-nvdimm@lists.01.org Cc: Ira Weiny , Michael Ellerman , "Oliver O'Halloran" , Vishal Verma , peterz@infradead.org, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/16] libnvdimm: Move nd_region_attribute_group to device_type In-Reply-To: <157309902169.1582359.16828508538444551337.stgit@dwillia2-desk3.amr.corp.intel.com> References: <157309899529.1582359.15358067933360719580.stgit@dwillia2-desk3.amr.corp.intel.com> <157309902169.1582359.16828508538444551337.stgit@dwillia2-desk3.amr.corp.intel.com> Date: Tue, 12 Nov 2019 17:15:36 +0530 Message-ID: <87zhh1s4gv.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-12_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911120106 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Williams writes: > A 'struct device_type' instance can carry default attributes for the > device. Use this facility to remove the export of > nd_region_attribute_group and put the responsibility on the core rather > than leaf implementations to define this attribute. > Reviewed-by: Aneesh Kumar K.V > Cc: Ira Weiny > Cc: Michael Ellerman > Cc: "Oliver O'Halloran" > Cc: Vishal Verma > Cc: Aneesh Kumar K.V > Signed-off-by: Dan Williams > --- > arch/powerpc/platforms/pseries/papr_scm.c | 1 - > drivers/acpi/nfit/core.c | 1 - > drivers/nvdimm/e820.c | 6 ------ > drivers/nvdimm/of_pmem.c | 6 ------ > drivers/nvdimm/region_devs.c | 4 ++-- > include/linux/libnvdimm.h | 1 - > 6 files changed, 2 insertions(+), 17 deletions(-) > > diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c > index 6ffda03a6349..6428834d7cd5 100644 > --- a/arch/powerpc/platforms/pseries/papr_scm.c > +++ b/arch/powerpc/platforms/pseries/papr_scm.c > @@ -285,7 +285,6 @@ int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, > } > > static const struct attribute_group *region_attr_groups[] = { > - &nd_region_attribute_group, > &nd_mapping_attribute_group, > NULL, > }; > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index b3213faf37b5..99e20b8b6ea0 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -2196,7 +2196,6 @@ static const struct attribute_group acpi_nfit_region_attribute_group = { > }; > > static const struct attribute_group *acpi_nfit_region_attribute_groups[] = { > - &nd_region_attribute_group, > &nd_mapping_attribute_group, > &acpi_nfit_region_attribute_group, > NULL, > diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c > index adde2864c6a4..9a971a59dec7 100644 > --- a/drivers/nvdimm/e820.c > +++ b/drivers/nvdimm/e820.c > @@ -13,11 +13,6 @@ static const struct attribute_group *e820_pmem_attribute_groups[] = { > NULL, > }; > > -static const struct attribute_group *e820_pmem_region_attribute_groups[] = { > - &nd_region_attribute_group, > - NULL, > -}; > - > static int e820_pmem_remove(struct platform_device *pdev) > { > struct nvdimm_bus *nvdimm_bus = platform_get_drvdata(pdev); > @@ -45,7 +40,6 @@ static int e820_register_one(struct resource *res, void *data) > > memset(&ndr_desc, 0, sizeof(ndr_desc)); > ndr_desc.res = res; > - ndr_desc.attr_groups = e820_pmem_region_attribute_groups; > ndr_desc.numa_node = e820_range_to_nid(res->start); > ndr_desc.target_node = ndr_desc.numa_node; > set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags); > diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c > index 41348fa6b74c..c0b5ac36df9d 100644 > --- a/drivers/nvdimm/of_pmem.c > +++ b/drivers/nvdimm/of_pmem.c > @@ -9,11 +9,6 @@ > #include > #include > > -static const struct attribute_group *region_attr_groups[] = { > - &nd_region_attribute_group, > - NULL, > -}; > - > static const struct attribute_group *bus_attr_groups[] = { > &nvdimm_bus_attribute_group, > NULL, > @@ -65,7 +60,6 @@ static int of_pmem_region_probe(struct platform_device *pdev) > * structures so passing a stack pointer is fine. > */ > memset(&ndr_desc, 0, sizeof(ndr_desc)); > - ndr_desc.attr_groups = region_attr_groups; > ndr_desc.numa_node = dev_to_node(&pdev->dev); > ndr_desc.target_node = ndr_desc.numa_node; > ndr_desc.res = &pdev->resource[i]; > diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c > index e4281f806adc..f97166583294 100644 > --- a/drivers/nvdimm/region_devs.c > +++ b/drivers/nvdimm/region_devs.c > @@ -757,14 +757,14 @@ struct attribute_group nd_mapping_attribute_group = { > }; > EXPORT_SYMBOL_GPL(nd_mapping_attribute_group); > > -struct attribute_group nd_region_attribute_group = { > +static const struct attribute_group nd_region_attribute_group = { > .attrs = nd_region_attributes, > .is_visible = region_visible, > }; > -EXPORT_SYMBOL_GPL(nd_region_attribute_group); > > static const struct attribute_group *nd_region_attribute_groups[] = { > &nd_device_attribute_group, > + &nd_region_attribute_group, > &nd_numa_attribute_group, > NULL, > }; > diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h > index e9a4e25fc708..312248d334c7 100644 > --- a/include/linux/libnvdimm.h > +++ b/include/linux/libnvdimm.h > @@ -67,7 +67,6 @@ enum { > > extern struct attribute_group nvdimm_bus_attribute_group; > extern struct attribute_group nvdimm_attribute_group; > -extern struct attribute_group nd_region_attribute_group; > extern struct attribute_group nd_mapping_attribute_group; > > struct nvdimm;