From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: return exit code 4 for skipped tests
Date: Tue, 08 Jan 2019 19:33:19 -0200 [thread overview]
Message-ID: <87zhsahm1s.fsf@morokweng.localdomain> (raw)
In-Reply-To: <20190108193108.GA12259@avx2>
Alexey Dobriyan <adobriyan@gmail.com> writes:
> Test harness uses 4 for SKIP, not 2.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> tools/testing/selftests/proc/proc-loadavg-001.c | 2 +-
> tools/testing/selftests/proc/proc-self-map-files-002.c | 2 +-
> tools/testing/selftests/proc/proc-self-syscall.c | 2 +-
> tools/testing/selftests/proc/proc-self-wchan.c | 2 +-
> tools/testing/selftests/proc/read.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> --- a/tools/testing/selftests/proc/proc-loadavg-001.c
> +++ b/tools/testing/selftests/proc/proc-loadavg-001.c
> @@ -30,7 +30,7 @@ int main(void)
>
> if (unshare(CLONE_NEWPID) == -1) {
> if (errno == ENOSYS || errno == EPERM)
> - return 2;
> + return 4;
> return 1;
> }
Can't these tests use the KSFT_SKIP macro defined in kselftest.h?
--
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2019-01-08 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 19:31 [PATCH] proc: return exit code 4 for skipped tests Alexey Dobriyan
2019-01-08 21:33 ` Thiago Jung Bauermann [this message]
2019-01-14 20:11 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhsahm1s.fsf@morokweng.localdomain \
--to=bauerman@linux.ibm.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).