From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbdKHTFF (ORCPT ); Wed, 8 Nov 2017 14:05:05 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:57422 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbdKHTFE (ORCPT ); Wed, 8 Nov 2017 14:05:04 -0500 From: Vivien Didelot To: Joe Perches , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops In-Reply-To: <1510163351.15768.29.camel@perches.com> References: <20171108171917.5965-1-vivien.didelot@savoirfairelinux.com> <20171108171917.5965-5-vivien.didelot@savoirfairelinux.com> <1510163351.15768.29.camel@perches.com> Date: Wed, 08 Nov 2017 14:05:02 -0500 Message-ID: <87zi7w617l.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joe, Joe Perches writes: > On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote: >> The DSA switch VLAN ops pass the switchdev_trans structure down to the >> drivers, but no one is using them and they aren't supposed to anyway. > [] >> diff --git a/include/net/dsa.h b/include/net/dsa.h > [] >> @@ -410,12 +410,10 @@ struct dsa_switch_ops { >> */ >> int (*port_vlan_filtering)(struct dsa_switch *ds, int port, >> bool vlan_filtering); >> - int (*port_vlan_prepare)(struct dsa_switch *ds, int port, >> - const struct switchdev_obj_port_vlan *vlan, >> - struct switchdev_trans *trans); >> - void (*port_vlan_add)(struct dsa_switch *ds, int port, >> - const struct switchdev_obj_port_vlan *vlan, >> - struct switchdev_trans *trans); >> + int (*port_vlan_prepare)(struct dsa_switch *ds, int port, >> + const struct switchdev_obj_port_vlan *vlan); >> + void (*port_vlan_add)(struct dsa_switch *ds, int port, >> + const struct switchdev_obj_port_vlan *vlan); >> int (*port_vlan_del)(struct dsa_switch *ds, int port, >> const struct switchdev_obj_port_vlan *vlan); > > I think this bit is slightly worse. > Mixing alignment styles seems odd. > > I think it's better to either align all the (*func) uses > on a tabstop or > none of them. I couldn't use a tab here as it is done in the other functions, because of the 80-char limit. I will send a patch soon to remove all of this alignment style in this header because it doesn't bring any value. Thanks, Vivien