From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751636AbdG0Jft convert rfc822-to-8bit (ORCPT ); Thu, 27 Jul 2017 05:35:49 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43802 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbdG0Jfs (ORCPT ); Thu, 27 Jul 2017 05:35:48 -0400 From: Punit Agrawal To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-4-punit.agrawal@arm.com> <20170720111732.GC18515@nazgul.tnic> <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> <20170720135446.GA20641@nazgul.tnic> <87shhrknes.fsf@e105922-lin.cambridge.arm.com> <20170721132731.GA5041@nazgul.tnic> Date: Thu, 27 Jul 2017 10:35:45 +0100 In-Reply-To: <20170721132731.GA5041@nazgul.tnic> (Borislav Petkov's message of "Fri, 21 Jul 2017 15:27:31 +0200") Message-ID: <87zibqi5n2.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, Apologies for the delayed response. I somehow managed to lose updates on this thread. Borislav Petkov writes: > On Thu, Jul 20, 2017 at 06:50:51PM +0100, Punit Agrawal wrote: >> "Firmware does not support APEI firmware first mode" >> >> Thoughts? > > I guess the simplest would be to add a third state to that hest_disable > to denote "HEST table not found" and then exit ghes_init() early, based on > checking it. Although simple, won't it make the already convoluted code flow more so. Instead in addition to not setting hest_disable when the table is not found ... > > Otherwise ghes_init() inits a bunch of things which you probably don't > want on a platform which doesn't support APEI. ... would you be open to a patch re-working the ghes driver initialisation to only do the platform driver registration. The the rest of the initialisation (including the apei_osc_setup and related messages) can be performed when the first ghes device gets probed. Does that sound like a better alternative? > > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)