From: Eric Anholt <eric@anholt.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Gerd Hoffmann <kraxel@redhat.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Cc: Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree.
Date: Fri, 09 Sep 2016 14:22:24 -0700 [thread overview]
Message-ID: <87zing7oq7.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <87650770.23554.026b1e4b-e35d-48e6-9394-7eeea0ff9add.open-xchange@email.1und1.de>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
>> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31
>> geschrieben:
>>
>>
>> From: Eric Anholt <eric@anholt.net>
>>
>> This will be used for having EMMC (sdhci-bcm2835.c) drive the
>> wireless.
>
> sdhci-bcm2835.c has been replaced by sdhci-iproc.c
>
>>
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> arch/arm/boot/dts/bcm283x.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
>> index 062d09db..b6b1950 100644
>> --- a/arch/arm/boot/dts/bcm283x.dtsi
>> +++ b/arch/arm/boot/dts/bcm283x.dtsi
>> @@ -257,6 +257,11 @@
>> brcm,pins = <32 33>;
>> brcm,function = <BCM2835_FSEL_ALT3>;
>> };
>> + emmc_gpio34: emmc_gpio34 {
>> + brcm,pins = <34 35 36 37 38 39>;
>> + brcm,function = <BCM2835_FSEL_ALT3>;
>> + brcm,pull = <0 2 2 2 2 2>;
>
> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h?
A fine idea, but it should not be a requirement for this series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-09-09 21:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1473244289-20728-1-git-send-email-kraxel@redhat.com>
2016-09-07 10:31 ` [PATCH 1/8] ARM: dts: bcm283x: Define standard pinctrl groups in the gpio node Gerd Hoffmann
2016-09-07 18:09 ` Stefan Wahren
2016-09-07 18:50 ` Eric Anholt
2016-09-08 7:48 ` Gerd Hoffmann
2016-09-08 17:55 ` Stefan Wahren
2016-09-09 9:05 ` Gerd Hoffmann
2016-09-09 14:12 ` Stefan Wahren
2016-09-09 21:20 ` Eric Anholt
2016-09-11 21:22 ` Dave Stevenson
2016-09-13 6:09 ` Eric Anholt
2016-09-07 10:31 ` [PATCH 2/8] ARM: dts: bcm283x: Add the emmc pin group to bcm283x.dtsi Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 3/8] ARM: dts: bcm283x: Add a group for mapping pins 48-53 to sdhost Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree Gerd Hoffmann
2016-09-07 18:13 ` Stefan Wahren
2016-09-08 7:44 ` Gerd Hoffmann
2016-09-08 12:06 ` Stefan Wahren
2016-09-09 8:26 ` Gerd Hoffmann
2016-09-09 8:47 ` Gerd Hoffmann
2016-09-08 19:50 ` Scott Branden
2016-09-09 6:58 ` Stefan Wahren
2016-09-09 16:37 ` Scott Branden
2016-09-09 21:22 ` Eric Anholt [this message]
2016-09-07 10:31 ` [PATCH 5/8] ARM: dts: bcm283x: add pinctrl group to &pwm, drop pins from &gpio Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 6/8] ARM: dts: bcm283x: add pinctrl group to &i2c0, " Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 7/8] ARM: dts: bcm283x: add pinctrl group to &i2c1, " Gerd Hoffmann
2016-09-07 10:31 ` [PATCH 8/8] ARM: dts: bcm283x: add pinctrl group to &sdhci, " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zing7oq7.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).