From: Andi Kleen <andi@firstfloor.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: faster /proc/*/status
Date: Sat, 06 Aug 2016 20:16:27 -0700 [thread overview]
Message-ID: <87ziop46b8.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <20160806125608.GB1187@p183.telecom.by> (Alexey Dobriyan's message of "Sat, 6 Aug 2016 15:56:11 +0300")
Alexey Dobriyan <adobriyan@gmail.com> writes:
> -
> + seq_printf(m, "State:\t%s", get_task_state(p));
> +
> + seq_puts(m, "\nTgid:\t");
The only different should be the format string.
Scanning the format string really shouldn't be that expensive?!?
It would be better if you could find out why that is slow and optimize
it. Then you would benefit every seq_printf user, not just this
special case.
Perhaps it could benefit from some of the bit masking tricks to
scan the string with wider tests than a word.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2016-08-07 3:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 12:56 [PATCH] proc: faster /proc/*/status Alexey Dobriyan
2016-08-06 22:41 ` Joe Perches
2016-08-09 3:02 ` [PATCH] seq/proc: Modify seq_put_decimal_[u]ll to take a const char *, not char Joe Perches
2016-08-07 3:16 ` Andi Kleen [this message]
2016-08-07 8:53 ` [PATCH] proc: faster /proc/*/status Alexey Dobriyan
2016-08-07 16:59 ` Andi Kleen
2016-08-07 17:39 ` Joe Perches
2016-08-07 17:44 ` Andi Kleen
2016-08-07 21:22 ` Joe Perches
2016-08-09 23:25 ` Andrew Morton
2016-08-10 6:38 ` [RFC PATCH] meminfo: Break apart a very long seq_printf with #ifdefs Joe Perches
2016-08-11 21:50 ` Andrew Morton
2016-08-11 21:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziop46b8.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).