From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbcF3Oro (ORCPT ); Thu, 30 Jun 2016 10:47:44 -0400 Received: from mail1.asahi-net.or.jp ([202.224.39.197]:25220 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932094AbcF3Orl (ORCPT ); Thu, 30 Jun 2016 10:47:41 -0400 Date: Thu, 30 Jun 2016 23:47:37 +0900 Message-ID: <87ziq2d986.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Sergei Shtylyov Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree In-Reply-To: References: <1467207667-15768-1-git-send-email-ysato@users.sourceforge.jp> <1467207667-15768-23-git-send-email-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.5 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-2022-JP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jun 2016 23:16:52 +0900, Sergei Shtylyov wrote: > > On 06/29/2016 04:41 PM, Yoshinori Sato wrote: > > > Changes v4 > > - split patch > > > > Signed-off-by: Yoshinori Sato > > [...] > > > diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts > > new file mode 100644 > > index 0000000..a1a0745 > > --- /dev/null > > +++ b/arch/sh/boot/dts/r2dplus.dts > > @@ -0,0 +1,83 @@ > > +/dts-v1/; > > + > > +#include "sh7751.dtsi" > > + > > +/ { > > + model = "Renesas RTS7751R2D+"; > > The ePAPR standard says: > > The recommended format is: “manufacturer,model”, where manufacturer > is a string describing the name of the manufacturer (such as a stock > ticker symbol), and model specifies the model number. OK. I lookd ePAPR standard. > > + compatible = "renesas,r2dplus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + interrupt-parent = <&shintc>; > > + chosen { > > + stdout-path = &sci1; > > + bootargs = "console=ttySC1,115200"; > > + }; > > + aliases { > > + serial1 = &sci1; > > + }; > > + > > + memory@0c000000 { > > + device_type = "memory"; > > + reg = <0x0c000000 0x4000000>; > > + }; > > Need empty line here... > > > + fpgaintc: fpga@a4000000 { > > + compatible = "renesas,r2dplus-intc"; > > + #interrupt-cells = <1>; > > + interrupt-controller; > > + reg = <0xa4000000 0x40>; > > + interrupt-map=<0 &shintc evt2irq(0x200)>, > > + <1 &shintc evt2irq(0x220)>, > > + <2 &shintc evt2irq(0x240)>, > > + <3 &shintc evt2irq(0x260)>, > > + <4 &shintc evt2irq(0x280)>, > > + <5 &shintc evt2irq(0x2a0)>, > > + <6 &shintc evt2irq(0x2c0)>, > > + <7 &shintc evt2irq(0x2e0)>, > > + <8 &shintc evt2irq(0x300)>, > > + <9 &shintc evt2irq(0x320)>, > > + <10 &shintc evt2irq(0x340)>, > > + <11 &shintc evt2irq(0x360)>, > > + <12 &shintc evt2irq(0x380)>, > > + <13 &shintc evt2irq(0x3a0)>, > > + <14 &shintc evt2irq(0x3c0)>; > > + }; > > + pata: pata@b4001000 { > > This node should be named "ide@..." to comply with ePAPR. OK. Thanks. > MBR, Sergei > -- Yoshinori Sato