From: Rusty Russell <rusty@rustcorp.com.au>
To: Kent Overstreet <koverstreet@google.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
Date: Fri, 07 Sep 2012 09:10:25 +0930 [thread overview]
Message-ID: <87zk52hg9i.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120906100247.GA27355@koverstreet-glaptop>
Kent Overstreet <koverstreet@google.com> writes:
> On Thu, Sep 06, 2012 at 12:49:56PM +0300, Michael S. Tsirkin wrote:
>> On Thu, Sep 06, 2012 at 02:25:12AM -0700, Kent Overstreet wrote:
>> > Do you not understand the difference between depends an selects?
>> > Or did you not read my original mail?
Now you're getting insulting.
It's normal for options to depend on other options. Sometimes they're
directly nested (eg. E1000 depends on NETDEVICES, and it's nested under
that option), sometimes they're not (eg. E1000 depends on PCI, which is
selected elsewhere).
The fact that you are only just realizing this is not Michael's problem.
>> > Flip off everything in drivers -> virtio
>> >
>> > Now go to drivers -> block and try to turn on virtio-blk.
>> >
>> > It's not listed!
>>
>> Yes. Because you disabled all virtio backends.
>> It does not make sense to have any frontends.
>
> How's a user - or even another kernel developer who isn't familiar with
> virtio - supposed to know that?
I get annoyed that menuconfig doesn't show options whose dependencies
aren't possible, too. (I got bitten the other way: it doesn't show
dependencies which can't be disabled, and I was trying to turn KALLSYMS
off).
But as I found out just last week, the '/' key allows you to find any
option, and shows what dependencies it has, and their values.
Hope that helps,
Rusty.
next prev parent reply other threads:[~2012-09-07 0:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 4:41 [PATCH] virtio-blk: Fix kconfig option Kent Overstreet
2012-09-03 4:46 ` Kent Overstreet
2012-09-04 6:23 ` Rusty Russell
2012-09-04 23:12 ` Kent Overstreet
2012-09-05 4:22 ` Asias He
2012-09-05 5:48 ` Michael S. Tsirkin
2012-09-05 5:54 ` Asias He
2012-09-05 6:04 ` Michael S. Tsirkin
2012-09-05 6:12 ` Michael S. Tsirkin
2012-09-06 1:46 ` Rusty Russell
2012-09-06 7:41 ` Kent Overstreet
2012-09-06 8:44 ` Michael S. Tsirkin
2012-09-06 9:25 ` Kent Overstreet
2012-09-06 9:49 ` Michael S. Tsirkin
2012-09-06 10:02 ` Kent Overstreet
2012-09-06 10:18 ` Michael S. Tsirkin
2012-09-06 10:31 ` Kent Overstreet
2012-09-06 11:09 ` Michael S. Tsirkin
2012-09-06 23:40 ` Rusty Russell [this message]
2012-09-07 0:25 ` Kent Overstreet
2012-09-07 2:57 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zk52hg9i.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).