From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA17C433FE for ; Fri, 30 Sep 2022 19:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbiI3Tl6 (ORCPT ); Fri, 30 Sep 2022 15:41:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231622AbiI3Tlz (ORCPT ); Fri, 30 Sep 2022 15:41:55 -0400 Received: from m-r1.th.seeweb.it (m-r1.th.seeweb.it [5.144.164.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79C3F149D20 for ; Fri, 30 Sep 2022 12:41:54 -0700 (PDT) Received: from [192.168.1.101] (95.49.31.201.neoplus.adsl.tpnet.pl [95.49.31.201]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id BAD52201B5; Fri, 30 Sep 2022 21:41:49 +0200 (CEST) Message-ID: <880e62cc-a12c-33b2-2509-f0e05a0871af@somainline.org> Date: Fri, 30 Sep 2022 21:41:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/3] arm64: dts: qcom: sdm850-samsung-w737: correct I2C12 pins drive strength Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Sudeep Holla , Lee Jones , Arnd Bergmann , Vinod Koul , Xilin Wu , Molly Sophia , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20220930192039.240486-1-krzysztof.kozlowski@linaro.org> <20220930192039.240486-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20220930192039.240486-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.09.2022 21:20, Krzysztof Kozlowski wrote: > The pin configuration (done with generic pin controller helpers and > as expressed by bindings) requires children nodes with either: > 1. "pins" property and the actual configuration, > 2. another set of nodes with above point. > > The qup_i2c12_default pin configuration used second method - with a > "pinmux" child. > > Fixes: d4b341269efb ("arm64: dts: qcom: Add support for Samsung Galaxy Book2") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts > index f954fe5cb61a..d028a7eb364a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts > @@ -415,8 +415,10 @@ pinconf { > }; > > &qup_i2c12_default { > - drive-strength = <2>; > - bias-disable; > + pinmux { > + drive-strength = <2>; > + bias-disable; > + }; > }; > > &qup_uart6_default {