From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754525AbdBAWud (ORCPT ); Wed, 1 Feb 2017 17:50:33 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45440 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753172AbdBAWub (ORCPT ); Wed, 1 Feb 2017 17:50:31 -0500 Subject: Re: [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table To: Dmitry Torokhov References: <20170128193558.GC38136@dtor-ws> <20170129180108.GA10743@dtor-ws> <20170201222832.GA25554@dtor-ws> Cc: "H. Nikolaus Schaller" , Mark Rutland , Michel Verlaan , Nick Dyer , Tony Lindgren , LKML , Benjamin Tissoires , linux-omap , Russell King , Igor Grinberg , Hans Verkuil , linux-input@vger.kernel.org, devicetree , Arnd Bergmann , Eric Engestrom , Hans de Goede , Rob Herring , =?UTF-8?Q?Mika_Penttil=c3=a4?= , Mauro Carvalho Chehab , Petr Cvek , Siebren Vroegindeweij , Sebastian Reichel , linux-iio@vger.kernel.org, "Andrew F. Davis" , Mark Brown , =?UTF-8?Q?Beno=c3=aet_Cousson?= , kernel@pyra-handheld.com, Michael Welling , Jonathan Cameron , Alexander Stein , Discussions about the Letux Kernel From: Javier Martinez Canillas Message-ID: <8810e197-f071-5a3d-c376-8c365fb60640@osg.samsung.com> Date: Wed, 1 Feb 2017 19:50:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170201222832.GA25554@dtor-ws> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Dmitry, On 02/01/2017 07:28 PM, Dmitry Torokhov wrote: [snip] >> >> As said, changing the core is trivial. A RFC patch is [0]. >> >> The problem is how to make sure that this change won't cause regressions >> in existing drivers. > > If the concern with drivers having I2C or SPI device table, but not OF > device table, then I think cocinnelle could be used to scan and find > them. > I don't think coccinelle is a good fit for this since you may have to look if a DTS is using in its compatible string a device that's in an SPI table or if a DT binding documents this device as a compatible string. But yes I get your point and I agree that is just a matter of having a script to look for these. Someone should have the time to write it though :) >> >> There was particularly tricky for the spi-nor driver, it doesn't help that >> a lot of DT are using undocumented compatible strings (sometimes with no >> vendor prefix). You can see the discussion here [1]. >> >> In the same thread Mark Brown said that it wasn't that bad to have the >> information in the OF device ID table duplicated in a SPI device table. >> >> Certainly isn't the best approach but IMHO is better than the module not >> loading. > > You can always build the module into kernel or load it by hand if it is > that important. Module autoloading does not work anyway if you have > several compatible strings, like > > compatible = "vendor,new-device", "vendor,generic-device"; > > Thanks. > Agree. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America