From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF47C433ED for ; Fri, 23 Apr 2021 10:48:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9300613B7 for ; Fri, 23 Apr 2021 10:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242188AbhDWKsp (ORCPT ); Fri, 23 Apr 2021 06:48:45 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:36448 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242162AbhDWKsl (ORCPT ); Fri, 23 Apr 2021 06:48:41 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id E9AFC1F43A37 Subject: Re: [PATCH 025/190] Revert "platform/chrome: cros_ec_ishtp: Fix a double-unlock issue" To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Qiushi Wu , Mathew King , Benson Leung , Rushikesh S Kadam References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-26-gregkh@linuxfoundation.org> From: Enric Balletbo i Serra Message-ID: <8825f20c-7e58-c44e-fa7a-bca811add5a1@collabora.com> Date: Fri, 23 Apr 2021 12:48:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210421130105.1226686-26-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, Many thanks for the patchset and notice us to take attention about these patches. On 21/4/21 14:58, Greg Kroah-Hartman wrote: > This reverts commit aaa3cbbac326c95308e315f1ab964a3369c4d07d. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Qiushi Wu > Cc: Mathew King > Cc: Enric Balletbo i Serra > Signed-off-by: Greg Kroah-Hartman I've reviewed the patch again (also double checked with people involved in this driver) and I don't spot an obvious issue with the original patch. Without it, on error path, the read-write sempahore used, will be released without having held it before. So it's IMO a valid fix that would have to be done the same way after revert. Please don't revert it. Thanks, Enric > --- > drivers/platform/chrome/cros_ec_ishtp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c > index f00107017318..d4f41d68232c 100644 > --- a/drivers/platform/chrome/cros_ec_ishtp.c > +++ b/drivers/platform/chrome/cros_ec_ishtp.c > @@ -677,10 +677,8 @@ static int cros_ec_ishtp_probe(struct ishtp_cl_device *cl_device) > > /* Register croc_ec_dev mfd */ > rv = cros_ec_dev_init(client_data); > - if (rv) { > - down_write(&init_lock); > + if (rv) > goto end_cros_ec_dev_init_error; > - } > > return 0; > >