From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DATE_IN_PAST_06_12, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AE9C433E0 for ; Mon, 29 Jun 2020 21:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87F54208B6 for ; Mon, 29 Jun 2020 21:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387505AbgF2VaB (ORCPT ); Mon, 29 Jun 2020 17:30:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:40462 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728888AbgF2SlY (ORCPT ); Mon, 29 Jun 2020 14:41:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8266DAFAA; Mon, 29 Jun 2020 10:27:20 +0000 (UTC) Subject: Re: [PATCH for v5.8 3/3] mm/memory: fix IO cost for anonymous page To: js1304@gmail.com, Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Rik van Riel , Minchan Kim , Michal Hocko , kernel-team@lge.com, Joonsoo Kim References: <1592288204-27734-1-git-send-email-iamjoonsoo.kim@lge.com> <1592288204-27734-4-git-send-email-iamjoonsoo.kim@lge.com> From: Vlastimil Babka Message-ID: <882baec9-6d8e-55e9-ef67-67266458cbe0@suse.cz> Date: Mon, 29 Jun 2020 12:27:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <1592288204-27734-4-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/20 8:16 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > With synchronous IO swap device, swap-in is directly handled in fault > code. Since IO cost notation isn't added there, with synchronous IO swap > device, LRU balancing could be wrongly biased. Fix it to count it > in fault code. > > Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka > --- > mm/memory.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/mm/memory.c b/mm/memory.c > index bc6a471..3359057 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3143,6 +3143,14 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > if (err) > goto out_page; > > + /* > + * XXX: Move to lru_cache_add() when it > + * supports new vs putback > + */ > + spin_lock_irq(&page_pgdat(page)->lru_lock); > + lru_note_cost_page(page); > + spin_unlock_irq(&page_pgdat(page)->lru_lock); > + > lru_cache_add(page); > swap_readpage(page, true); > } >