linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mihai Carabas <mihai.carabas@oracle.com>
To: linux-arm-kernel@lists.infradead.org,
	Peter Zijlstra <peterz@infradead.org>
Cc: kvm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
	will@kernel.org, tglx@linutronix.de, mingo@redhat.com,
	bp@alien8.de, x86@kernel.org, hpa@zytor.com, pbonzini@redhat.com,
	wanpengli@tencent.com, vkuznets@redhat.com, rafael@kernel.org,
	daniel.lezcano@linaro.org, akpm@linux-foundation.org,
	pmladek@suse.com, peterz@infradead.org, dianders@chromium.org,
	npiggin@gmail.com, rick.p.edgecombe@intel.com,
	joao.m.martins@oracle.com, juerg.haefliger@canonical.com,
	mic@digikod.net, arnd@arndb.de, ankur.a.arora@oracle.com
Subject: Re: [PATCH v2] Enable haltpoll for arm64
Date: Thu, 25 Jan 2024 16:39:17 +0200	[thread overview]
Message-ID: <88356fdc-91f4-4f43-97a5-3da0ce455515@oracle.com> (raw)
In-Reply-To: <1700488898-12431-1-git-send-email-mihai.carabas@oracle.com>

Hello,

How can we move this patchset forward?

Thank you,
Mihai

La 20.11.2023 16:01, Mihai Carabas a scris:
> This patchset enables the usage of haltpoll governer on arm64. This is
> specifically interesting for KVM guests by reducing the IPC latencies.
>
> Here are some benchmarks without/with haltpoll for a KVM guest:
>
> a) without haltpoll:
> perf bench sched pipe
> # Running 'sched/pipe' benchmark:
> # Executed 1000000 pipe operations between two processes
>
>       Total time: 8.138 [sec]
>
>              8.138094 usecs/op
>               122878 ops/sec
>
> b) with haltpoll:
> perf bench sched pipe
> # Running 'sched/pipe' benchmark:
> # Executed 1000000 pipe operations between two processes
>
>       Total time: 5.003 [sec]
>
>              5.003085 usecs/op
>               199876 ops/sec
>
> v2 changes from v1:
> - added patch 7 where we change cpu_relax with smp_cond_load_relaxed per PeterZ
>    (this improves by 50% at least the CPU cycles consumed in the tests above:
>    10,716,881,137 now vs 14,503,014,257 before)
> - removed the ifdef from patch 1 per RafaelW
>
>
> Joao Martins (6):
>    x86: Move ARCH_HAS_CPU_RELAX to arch
>    x86/kvm: Move haltpoll_want() to be arch defined
>    governors/haltpoll: Drop kvm_para_available() check
>    arm64: Select ARCH_HAS_CPU_RELAX
>    arm64: Define TIF_POLLING_NRFLAG
>    cpuidle-haltpoll: ARM64 support
>
> Mihai Carabas (1):
>    cpuidle/poll_state: replace cpu_relax with smp_cond_load_relaxed
>
>   arch/Kconfig                            |  3 +++
>   arch/arm64/Kconfig                      |  1 +
>   arch/arm64/include/asm/thread_info.h    |  6 ++++++
>   arch/x86/Kconfig                        |  1 +
>   arch/x86/include/asm/cpuidle_haltpoll.h |  1 +
>   arch/x86/kernel/kvm.c                   | 10 ++++++++++
>   drivers/cpuidle/Kconfig                 |  4 ++--
>   drivers/cpuidle/cpuidle-haltpoll.c      |  8 ++------
>   drivers/cpuidle/governors/haltpoll.c    |  5 +----
>   drivers/cpuidle/poll_state.c            | 14 +++++++++-----
>   include/linux/cpuidle_haltpoll.h        |  5 +++++
>   11 files changed, 41 insertions(+), 17 deletions(-)
>


  parent reply	other threads:[~2024-01-25 14:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20 14:01 [PATCH v2] Enable haltpoll for arm64 Mihai Carabas
2023-11-20 14:01 ` [PATCH 1/7] x86: Move ARCH_HAS_CPU_RELAX to arch Mihai Carabas
2023-11-27 14:44   ` Petr Mladek
2023-11-28 14:09     ` Mihai Carabas
2023-11-20 14:01 ` [PATCH 2/7] x86/kvm: Move haltpoll_want() to be arch defined Mihai Carabas
2023-11-29 20:55   ` Rafael J. Wysocki
2023-11-20 14:01 ` [PATCH 3/7] governors/haltpoll: Drop kvm_para_available() check Mihai Carabas
2023-11-20 14:01 ` [PATCH 4/7] arm64: Select ARCH_HAS_CPU_RELAX Mihai Carabas
2023-11-20 14:01 ` [PATCH 5/7] arm64: Define TIF_POLLING_NRFLAG Mihai Carabas
2023-11-20 14:01 ` [PATCH 6/7] cpuidle-haltpoll: ARM64 support Mihai Carabas
2023-11-20 14:01 ` [PATCH 7/7] cpuidle/poll_state: replace cpu_relax with smp_cond_load_relaxed Mihai Carabas
2023-11-22 20:51   ` Christoph Lameter
2023-11-22 21:33     ` Mihai Carabas
2023-11-27 20:17       ` Christoph Lameter (Ampere)
2023-12-01  6:59         ` Ankur Arora
2023-12-11 11:46   ` Will Deacon
2024-01-28 21:22     ` Mihai Carabas
2024-01-29 18:15       ` Will Deacon
2024-02-05 12:28         ` Mihai Carabas
2024-02-05 19:33           ` Ankur Arora
2024-01-17 21:19 ` [PATCH v2] Enable haltpoll for arm64 Christoph Lameter (Ampere)
2024-01-25 14:39 ` Mihai Carabas [this message]
2024-01-25 15:16   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88356fdc-91f4-4f43-97a5-3da0ce455515@oracle.com \
    --to=mihai.carabas@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=ankur.a.arora@oracle.com \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dianders@chromium.org \
    --cc=hpa@zytor.com \
    --cc=joao.m.martins@oracle.com \
    --cc=juerg.haefliger@canonical.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=mingo@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rafael@kernel.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).