From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jerome Brunet <jbrunet@baylibre.com>, Mark Brown <broonie@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] ASoC: da7219: properly get clk from the provider
Date: Mon, 26 Apr 2021 13:39:34 -0500 [thread overview]
Message-ID: <883fda5c-0ef5-8b9c-80fa-4348b4368f5c@linux.intel.com> (raw)
In-Reply-To: <69eaa840-ed77-fc01-2925-7e5e9998e80f@linux.intel.com>
> On 4/21/21 7:05 AM, Jerome Brunet wrote:
>> Instead of using the clk embedded in the clk_hw (which is meant to go
>> away), a clock provider which need to interact with its own clock should
>> request clk reference through the clock provider API.
>>
>> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> This patch seems to introduce a regression in our modprobe/rmmod tests
>
> https://github.com/thesofproject/linux/pull/2870
>
> RMMOD snd_soc_da7219
> rmmod: ERROR: Module snd_soc_da7219 is in use
>
> Reverting this patch restores the ability to remove the module.
>
> Wondering if devm_ increases a module/device refcount somehow?
the following diff fixes the issue for me
There is an explicit try_module_get() in clk_hw_create_clk, so you
end-up increasing the refcount of your own module.
devm_ doesn't seem like a good idea here, I think we have to release the
clk and its implicit module reference when the component is freed, no?
I can send a proper fix if there is consensus.
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index bd3c523a8617..8696ac749af3 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -2182,7 +2182,7 @@ static int da7219_register_dai_clks(struct
snd_soc_component *component)
goto err;
}
- da7219->dai_clks[i] = devm_clk_hw_get_clk(dev,
dai_clk_hw, NULL);
+ da7219->dai_clks[i] = clk_hw_get_clk(dai_clk_hw, NULL);
if (IS_ERR(da7219->dai_clks[i]))
return PTR_ERR(da7219->dai_clks[i]);
@@ -2218,6 +2218,8 @@ static int da7219_register_dai_clks(struct
snd_soc_component *component)
if (da7219->dai_clks_lookup[i])
clkdev_drop(da7219->dai_clks_lookup[i]);
+ clk_put(da7219->dai_clks[i]);
+
clk_hw_unregister(&da7219->dai_clks_hw[i]);
} while (i-- > 0);
@@ -2240,6 +2242,8 @@ static void da7219_free_dai_clks(struct
snd_soc_component *component)
if (da7219->dai_clks_lookup[i])
clkdev_drop(da7219->dai_clks_lookup[i]);
+ clk_put(da7219->dai_clks[i]);
+
clk_hw_unregister(&da7219->dai_clks_hw[i]);
}
next prev parent reply other threads:[~2021-04-26 18:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 12:05 [PATCH v2 0/5] ASoC: clock provider clean-up Jerome Brunet
2021-04-21 12:05 ` [PATCH v2 1/5] ASoC: stm32: properly get clk from the provider Jerome Brunet
2021-04-21 12:05 ` [PATCH v2 2/5] ASoC: wcd934x: use the clock provider API Jerome Brunet
2021-04-21 12:05 ` [PATCH v2 3/5] ASoC: rt5682: clock driver must " Jerome Brunet
2021-04-21 12:05 ` [PATCH v2 4/5] ASoC: lpass: " Jerome Brunet
2021-04-21 12:05 ` [PATCH v2 5/5] ASoC: da7219: properly get clk from the provider Jerome Brunet
2021-04-26 18:10 ` Pierre-Louis Bossart
2021-04-26 18:39 ` Pierre-Louis Bossart [this message]
2021-04-26 19:35 ` Jerome Brunet
2021-04-27 9:16 ` Jerome Brunet
2021-04-27 10:27 ` Mark Brown
2021-04-27 11:33 ` Jerome Brunet
2021-04-23 18:06 ` [PATCH v2 0/5] ASoC: clock provider clean-up Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883fda5c-0ef5-8b9c-80fa-4348b4368f5c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).