From: Ben Hutchings <ben@decadent.org.uk>
To: Manfred Spraul <manfred@colorfullife.com>,
Arnd Bergmann <arnd@arndb.de>,
"kernelci.org bot" <bot@kernelci.org>
Cc: Kernel Build Reports Mailman List
<kernel-build-reports@lists.linaro.org>,
"3.16.x" <stable@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: stable/linux-3.16.y build: 178 builds: 1 failed, 177 passed, 2 errors, 57 warnings (v3.16.52)
Date: Sun, 11 Nov 2018 01:47:27 +0000 [thread overview]
Message-ID: <885e13ee1ad51cd3a841378ed4b50878f7f61b72.camel@decadent.org.uk> (raw)
In-Reply-To: <0ecf39a8-dfc1-e895-ad6b-e2cf21a30e01@colorfullife.com>
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
On Sat, 2018-01-13 at 19:51 +0100, Manfred Spraul wrote:
> Hi Arnd,
>
> On 01/03/2018 12:15 AM, Arnd Bergmann wrote:
> > > 2 ipc/sem.c:377:6: warning: '___p1' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > This code was last touched in 3.16 by the backport of commit
> > 5864a2fd3088 ("ipc/sem.c: fix complex_count vs. simple op race")
> >
> > The warning is in "smp_load_acquire(&sma->complex_mode))", and I suspect
> > that commit 27d7be1801a4 ("ipc/sem.c: avoid using spin_unlock_wait()")
> > avoided the warning upstream by removing the smp_mb() before it.
> The smp_mb() pairs with spin_unlock_wait() in complexmode_enter()
> It is removed by commit 27d7be1801a4 ("ipc/sem.c: avoid using
> spin_unlock_wait()").
>
> From what I see, it doesn't exist in any of the stable kernels
> (intentionally, the above commit is a rewrite for better performance).
>
> ___p1 is from smp_load_acquire()
> > typeof(*p) ___p1 = READ_ONCE(*p); \
>
> I don't see how ___p1 could be used uninitialized. Perhaps a compiler issue?
On arm64 smp_load_acquire() was implemented in assembly that only
supported 4-byte and 8-byte words. And complex_mode is a bool (1-byte)
field.
So I believe the fix is:
878a84d5a8a1 arm64: add missing data types in smp_load_acquire/smp_store_release
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-11-11 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5a4b7192.08f4500a.dd9fa.064c@mx.google.com>
2018-01-02 23:15 ` stable/linux-3.16.y build: 178 builds: 1 failed, 177 passed, 2 errors, 57 warnings (v3.16.52) Arnd Bergmann
2018-01-13 18:51 ` Manfred Spraul
2018-11-11 1:47 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885e13ee1ad51cd3a841378ed4b50878f7f61b72.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=arnd@arndb.de \
--cc=bot@kernelci.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).