From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Viken Dadhaniya <quic_vdadhani@quicinc.com>,
cros-qcom-dts-watchers@chromium.org, andersson@kernel.org,
swboyd@chromium.org, robh@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
rajpat@codeaurora.org, mka@chromium.org, rojay@codeaurora.org
Cc: quic_msavaliy@quicinc.com, quic_anupkulk@quicinc.com
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration
Date: Tue, 16 Apr 2024 16:39:25 +0200 [thread overview]
Message-ID: <886befb2-2be2-4db0-b205-b3d1043cde62@linaro.org> (raw)
In-Reply-To: <D0LINETM8WNA.27BORT75W1N0C@fairphone.com>
On 4/16/24 13:38, Luca Weiss wrote:
> On Tue Apr 16, 2024 at 12:56 PM CEST, Viken Dadhaniya wrote:
>> Remove CTS and RTS pinctrl configuration for UART5 node as
>> it's designed for debug UART for all the board variants of the
>> sc7280 chipset.
>>
>> Also change compatible string to debug UART.
>
> This change has little to do with the SoC design though and is dependent
> on the usage on a given board, right? Also the QCM6490 datasheet
> mentions gpio21 & gpio22 can be used for UART_CTS and UART_RFR.
Yeah, using it as a debug uart doesn't rule out flow control I don't think
>
> But at least consistency-wise this change makes sense, in practically
> all other SoCs one UART is marked as geni-debug-uart.
>
> But with this patch you should then also remove some overrides that are
> placed in various boards already?
>
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts: compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts: compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts: compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi: compatible = "qcom,geni-debug-uart";
> arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi: compatible = "qcom,geni-debug-uart";
Definitely
Konrad
next prev parent reply other threads:[~2024-04-16 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 10:56 [PATCH v1] arm64: dts: qcom: sc7280: Remove CTS/RTS configuration Viken Dadhaniya
2024-04-16 11:38 ` Luca Weiss
2024-04-16 14:39 ` Konrad Dybcio [this message]
2024-04-24 8:00 ` Viken Dadhaniya
2024-04-24 7:59 ` Viken Dadhaniya
2024-04-17 4:39 ` Bjorn Andersson
2024-04-24 8:01 ` Viken Dadhaniya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886befb2-2be2-4db0-b205-b3d1043cde62@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mka@chromium.org \
--cc=quic_anupkulk@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=rajpat@codeaurora.org \
--cc=robh@kernel.org \
--cc=rojay@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).