From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: "Avri Altman" <avri.altman@wdc.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Tony Lindgren" <tony@atomide.com>,
"Bean Huo" <beanhuo@micron.com>,
"Gražvydas Ignotas" <notasas@gmail.com>,
linux-mmc@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com
Subject: Re: [RFC v4 2/6] mmc: core: allow to match the device tree to apply quirks
Date: Mon, 8 Nov 2021 17:01:01 +0100 [thread overview]
Message-ID: <8874B3D3-E2D1-4743-B9B6-F2FD3EB4033F@goldelico.com> (raw)
In-Reply-To: <10252914.21crK1JNra@pc-42>
> Am 08.11.2021 um 16:34 schrieb Jérôme Pouiller <jerome.pouiller@silabs.com>:
>
> On Monday 8 November 2021 16:00:02 CET Ulf Hansson wrote:
>> On Sat, 6 Nov 2021 at 15:31, H. Nikolaus Schaller <hns@goldelico.com> wrote:
>>>
>>> Hi Jérôme,
>>>
>>>> Am 05.11.2021 um 15:27 schrieb Jérôme Pouiller <jerome.pouiller@silabs.com>:
>>>>
>>>> On Friday 5 November 2021 10:05:47 CET H. Nikolaus Schaller wrote:
>>>>> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>>>>>
>>>>> MMC subsystem provides a way to apply quirks when a device match some
>>>>> properties (VID, PID, etc...) Unfortunately, some SDIO devices does not
>>>>> comply with the SDIO specification and does not provide reliable VID/PID
>>>>> (eg. Silabs WF200).
>>>>>
>>>>> So, the drivers for these devices rely on device tree to identify the
>>>>> device.
>>>>>
>>>>> This patch allows the MMC to also rely on the device tree to apply a
>>>>> quirk.
>>>>>
>>>>> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> [...]
>
>>>>> ---
>>>>> drivers/mmc/core/card.h | 3 +++
>>>>> drivers/mmc/core/quirks.h | 17 +++++++++++++++++
>>>>> 2 files changed, 20 insertions(+)
>>>>>
>>>>> +static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card,
>>>>> + const char *const *compat_list)
>>
>> After a second thought, I am not sure we really need a list of
>> compatibles here. The quirks we may want to apply should be specific
>> per device and most likely not shared among a family of devices, don't
>> you think?
>
> Indeed. I dislike to have to declare a list of compatible device (see
> wl1251_compatible_list in patch 5) outside of the fixup list.
>
> If I have several devices, I prefer to copy-paste a few lines in the
> mmc_fixup list (for the WFX driver, I have 4 devices to declare).
Agreed. It makes the macro easier to use.
BR and thanks,
Nikolaus
next prev parent reply other threads:[~2021-11-08 16:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 9:05 [RFC v4 0/6] mmc: core: extend mmc_fixup_device and transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 1/6] mmc: core: rewrite mmc_fixup_device() H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 2/6] mmc: core: allow to match the device tree to apply quirks H. Nikolaus Schaller
2021-11-05 14:27 ` Jérôme Pouiller
2021-11-06 14:31 ` H. Nikolaus Schaller
2021-11-08 15:00 ` Ulf Hansson
2021-11-08 15:34 ` Jérôme Pouiller
2021-11-08 16:01 ` H. Nikolaus Schaller [this message]
2021-11-05 9:05 ` [RFC v4 3/6] mmc: core: provide macro and table " H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 4/6] mmc: core: add new calls to mmc_fixup_device(sdio_card_init_methods) H. Nikolaus Schaller
2021-11-08 15:08 ` Ulf Hansson
2021-11-08 16:07 ` H. Nikolaus Schaller
2021-11-08 15:39 ` Jérôme Pouiller
2021-11-08 16:04 ` H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 5/6] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc H. Nikolaus Schaller
2021-11-08 15:33 ` Ulf Hansson
2021-11-08 16:08 ` H. Nikolaus Schaller
2021-11-09 10:58 ` H. Nikolaus Schaller
2021-11-09 20:01 ` Ulf Hansson
2021-11-10 16:36 ` H. Nikolaus Schaller
2021-11-10 17:03 ` Ulf Hansson
2021-11-10 17:09 ` H. Nikolaus Schaller
2021-11-05 9:05 ` [RFC v4 6/6] mmc: host: omap_hsmmc: revert special init for wl1251 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8874B3D3-E2D1-4743-B9B6-F2FD3EB4033F@goldelico.com \
--to=hns@goldelico.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jerome.pouiller@silabs.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=shawn.lin@rock-chips.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).