From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Cc: s.nawrocki@samsung.com, broonie@kernel.org
Subject: Re: [PATCH -next 2/4] ASoC: samsung: pcm: Use devm_platform_get_and_ioremap_resource()
Date: Mon, 21 Jun 2021 11:22:43 +0200 [thread overview]
Message-ID: <88808fcb-d89b-9e90-bd5e-c9074f373192@canonical.com> (raw)
In-Reply-To: <20210616091652.2552927-3-yangyingliang@huawei.com>
On 16/06/2021 11:16, Yang Yingliang wrote:
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> sound/soc/samsung/pcm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
> index bfd76e9cc0ca..4c4dfde0568f 100644
> --- a/sound/soc/samsung/pcm.c
> +++ b/sound/soc/samsung/pcm.c
> @@ -512,8 +512,7 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
> /* Default is 128fs */
> pcm->sclk_per_fs = 128;
>
> - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - pcm->regs = devm_ioremap_resource(&pdev->dev, mem_res);
> + pcm->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem_res);
> if (IS_ERR(pcm->regs))
> return PTR_ERR(pcm->regs);
>
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-06-21 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:16 [PATCH -next 0/4] ASoC: samsung: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2021-06-16 9:16 ` [PATCH -next 1/4] ASoC: samsung: i2s: " Yang Yingliang
2021-06-21 9:22 ` Krzysztof Kozlowski
2021-06-16 9:16 ` [PATCH -next 2/4] ASoC: samsung: pcm: " Yang Yingliang
2021-06-21 9:22 ` Krzysztof Kozlowski [this message]
2021-06-16 9:16 ` [PATCH -next 3/4] ASoC: samsung: s3c2412-i2s: " Yang Yingliang
2021-06-21 9:22 ` Krzysztof Kozlowski
2021-06-16 9:16 ` [PATCH -next 4/4] ASoC: samsung: s3c24xx-i2s: " Yang Yingliang
2021-06-21 9:22 ` Krzysztof Kozlowski
2021-06-21 18:46 ` [PATCH -next 0/4] ASoC: samsung: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88808fcb-d89b-9e90-bd5e-c9074f373192@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).