From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71048C3F2CD for ; Mon, 2 Mar 2020 14:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4775821775 for ; Mon, 2 Mar 2020 14:50:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iIpbY6XD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbgCBOuO (ORCPT ); Mon, 2 Mar 2020 09:50:14 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:21595 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727112AbgCBOuN (ORCPT ); Mon, 2 Mar 2020 09:50:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583160612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rHjGdoM/kz+qPoO2ABvyQ7EE/HX9YQYgQRurjxXqWRI=; b=iIpbY6XDyI79g4Jr6H5wpUlrZCPYsRiu56qS2+OhrFWnL0l4/UxvlSZlpsnpIj+GHR1XZz S0U9Yo2D4FKgDQ9FDwq4oW9Vgs+LcFWYbdWsak+7bmqgJkJRbq8oNyabeCJ3Dx97dMWQeI 8rN5CjXS6WIovy+C50OQ9HEN+NslbfU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-349-BIe46xGPNi2Gkh1qTttGxQ-1; Mon, 02 Mar 2020 09:50:09 -0500 X-MC-Unique: BIe46xGPNi2Gkh1qTttGxQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 50DC41084420; Mon, 2 Mar 2020 14:50:07 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64C677386B; Mon, 2 Mar 2020 14:50:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200302143546.srzk3rnh4o6s76a7@wittgenstein> References: <20200302143546.srzk3rnh4o6s76a7@wittgenstein> <20200302115239.pcxvej3szmricxzu@wittgenstein> <96563.1582901612@warthog.procyon.org.uk> <20200228152427.rv3crd7akwdhta2r@wittgenstein> <87h7z7ngd4.fsf@oldenburg2.str.redhat.com> <848282.1583159228@warthog.procyon.org.uk> To: Christian Brauner Cc: dhowells@redhat.com, Florian Weimer , linux-api@vger.kernel.org, viro@zeniv.linux.org.uk, metze@samba.org, torvalds@linux-foundation.org, cyphar@cyphar.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Have RESOLVE_* flags superseded AT_* flags for new syscalls? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <888182.1583160603.1@warthog.procyon.org.uk> Date: Mon, 02 Mar 2020 14:50:03 +0000 Message-ID: <888183.1583160603@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Brauner wrote: > I think we settled this and can agree on RESOLVE_NO_SYMLINKS being the > right thing to do, i.e. not resolving symlinks will stay opt-in. > Or is your worry even with the current semantics of openat2()? I don't > see the issue since O_NOFOLLOW still works with openat2(). Say, for example, my home dir is on a network volume somewhere and /home has a symlink pointing to it. RESOLVE_NO_SYMLINKS cannot be used to access a file inside my homedir if the pathwalk would go through /home/dhowells - this would affect fsinfo() - so RESOLVE_NO_SYMLINKS is not a substitute for AT_SYMLINK_NOFOLLOW (O_NOFOLLOW would not come into it). David