From: Ronak Doshi <doshir@vmware.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Petr Vandrovec <petr@vmware.com>,
Pv-drivers <Pv-drivers@vmware.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures
Date: Fri, 22 Jan 2021 08:24:59 +0000 [thread overview]
Message-ID: <888F37FB-B8BD-43D8-9E75-4F1CE9D4FAC7@vmware.com> (raw)
In-Reply-To: <20210121170705.08ecb23d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 1/21/21, 5:07 PM, "Jakub Kicinski" <kuba@kernel.org> wrote:
> On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote:
> > From: Petr Vandrovec <petr@vmware.com>
> >
> > vmxnet3: Remove buf_info from device accessible structures
>
> Something happened to the posting, looks like the subject is listed
> twice?
It got sent twice. Please ignore.
> > - if (!tq->buf_info)
> > + tq->buf_info = kmalloc_array_node(tq->tx_ring.size, sizeof(tq->buf_info[0]),
> > + GFP_KERNEL | __GFP_ZERO,
> > + dev_to_node(&adapter->pdev->dev));
>
> kcalloc_node()
Sure, will use this callback.
> > + if (!tq->buf_info) {
> > + netdev_err(adapter->netdev, "failed to allocate tx buffer info\n")
>
> Please drop the message, OOM splat will be visible enough. checkpatch
> usually points this out
Okay, will drop it. Checkpatch did not complain about the error message though.
Thanks,
Ronak
next prev parent reply other threads:[~2021-01-22 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 2:19 [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures Ronak Doshi
2021-01-22 1:07 ` Jakub Kicinski
2021-01-22 8:24 ` Ronak Doshi [this message]
2021-01-22 17:50 ` Jakub Kicinski
2021-01-22 18:37 ` [PATCH] checkpatch: Add kmalloc_array_node to unnecessary OOM message check Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 2:11 [PATCH net-next] vmxnet3: Remove buf_info from device accessible structures Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=888F37FB-B8BD-43D8-9E75-4F1CE9D4FAC7@vmware.com \
--to=doshir@vmware.com \
--cc=Pv-drivers@vmware.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).