From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28231C43381 for ; Wed, 27 Feb 2019 06:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01DCB218D9 for ; Wed, 27 Feb 2019 06:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729846AbfB0GUN (ORCPT ); Wed, 27 Feb 2019 01:20:13 -0500 Received: from mgwkm04.jp.fujitsu.com ([202.219.69.171]:45956 "EHLO mgwkm04.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729529AbfB0GUM (ORCPT ); Wed, 27 Feb 2019 01:20:12 -0500 Received: from ttb-m1.gw.nic.fujitsu.com (unknown [192.168.231.165]) by mgwkm04.jp.fujitsu.com with smtp id 2b54_1a46_c64b7e80_940e_4968_b273_3405b670eda3; Wed, 27 Feb 2019 15:20:08 +0900 Received: from g01jpfmpwkw03.exch.g01.fujitsu.local (g01jpfmpwkw03.exch.g01.fujitsu.local [10.0.193.57]) by ttb-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id E615840ABA29 for ; Wed, 27 Feb 2019 15:20:05 +0900 (JST) Received: from G01JPEXCHKW16.g01.fujitsu.local (G01JPEXCHKW16.g01.fujitsu.local [10.0.194.55]) by g01jpfmpwkw03.exch.g01.fujitsu.local (Postfix) with ESMTP id 077F2BD66DF; Wed, 27 Feb 2019 15:20:05 +0900 (JST) Received: from G01JPEXMBKW03.g01.fujitsu.local ([10.0.194.67]) by g01jpexchkw16 ([10.0.194.55]) with mapi id 14.03.0415.000; Wed, 27 Feb 2019 15:20:05 +0900 From: "Zhang, Lei" To: 'James Morse' CC: Mark Rutland , 'Catalin Marinas' , 'Will Deacon' , "'linux-kernel@vger.kernel.org'" , "'linux-arm-kernel@lists.infradead.org'" Subject: RE: [PATCH v4] arm64: Add workaround for Fujitsu A64FX erratum 010001 Thread-Topic: [PATCH v4] arm64: Add workaround for Fujitsu A64FX erratum 010001 Thread-Index: AdTENhuVebuKtHOoRzCPb6sZ5vznO///+H8AgAAo/wD//jk2sP/v2FHAgCMpHID//QDzQA== Date: Wed, 27 Feb 2019 06:20:04 +0000 Message-ID: <8898674D84E3B24BA3A2D289B872026A6A3336C8@G01JPEXMBKW03> References: <8898674D84E3B24BA3A2D289B872026A6A311EAE@G01JPEXMBKW03> <20190214155605.GC27547@lakrids.cambridge.arm.com> <90347cf4-4d7b-d553-d4db-1bacd000ff75@arm.com> <8898674D84E3B24BA3A2D289B872026A6A313313@G01JPEXMBKW03> <8898674D84E3B24BA3A2D289B872026A6A319D26@G01JPEXMBKW03> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-securitypolicycheck: OK by SHieldMailChecker v2.2.3 x-shieldmailcheckerpolicyversion: FJ-ISEC-20140219 x-originating-ip: [10.18.70.198] Content-Type: text/plain; charset="iso-2022-jp" MIME-Version: 1.0 X-SecurityPolicyCheck-GC: OK by FENCE-Mail X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, > -----Original Message----- > From: linux-arm-kernel On > Behalf Of James Morse > Sent: Tuesday, February 26, 2019 2:29 AM > To: Zhang, Lei/張 雷 > Cc: Mark Rutland ; 'Catalin Marinas' > ; 'Will Deacon' ; > 'linux-kernel@vger.kernel.org' ; > 'linux-arm-kernel@lists.infradead.org' > Subject: Re: [PATCH v4] arm64: Add workaround for Fujitsu A64FX erratum > 010001 > > Hi Zhang, > > On 23/02/2019 13:06, Zhang, Lei wrote: > > Zhang, Lei wrote: > >> I think you mean it may be a problem to modify the KPTI trampoline > >> because some patches about KPTI will be merged to mainline in the near > future. > >> I understood that. > >> I should discuss with my colleagues whether we can set NFDx=0 all of > >> time on A64FX. > > > > The result of our investigation also supports your suggestion. > > We surely agree with you that your proposed method (never set NFDx=1 > > on A64FX) is the best to resolve this erratum. > > > > For this erratum, James's patch should be merged to mainline instead > > of my previous patches (v1 to v4). > > Since KPTI fully covers the effect of NFD1 for A64FX, KPTI is > > recommended to be used in conjunction with James’s patch. > > >> And thanks for your patch. > >> If we can set NFDx=0 all of time, I will review, test and report the result. > > > > I have already tested James's patch on A64FX, and the result is no problem at > all. > > > > Tested-by:zhang.lei > > Thanks, I'll post it properly with this tag. [>] I saw v5 patch you posted. Thanks a lot. > > > >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index > >> a4168d366127..b0b7f1c4e816 100644 > >> --- a/arch/arm64/Kconfig > >> +++ b/arch/arm64/Kconfig > >> @@ -643,6 +643,25 @@ config QCOM_FALKOR_ERRATUM_E1041 > >> > >> If unsure, say Y. > >> > >> +config FUJITSU_ERRATUM_010001 > >> + bool "Fujitsu-A64FX erratum E#010001: Undefined fault may occur > wrongly" > >> + default y > >> + help > >> + This option adds workaround for Fujitsu-A64FX erratum E#010001. > >> + On some variants of the Fujitsu-A64FX cores version (1.0, 1.1), > memory > >> + accesses may cause undefined fault (Data abort, DFSC=0b111111). > >> + This fault occurs under a specific hardware condition when a > >> + load/store instruction performs an address translation using: > >> + case-1 TTBR0_EL1 with TCR_EL1.NFD0 == 1. > >> + case-2 TTBR0_EL2 with TCR_EL2.NFD0 == 1. > >> + case-3 TTBR1_EL1 with TCR_EL1.NFD1 == 1. > >> + case-4 TTBR1_EL2 with TCR_EL2.NFD1 == 1. > >> + > >> + The workaround is to ensure these bits are clear in TCR_ELx. > >> + The workaround only affect the Fujitsu-A64FX. > > > > I think it is better to add a notice here as follows: > > > > Recommend to enable KPTI (UNMAP_KERNEL_AT_EL0 = y). > > That unmap option is on by default, you can't turn it off without > CONFIG_EXPERT. While I agree, I don't think we need to spell this out. [>] I agree with you (that there is no need to mention here). Thank you for your suggestion. Best Regards, Zhang Lei