From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA07C433DF for ; Thu, 20 Aug 2020 03:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A31D2078B for ; Thu, 20 Aug 2020 03:09:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="N2ufH3j0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgHTDJe (ORCPT ); Wed, 19 Aug 2020 23:09:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHTDJd (ORCPT ); Wed, 19 Aug 2020 23:09:33 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E74C061757; Wed, 19 Aug 2020 20:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=H+SyqcNb49+mDUM1prCpCzJfpwLQzblN5HpcsZjj2rI=; b=N2ufH3j0O9x7ZeuJWkXPfzRVAd F3ljpyVSfWVlUh+bQ1M1TDKhIncYmALW2YNyS6C4yUYb5IxMzYuwO5xUUMVauvZpxWizmgpGrZ/et vdxl6NARI0L8y6WNO/JEG9FCAREUtgbfQcrc8QZWJ4tLcdMHj//nV8e31vVgkskRGwCDyfrPjWWTH uSEVlS7aEaq0+6BOB8j5vOfM0Yf0vvw2AT1L2KKqUt+Q2KSLFOUePcj0JfCKSwgJ/zBaRtwNc+co8 4EBNj04Uhey+Zld8GtuVkTfGG0nVxfOpY/6CQy4UW+HxaQ+yIonuiVXaHJNaqssvv/ojjQXnA+Ogv zceMaRIQ==; Received: from [2601:1c0:6280:3f0::19c2] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ax0-0003mZ-Lb; Thu, 20 Aug 2020 03:09:15 +0000 Subject: Re: [PATCH] x86/pci: fix xen.c build error when CONFIG_ACPI is not set From: Randy Dunlap To: LKML , linux-pci , Andy Shevchenko , Bjorn Helgaas Cc: Konrad Rzeszutek Wilk , xen-devel References: Message-ID: <88afdd4a-1b30-d836-05ce-8919b834579b@infradead.org> Date: Wed, 19 Aug 2020 20:09:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Konrad, ping. I am still seeing this build error. It looks like this is in your territory to merge... On 8/13/20 4:00 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_ACPI is not set/enabled: > > ../arch/x86/pci/xen.c: In function ‘pci_xen_init’: > ../arch/x86/pci/xen.c:410:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration] > acpi_noirq_set(); > > Fixes: 88e9ca161c13 ("xen/pci: Use acpi_noirq_set() helper to avoid #ifdef") > Signed-off-by: Randy Dunlap > Cc: Andy Shevchenko > Cc: Bjorn Helgaas > Cc: Konrad Rzeszutek Wilk > Cc: xen-devel@lists.xenproject.org > Cc: linux-pci@vger.kernel.org > --- > arch/x86/pci/xen.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200813.orig/arch/x86/pci/xen.c > +++ linux-next-20200813/arch/x86/pci/xen.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > > static int xen_pcifront_enable_irq(struct pci_dev *dev) > thanks. -- ~Randy