* [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys
@ 2020-12-24 6:08 Henry Chen
2020-12-24 6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
` (10 more replies)
0 siblings, 11 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
This series is based on v5.10-rc1.
The patchsets add support for MediaTek hardware module named DVFSRC
(dynamic voltage and frequency scaling resource collector). The DVFSRC is
a HW module which is used to collect all the requests from both software
and hardware and turn into the decision of minimum operating voltage and
minimum DRAM frequency to fulfill those requests.
So, This series is to implement the dvfsrc driver to collect all the
requests of operating voltage or DRAM bandwidth from other device drivers
likes GPU/Camera through 3 frameworks basically:
1. interconnect framework: to aggregate the bandwidth
requirements from different clients
[1] https://patchwork.kernel.org/cover/10766329/
There has a hw module "DRAM scheduler", which used to control the throughput.
The DVFSRC will collect forecast data of dram bandwidth from
SW consumers(camera/gpu...), and according the forecast to change the DRAM
frequency
2. Regualtor framework: to handle the operating voltage requirement from user or
cosumer which not belong any power domain
Changes in V6:
* Remove the performace state support, because the request from consumer can be
replaced by using interconnect and regulator framework.
* Update the DT patches and convert them to DT schema. (Georgi)
* Modify the comment format and coding style. (Mark)
Changes in V5:
* Support more platform mt6873/mt8192
* Drop the compatible and interconnect provider node and make the parent node an
interconnect provider. (Rob/Georgi)
* Make modification of interconnect driver from coding suggestion. (Georgi)
* Move interconnect diagram into the commit text of patch. (Georgi)
* Register the interconnect provider as a platform sub-device. (Georgi)
Changes in V4:
* Add acked TAG on dt-bindings patches. (Rob)
* Declaration of emi_icc_aggregate since the prototype of aggregate function
has changed meanwhile. (Georgi)
* Used emi_icc_remove instead of icc_provider_del on probe. (Georgi)
* Add dvfsrc regulator driver into series.
* Bug fixed of mt8183_get_current_level.
* Add mutex protection for pstate operation on dvfsrc_set_performance.
Changes in V3:
* Remove RFC from the subject prefix of the series
* Combine dt-binding patch and move interconnect dt-binding document into
dvfsrc. (Rob)
* Remove unused header, add unit descirption to the bandwidth, rename compatible
name on interconnect driver. (Georgi)
* Fixed some coding style: check flow, naming, used readx_poll_timeout
on dvfsrc driver. (Ryan)
* Rename interconnect driver mt8183.c to mtk-emi.c
* Rename interconnect header mtk,mt8183.h to mtk,emi.h
* mtk-scpsys.c: Add opp table check first to avoid OF runtime parse failed
Changes in RFC V2:
* Remove the DT property dram_type. (Rob)
* Used generic dts property 'opp-level' to get the performace state. (Stephen)
* Remove unecessary dependency config on Kconfig. (Stephen)
* Remove unused header file, fixed some coding style issue, typo,
error handling on dvfsrc driver. (Nicolas/Stephen)
* Remove irq handler on dvfsrc driver. (Stephen)
* Remove init table on dvfsrc driver, combine hw init on trustzone.
* Add interconnect support of mt8183 to aggregate the emi bandwidth.
(Georgi)
V5: https://patchwork.kernel.org/project/linux-mediatek/list/?series=348065
V4: https://lore.kernel.org/patchwork/cover/1209284/
V3: https://patchwork.kernel.org/cover/11118867/
RFC V2: https://lore.kernel.org/patchwork/patch/1068113/
RFC V1: https://lore.kernel.org/patchwork/cover/1028535/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 17:01 ` Rob Herring
2020-12-24 6:08 ` [PATCH V6 02/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
` (9 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Document the binding for enabling dvfsrc on MediaTek SoC.
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
.../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 68 ++++++++++++++++++++++
1 file changed, 68 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
new file mode 100644
index 0000000..60e0b7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/mediatek/dvfsrc.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MediaTek dynamic voltage and frequency scaling resource collector (DVFSRC)
+
+description: |
+ The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a
+ HW module which is used to collect all the requests from both software and
+ hardware and turn into the decision of minimum operating voltage and minimum
+ DRAM frequency to fulfill those requests.
+
+maintainers:
+ - henryc.chen <henryc.chen@mediatek.com>
+
+properties:
+ reg:
+ description: DVFSRC common register address and length.
+
+ compatible:
+ enum:
+ - mediatek,mt6873-dvfsrc
+ - mediatek,mt8183-dvfsrc
+ - mediatek,mt8192-dvfsrc
+
+ '#interconnect-cells':
+ const: 1
+
+patternProperties:
+ dvfsrc-vcore:
+ type: object
+ description:
+ The DVFSRC regulator is modelled as a subdevice of the DVFSRC.
+ Because DVFSRC can request power directly via register read/write, likes
+ vcore which is a core power of mt8183. As such, the DVFSRC regulator
+ requires that DVFSRC nodes be present.
+ $ref: /schemas/regulator/regulator.yaml#
+
+required:
+ - compatible
+ - reg
+ - "#interconnect-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/soc/mtk,dvfsrc.h>
+ #include <dt-bindings/interconnect/mtk,mt8183-emi.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ dvfsrc@10012000 {
+ compatible = "mediatek,mt8183-dvfsrc";
+ reg = <0 0x10012000 0 0x1000>;
+ #interconnect-cells = <1>;
+ dvfsrc_vcore: dvfsrc-vcore {
+ regulator-name = "dvfsrc-vcore";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <800000>;
+ regulator-always-on;
+ };
+ };
+ };
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 02/13] soc: mediatek: add header for mediatek SIP interface
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-12-24 6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
` (8 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
From: Arvin Wang <arvin.wang@mediatek.com>
Add a header to collect SIPs and add one SIP call to initialize power
management hardware for the SIP interface defined to access the SPM
handling vcore voltage and ddr rate changes on mt8183 (and most likely
later socs).
Signed-off-by: Arvin Wang <arvin.wang@mediatek.com>
---
include/linux/soc/mediatek/mtk_sip_svc.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h
index 082398e..079bbcb 100644
--- a/include/linux/soc/mediatek/mtk_sip_svc.h
+++ b/include/linux/soc/mediatek/mtk_sip_svc.h
@@ -22,4 +22,8 @@
ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, MTK_SIP_SMC_CONVENTION, \
ARM_SMCCC_OWNER_SIP, fn_id)
+/* VCOREFS */
+#define MTK_SIP_VCOREFS_CONTROL \
+ MTK_SIP_SMC_CMD(0x506)
+
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-12-24 6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2020-12-24 6:08 ` [PATCH V6 02/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 14:33 ` Chun-Kuang Hu
2020-12-24 6:08 ` [PATCH V6 04/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
` (7 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Add dvfsrc driver for MT6873/MT8183/MT8192
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
drivers/soc/mediatek/Kconfig | 12 +
drivers/soc/mediatek/Makefile | 1 +
drivers/soc/mediatek/mtk-dvfsrc.c | 538 ++++++++++++++++++++++++++++++++
include/linux/soc/mediatek/mtk_dvfsrc.h | 35 +++
4 files changed, 586 insertions(+)
create mode 100644 drivers/soc/mediatek/mtk-dvfsrc.c
create mode 100644 include/linux/soc/mediatek/mtk_dvfsrc.h
diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
index 59a56cd..0150a6b 100644
--- a/drivers/soc/mediatek/Kconfig
+++ b/drivers/soc/mediatek/Kconfig
@@ -17,6 +17,18 @@ config MTK_CMDQ
time limitation, such as updating display configuration during the
vblank.
+config MTK_DVFSRC
+ tristate "MediaTek DVFSRC Support"
+ depends on ARCH_MEDIATEK
+ depends on MTK_SCPSYS
+ help
+ Say yes here to add support for the MediaTek DVFSRC (dynamic voltage
+ and frequency scaling resource collector) found
+ on different MediaTek SoCs. The DVFSRC is a proprietary
+ hardware which is used to collect all the requests from
+ system and turn into the decision of minimum Vcore voltage
+ and minimum DRAM frequency to fulfill those requests.
+
config MTK_INFRACFG
bool "MediaTek INFRACFG Support"
select REGMAP
diff --git a/drivers/soc/mediatek/Makefile b/drivers/soc/mediatek/Makefile
index 01f9f87..d55b473 100644
--- a/drivers/soc/mediatek/Makefile
+++ b/drivers/soc/mediatek/Makefile
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-$(CONFIG_MTK_CMDQ) += mtk-cmdq-helper.o
+obj-$(CONFIG_MTK_DVFSRC) += mtk-dvfsrc.o
obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o
obj-$(CONFIG_MTK_PMIC_WRAP) += mtk-pmic-wrap.o
obj-$(CONFIG_MTK_SCPSYS) += mtk-scpsys.o
diff --git a/drivers/soc/mediatek/mtk-dvfsrc.c b/drivers/soc/mediatek/mtk-dvfsrc.c
new file mode 100644
index 0000000..536ced7
--- /dev/null
+++ b/drivers/soc/mediatek/mtk-dvfsrc.c
@@ -0,0 +1,538 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2020 MediaTek Inc.
+ */
+
+#include <linux/arm-smccc.h>
+#include <linux/io.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/soc/mediatek/mtk_dvfsrc.h>
+#include <linux/soc/mediatek/mtk_sip_svc.h>
+
+#define DVFSRC_IDLE 0x00
+#define DVFSRC_GET_TARGET_LEVEL(x) (((x) >> 0) & 0x0000ffff)
+#define DVFSRC_GET_CURRENT_LEVEL(x) (((x) >> 16) & 0x0000ffff)
+#define kbps_to_mbps(x) ((x) / 1000)
+
+#define POLL_TIMEOUT 1000
+#define STARTUP_TIME 1
+
+#define MTK_SIP_DVFSRC_INIT 0x00
+
+#define DVFSRC_OPP_DESC(_opp_table) \
+{ \
+ .opps = _opp_table, \
+ .num_opp = ARRAY_SIZE(_opp_table), \
+}
+
+struct dvfsrc_opp {
+ u32 vcore_opp;
+ u32 dram_opp;
+};
+
+struct dvfsrc_opp_desc {
+ const struct dvfsrc_opp *opps;
+ u32 num_opp;
+};
+
+struct mtk_dvfsrc;
+struct dvfsrc_soc_data {
+ const int *regs;
+ const struct dvfsrc_opp_desc *opps_desc;
+ int (*get_target_level)(struct mtk_dvfsrc *dvfsrc);
+ int (*get_current_level)(struct mtk_dvfsrc *dvfsrc);
+ u32 (*get_vcore_level)(struct mtk_dvfsrc *dvfsrc);
+ u32 (*get_vcp_level)(struct mtk_dvfsrc *dvfsrc);
+ void (*set_dram_bw)(struct mtk_dvfsrc *dvfsrc, u64 bw);
+ void (*set_dram_peak_bw)(struct mtk_dvfsrc *dvfsrc, u64 bw);
+ void (*set_dram_hrtbw)(struct mtk_dvfsrc *dvfsrc, u64 bw);
+ void (*set_opp_level)(struct mtk_dvfsrc *dvfsrc, u32 level);
+ void (*set_vcore_level)(struct mtk_dvfsrc *dvfsrc, u32 level);
+ void (*set_vscp_level)(struct mtk_dvfsrc *dvfsrc, u32 level);
+ int (*wait_for_opp_level)(struct mtk_dvfsrc *dvfsrc, u32 level);
+ int (*wait_for_vcore_level)(struct mtk_dvfsrc *dvfsrc, u32 level);
+};
+
+struct mtk_dvfsrc {
+ struct device *dev;
+ struct platform_device *icc;
+ struct platform_device *regulator;
+ const struct dvfsrc_soc_data *dvd;
+ int dram_type;
+ const struct dvfsrc_opp_desc *curr_opps;
+ void __iomem *regs;
+ spinlock_t req_lock;
+ struct mutex pstate_lock;
+ struct notifier_block scpsys_notifier;
+};
+
+static u32 dvfsrc_read(struct mtk_dvfsrc *dvfs, u32 offset)
+{
+ return readl(dvfs->regs + dvfs->dvd->regs[offset]);
+}
+
+static void dvfsrc_write(struct mtk_dvfsrc *dvfs, u32 offset, u32 val)
+{
+ writel(val, dvfs->regs + dvfs->dvd->regs[offset]);
+}
+
+#define dvfsrc_rmw(dvfs, offset, val, mask, shift) \
+ dvfsrc_write(dvfs, offset, \
+ (dvfsrc_read(dvfs, offset) & ~(mask << shift)) | (val << shift))
+
+enum dvfsrc_regs {
+ DVFSRC_SW_REQ,
+ DVFSRC_SW_REQ2,
+ DVFSRC_LEVEL,
+ DVFSRC_TARGET_LEVEL,
+ DVFSRC_SW_BW,
+ DVFSRC_SW_PEAK_BW,
+ DVFSRC_SW_HRT_BW,
+ DVFSRC_VCORE_REQUEST,
+};
+
+static const int mt8183_regs[] = {
+ [DVFSRC_SW_REQ] = 0x4,
+ [DVFSRC_SW_REQ2] = 0x8,
+ [DVFSRC_LEVEL] = 0xDC,
+ [DVFSRC_SW_BW] = 0x160,
+};
+
+static const int mt6873_regs[] = {
+ [DVFSRC_SW_REQ] = 0xC,
+ [DVFSRC_LEVEL] = 0xD44,
+ [DVFSRC_SW_PEAK_BW] = 0x278,
+ [DVFSRC_SW_BW] = 0x26C,
+ [DVFSRC_SW_HRT_BW] = 0x290,
+ [DVFSRC_TARGET_LEVEL] = 0xD48,
+ [DVFSRC_VCORE_REQUEST] = 0x6C,
+};
+
+static const struct dvfsrc_opp *get_current_opp(struct mtk_dvfsrc *dvfsrc)
+{
+ int level;
+
+ level = dvfsrc->dvd->get_current_level(dvfsrc);
+ return &dvfsrc->curr_opps->opps[level];
+}
+
+static int dvfsrc_is_idle(struct mtk_dvfsrc *dvfsrc)
+{
+ if (!dvfsrc->dvd->get_target_level)
+ return true;
+
+ return dvfsrc->dvd->get_target_level(dvfsrc);
+}
+
+static int dvfsrc_wait_for_vcore_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ const struct dvfsrc_opp *curr;
+
+ return readx_poll_timeout_atomic(get_current_opp, dvfsrc, curr,
+ curr->vcore_opp >= level, STARTUP_TIME,
+ POLL_TIMEOUT);
+}
+
+static int mt6873_get_target_level(struct mtk_dvfsrc *dvfsrc)
+{
+ return dvfsrc_read(dvfsrc, DVFSRC_TARGET_LEVEL);
+}
+
+static int mt6873_get_current_level(struct mtk_dvfsrc *dvfsrc)
+{
+ u32 curr_level;
+
+ /* HW level 0 is begin from 0x1, and max opp is 0x1*/
+ curr_level = ffs(dvfsrc_read(dvfsrc, DVFSRC_LEVEL));
+ if (curr_level > dvfsrc->curr_opps->num_opp)
+ curr_level = 0;
+ else
+ curr_level = dvfsrc->curr_opps->num_opp - curr_level;
+
+ return curr_level;
+}
+
+static int mt6873_wait_for_opp_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ const struct dvfsrc_opp *target, *curr;
+
+ target = &dvfsrc->curr_opps->opps[level];
+ return readx_poll_timeout_atomic(get_current_opp, dvfsrc, curr,
+ curr->dram_opp >= target->dram_opp,
+ STARTUP_TIME, POLL_TIMEOUT);
+}
+
+static u32 mt6873_get_vcore_level(struct mtk_dvfsrc *dvfsrc)
+{
+ return (dvfsrc_read(dvfsrc, DVFSRC_SW_REQ) >> 4) & 0x7;
+}
+
+static u32 mt6873_get_vcp_level(struct mtk_dvfsrc *dvfsrc)
+{
+ return (dvfsrc_read(dvfsrc, DVFSRC_VCORE_REQUEST) >> 12) & 0x7;
+}
+
+static void mt6873_set_dram_bw(struct mtk_dvfsrc *dvfsrc, u64 bw)
+{
+ bw = div_u64(kbps_to_mbps(bw), 100);
+ bw = min_t(u64, bw, 0xFF);
+ dvfsrc_write(dvfsrc, DVFSRC_SW_BW, bw);
+}
+
+static void mt6873_set_dram_peak_bw(struct mtk_dvfsrc *dvfsrc, u64 bw)
+{
+ bw = div_u64(kbps_to_mbps(bw), 100);
+ bw = min_t(u64, bw, 0xFF);
+ dvfsrc_write(dvfsrc, DVFSRC_SW_PEAK_BW, bw);
+}
+
+static void mt6873_set_dram_hrtbw(struct mtk_dvfsrc *dvfsrc, u64 bw)
+{
+ bw = div_u64((kbps_to_mbps(bw) + 29), 30);
+ bw = min_t(u64, bw, 0x3FF);
+ dvfsrc_write(dvfsrc, DVFSRC_SW_HRT_BW, bw);
+}
+
+static void mt6873_set_vcore_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ spin_lock(&dvfsrc->req_lock);
+ dvfsrc_rmw(dvfsrc, DVFSRC_SW_REQ, level, 0x7, 4);
+ spin_unlock(&dvfsrc->req_lock);
+}
+
+static void mt6873_set_vscp_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ dvfsrc_rmw(dvfsrc, DVFSRC_VCORE_REQUEST, level, 0x7, 12);
+}
+
+static int mt8183_wait_for_opp_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ const struct dvfsrc_opp *target, *curr;
+ int ret;
+
+ target = &dvfsrc->curr_opps->opps[level];
+ ret = readx_poll_timeout(get_current_opp, dvfsrc, curr,
+ curr->dram_opp >= target->dram_opp &&
+ curr->vcore_opp >= target->vcore_opp,
+ STARTUP_TIME, POLL_TIMEOUT);
+ if (ret < 0) {
+ dev_warn(dvfsrc->dev,
+ "timeout, target: %u, dram: %d, vcore: %d\n", level,
+ curr->dram_opp, curr->vcore_opp);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int mt8183_get_target_level(struct mtk_dvfsrc *dvfsrc)
+{
+ return DVFSRC_GET_TARGET_LEVEL(dvfsrc_read(dvfsrc, DVFSRC_LEVEL));
+}
+
+static int mt8183_get_current_level(struct mtk_dvfsrc *dvfsrc)
+{
+ int level;
+
+ /* HW level 0 is begin from 0x10000 */
+ level = DVFSRC_GET_CURRENT_LEVEL(dvfsrc_read(dvfsrc, DVFSRC_LEVEL));
+ /* Array index start from 0 */
+ return ffs(level) - 1;
+}
+
+static u32 mt8183_get_vcore_level(struct mtk_dvfsrc *dvfsrc)
+{
+ return (dvfsrc_read(dvfsrc, DVFSRC_SW_REQ2) >> 2) & 0x3;
+}
+
+static void mt8183_set_dram_bw(struct mtk_dvfsrc *dvfsrc, u64 bw)
+{
+ dvfsrc_write(dvfsrc, DVFSRC_SW_BW, div_u64(kbps_to_mbps(bw), 100));
+}
+
+static void mt8183_set_opp_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ int vcore_opp, dram_opp;
+ const struct dvfsrc_opp *opp;
+
+ /* translate pstate to dvfsrc level, and set it to DVFSRC HW */
+ opp = &dvfsrc->curr_opps->opps[level];
+ vcore_opp = opp->vcore_opp;
+ dram_opp = opp->dram_opp;
+
+ dev_dbg(dvfsrc->dev, "vcore_opp: %d, dram_opp: %d\n",
+ vcore_opp, dram_opp);
+ dvfsrc_write(dvfsrc, DVFSRC_SW_REQ, dram_opp | vcore_opp << 2);
+}
+
+static void mt8183_set_vcore_level(struct mtk_dvfsrc *dvfsrc, u32 level)
+{
+ dvfsrc_write(dvfsrc, DVFSRC_SW_REQ2, level << 2);
+}
+
+void mtk_dvfsrc_send_request(const struct device *dev, u32 cmd, u64 data)
+{
+ int ret, state;
+ struct mtk_dvfsrc *dvfsrc = dev_get_drvdata(dev);
+
+ dev_dbg(dvfsrc->dev, "cmd: %d, data: %llu\n", cmd, data);
+
+ switch (cmd) {
+ case MTK_DVFSRC_CMD_BW_REQUEST:
+ dvfsrc->dvd->set_dram_bw(dvfsrc, data);
+ return;
+ case MTK_DVFSRC_CMD_PEAK_BW_REQUEST:
+ if (dvfsrc->dvd->set_dram_peak_bw)
+ dvfsrc->dvd->set_dram_peak_bw(dvfsrc, data);
+ return;
+ case MTK_DVFSRC_CMD_OPP_REQUEST:
+ if (dvfsrc->dvd->set_opp_level)
+ dvfsrc->dvd->set_opp_level(dvfsrc, data);
+ break;
+ case MTK_DVFSRC_CMD_VCORE_REQUEST:
+ dvfsrc->dvd->set_vcore_level(dvfsrc, data);
+ break;
+ case MTK_DVFSRC_CMD_HRTBW_REQUEST:
+ if (dvfsrc->dvd->set_dram_hrtbw)
+ dvfsrc->dvd->set_dram_hrtbw(dvfsrc, data);
+ else
+ return;
+ break;
+ case MTK_DVFSRC_CMD_VSCP_REQUEST:
+ dvfsrc->dvd->set_vscp_level(dvfsrc, data);
+ break;
+ default:
+ dev_err(dvfsrc->dev, "unknown command: %d\n", cmd);
+ return;
+ }
+
+ /* DVFSRC need to wait at least 2T(~196ns) to handle request
+ * after recieving command
+ */
+ udelay(STARTUP_TIME);
+
+ ret = readx_poll_timeout(dvfsrc_is_idle, dvfsrc,
+ state, state == DVFSRC_IDLE,
+ STARTUP_TIME, POLL_TIMEOUT);
+
+ if (ret < 0) {
+ dev_warn(dvfsrc->dev,
+ "%d: idle timeout, data: %llu, last: %d -> %d\n",
+ cmd, data,
+ dvfsrc->dvd->get_current_level(dvfsrc),
+ dvfsrc->dvd->get_target_level(dvfsrc));
+ return;
+ }
+
+ /* The previous change may be requested by previous request.
+ * So we delay 1us, then start checking opp is reached enough.
+ */
+ udelay(STARTUP_TIME);
+
+ if (cmd == MTK_DVFSRC_CMD_OPP_REQUEST)
+ ret = dvfsrc->dvd->wait_for_opp_level(dvfsrc, data);
+ else
+ ret = dvfsrc->dvd->wait_for_vcore_level(dvfsrc, data);
+
+ if (ret < 0) {
+ dev_warn(dvfsrc->dev,
+ "%d: wait timeout, data: %llu, last: %d -> %d\n",
+ cmd, data,
+ dvfsrc->dvd->get_current_level(dvfsrc),
+ dvfsrc->dvd->get_target_level(dvfsrc));
+ }
+
+}
+EXPORT_SYMBOL(mtk_dvfsrc_send_request);
+
+int mtk_dvfsrc_query_info(const struct device *dev, u32 cmd, int *data)
+{
+ struct mtk_dvfsrc *dvfsrc = dev_get_drvdata(dev);
+
+ switch (cmd) {
+ case MTK_DVFSRC_CMD_VCORE_LEVEL_QUERY:
+ *data = dvfsrc->dvd->get_vcore_level(dvfsrc);
+ break;
+ case MTK_DVFSRC_CMD_VSCP_LEVEL_QUERY:
+ *data = dvfsrc->dvd->get_vcp_level(dvfsrc);
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL(mtk_dvfsrc_query_info);
+
+static int mtk_dvfsrc_probe(struct platform_device *pdev)
+{
+ struct arm_smccc_res ares;
+ struct resource *res;
+ struct mtk_dvfsrc *dvfsrc;
+ int ret;
+
+ dvfsrc = devm_kzalloc(&pdev->dev, sizeof(*dvfsrc), GFP_KERNEL);
+ if (!dvfsrc)
+ return -ENOMEM;
+
+ dvfsrc->dvd = of_device_get_match_data(&pdev->dev);
+ dvfsrc->dev = &pdev->dev;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ dvfsrc->regs = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(dvfsrc->regs))
+ return PTR_ERR(dvfsrc->regs);
+
+ spin_lock_init(&dvfsrc->req_lock);
+ mutex_init(&dvfsrc->pstate_lock);
+
+ arm_smccc_smc(MTK_SIP_VCOREFS_CONTROL, MTK_SIP_DVFSRC_INIT, 0, 0, 0,
+ 0, 0, 0, &ares);
+
+ if (!ares.a0) {
+ dvfsrc->dram_type = ares.a1;
+ dev_info(dvfsrc->dev, "dram_type: %d\n", dvfsrc->dram_type);
+ } else {
+ dev_err(dvfsrc->dev, "init fails: %lu\n", ares.a0);
+ return ares.a0;
+ }
+
+ dvfsrc->curr_opps = &dvfsrc->dvd->opps_desc[dvfsrc->dram_type];
+ platform_set_drvdata(pdev, dvfsrc);
+
+ dvfsrc->regulator = platform_device_register_data(dvfsrc->dev,
+ "mtk-dvfsrc-regulator", -1, NULL, 0);
+ if (IS_ERR(dvfsrc->regulator)) {
+ dev_err(dvfsrc->dev, "Failed create regulator device\n");
+ ret = PTR_ERR(dvfsrc->regulator);
+ goto err;
+ }
+
+ dvfsrc->icc = platform_device_register_data(dvfsrc->dev,
+ "mediatek-emi-icc", -1, NULL, 0);
+ if (IS_ERR(dvfsrc->icc)) {
+ dev_err(dvfsrc->dev, "Failed create icc device\n");
+ ret = PTR_ERR(dvfsrc->icc);
+ goto unregister_regulator;
+ }
+
+ ret = devm_of_platform_populate(&pdev->dev);
+ if (ret)
+ platform_device_unregister(dvfsrc->icc);
+
+ return 0;
+
+unregister_regulator:
+ platform_device_unregister(dvfsrc->regulator);
+err:
+ return ret;
+}
+
+static const struct dvfsrc_opp dvfsrc_opp_mt8183_lp4[] = {
+ {0, 0}, {0, 1}, {0, 2}, {1, 2},
+};
+
+static const struct dvfsrc_opp dvfsrc_opp_mt8183_lp3[] = {
+ {0, 0}, {0, 1}, {1, 1}, {1, 2},
+};
+
+static const struct dvfsrc_opp_desc dvfsrc_opp_mt8183_desc[] = {
+ DVFSRC_OPP_DESC(dvfsrc_opp_mt8183_lp4),
+ DVFSRC_OPP_DESC(dvfsrc_opp_mt8183_lp3),
+ DVFSRC_OPP_DESC(dvfsrc_opp_mt8183_lp3),
+};
+
+static const struct dvfsrc_soc_data mt8183_data = {
+ .opps_desc = dvfsrc_opp_mt8183_desc,
+ .regs = mt8183_regs,
+ .get_target_level = mt8183_get_target_level,
+ .get_current_level = mt8183_get_current_level,
+ .get_vcore_level = mt8183_get_vcore_level,
+ .set_dram_bw = mt8183_set_dram_bw,
+ .set_opp_level = mt8183_set_opp_level,
+ .set_vcore_level = mt8183_set_vcore_level,
+ .wait_for_opp_level = mt8183_wait_for_opp_level,
+ .wait_for_vcore_level = dvfsrc_wait_for_vcore_level,
+};
+
+static const struct dvfsrc_opp dvfsrc_opp_mt6873_lp4[] = {
+ {0, 0}, {1, 0}, {2, 0}, {3, 0},
+ {0, 1}, {1, 1}, {2, 1}, {3, 1},
+ {0, 2}, {1, 2}, {2, 2}, {3, 2},
+ {1, 3}, {2, 3}, {3, 3}, {1, 4},
+ {2, 4}, {3, 4}, {2, 5}, {3, 5},
+ {3, 6},
+};
+
+static const struct dvfsrc_opp_desc dvfsrc_opp_mt6873_desc[] = {
+ DVFSRC_OPP_DESC(dvfsrc_opp_mt6873_lp4),
+};
+
+static const struct dvfsrc_soc_data mt6873_data = {
+ .opps_desc = dvfsrc_opp_mt6873_desc,
+ .regs = mt6873_regs,
+ .get_target_level = mt6873_get_target_level,
+ .get_current_level = mt6873_get_current_level,
+ .get_vcore_level = mt6873_get_vcore_level,
+ .get_vcp_level = mt6873_get_vcp_level,
+ .set_dram_bw = mt6873_set_dram_bw,
+ .set_dram_peak_bw = mt6873_set_dram_peak_bw,
+ .set_dram_hrtbw = mt6873_set_dram_hrtbw,
+ .set_vcore_level = mt6873_set_vcore_level,
+ .set_vscp_level = mt6873_set_vscp_level,
+ .wait_for_opp_level = mt6873_wait_for_opp_level,
+ .wait_for_vcore_level = dvfsrc_wait_for_vcore_level,
+};
+
+static int mtk_dvfsrc_remove(struct platform_device *pdev)
+{
+ struct mtk_dvfsrc *dvfsrc = platform_get_drvdata(pdev);
+
+ platform_device_unregister(dvfsrc->regulator);
+ platform_device_unregister(dvfsrc->icc);
+
+ return 0;
+}
+
+static const struct of_device_id mtk_dvfsrc_of_match[] = {
+ {
+ .compatible = "mediatek,mt8183-dvfsrc",
+ .data = &mt8183_data,
+ }, {
+ .compatible = "mediatek,mt8192-dvfsrc",
+ .data = &mt6873_data,
+ }, {
+ .compatible = "mediatek,mt6873-dvfsrc",
+ .data = &mt6873_data,
+ }, {
+ /* sentinel */
+ },
+};
+
+static struct platform_driver mtk_dvfsrc_driver = {
+ .probe = mtk_dvfsrc_probe,
+ .remove = mtk_dvfsrc_remove,
+ .driver = {
+ .name = "mtk-dvfsrc",
+ .of_match_table = of_match_ptr(mtk_dvfsrc_of_match),
+ },
+};
+
+static int __init mtk_dvfsrc_init(void)
+{
+ return platform_driver_register(&mtk_dvfsrc_driver);
+}
+subsys_initcall(mtk_dvfsrc_init);
+
+static void __exit mtk_dvfsrc_exit(void)
+{
+ platform_driver_unregister(&mtk_dvfsrc_driver);
+}
+module_exit(mtk_dvfsrc_exit);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("MTK DVFSRC driver");
diff --git a/include/linux/soc/mediatek/mtk_dvfsrc.h b/include/linux/soc/mediatek/mtk_dvfsrc.h
new file mode 100644
index 0000000..0a49f93c
--- /dev/null
+++ b/include/linux/soc/mediatek/mtk_dvfsrc.h
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: GPL-2.0
+ *
+ * Copyright (c) 2020 MediaTek Inc.
+ */
+
+#ifndef __SOC_MTK_DVFSRC_H
+#define __SOC_MTK_DVFSRC_H
+
+#define MTK_DVFSRC_CMD_BW_REQUEST 0
+#define MTK_DVFSRC_CMD_OPP_REQUEST 1
+#define MTK_DVFSRC_CMD_VCORE_REQUEST 2
+#define MTK_DVFSRC_CMD_HRTBW_REQUEST 3
+#define MTK_DVFSRC_CMD_VSCP_REQUEST 4
+#define MTK_DVFSRC_CMD_PEAK_BW_REQUEST 5
+
+#define MTK_DVFSRC_CMD_VCORE_LEVEL_QUERY 0
+#define MTK_DVFSRC_CMD_VSCP_LEVEL_QUERY 1
+
+#if IS_ENABLED(CONFIG_MTK_DVFSRC)
+void mtk_dvfsrc_send_request(const struct device *dev, u32 cmd, u64 data);
+int mtk_dvfsrc_query_info(const struct device *dev, u32 cmd, int *data);
+
+#else
+
+static inline void mtk_dvfsrc_send_request(const struct device *dev, u32 cmd,
+ u64 data)
+{ return -ENODEV; }
+
+static inline int mtk_dvfsrc_query_info(const struct device *dev, u32 cmd,
+ int *data);
+{ return -ENODEV; }
+
+#endif /* CONFIG_MTK_DVFSRC */
+
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 04/13] arm64: dts: mt8183: add dvfsrc related nodes
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (2 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
` (6 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Enable dvfsrc on mt8183 platform.
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 9cfd961..06ef8e0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -328,6 +328,11 @@
#clock-cells = <1>;
};
+ ddr_emi: dvfsrc@10012000 {
+ compatible = "mediatek,mt8183-dvfsrc";
+ reg = <0 0x10012000 0 0x1000>;
+ };
+
pwrap: pwrap@1000d000 {
compatible = "mediatek,mt8183-pwrap";
reg = <0 0x1000d000 0 0x1000>;
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (3 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 04/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2021-01-08 2:53 ` Rob Herring
2020-12-24 6:08 ` [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
` (5 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Add interconnect provider dt-bindings for MT8183.
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
include/dt-bindings/interconnect/mtk,mt8183-emi.h | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 include/dt-bindings/interconnect/mtk,mt8183-emi.h
diff --git a/include/dt-bindings/interconnect/mtk,mt8183-emi.h b/include/dt-bindings/interconnect/mtk,mt8183-emi.h
new file mode 100644
index 0000000..f921961
--- /dev/null
+++ b/include/dt-bindings/interconnect/mtk,mt8183-emi.h
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0
+ *
+ * Copyright (c) 2020 MediaTek Inc.
+ */
+
+#ifndef __DT_BINDINGS_INTERCONNECT_MTK_MT8183_EMI_H
+#define __DT_BINDINGS_INTERCONNECT_MTK_MT8183_EMI_H
+
+#define MT8183_SLAVE_DDR_EMI 0
+#define MT8183_MASTER_MCUSYS 1
+#define MT8183_MASTER_GPU 2
+#define MT8183_MASTER_MMSYS 3
+#define MT8183_MASTER_MM_VPU 4
+#define MT8183_MASTER_MM_DISP 5
+#define MT8183_MASTER_MM_VDEC 6
+#define MT8183_MASTER_MM_VENC 7
+#define MT8183_MASTER_MM_CAM 8
+#define MT8183_MASTER_MM_IMG 9
+#define MT8183_MASTER_MM_MDP 10
+
+#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (4 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2021-01-04 18:36 ` Georgi Djakov
2020-12-24 6:08 ` [PATCH V6 09/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
` (4 subsequent siblings)
10 siblings, 1 reply; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
using the interconnect framework.
ICC provider ICC Nodes
---- ----
--------- |CPU | |--- |VPU |
----- | |----- ---- | ----
|DRAM |--|DRAM | ---- | ----
| |--|scheduler|----- |GPU | |--- |DISP|
| |--|(EMI) | ---- | ----
| |--| | ----- | ----
----- | |----- |MMSYS|--|--- |VDEC|
--------- ----- | ----
/|\ | ----
|change DRAM freq |--- |VENC|
---------- | ----
| DVFSR | |
| | | ----
---------- |--- |IMG |
| ----
| ----
|--- |CAM |
----
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
drivers/interconnect/Kconfig | 1 +
drivers/interconnect/Makefile | 1 +
drivers/interconnect/mediatek/Kconfig | 13 ++
drivers/interconnect/mediatek/Makefile | 3 +
drivers/interconnect/mediatek/mtk-emi.c | 330 ++++++++++++++++++++++++++++++++
5 files changed, 348 insertions(+)
create mode 100644 drivers/interconnect/mediatek/Kconfig
create mode 100644 drivers/interconnect/mediatek/Makefile
create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
index 5b7204e..e939f5a 100644
--- a/drivers/interconnect/Kconfig
+++ b/drivers/interconnect/Kconfig
@@ -13,5 +13,6 @@ if INTERCONNECT
source "drivers/interconnect/imx/Kconfig"
source "drivers/interconnect/qcom/Kconfig"
+source "drivers/interconnect/mediatek/Kconfig"
endif
diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
index d203520..0643a24 100644
--- a/drivers/interconnect/Makefile
+++ b/drivers/interconnect/Makefile
@@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
obj-$(CONFIG_INTERCONNECT) += icc-core.o
obj-$(CONFIG_INTERCONNECT_IMX) += imx/
obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
+obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/
diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig
new file mode 100644
index 0000000..972d3bb
--- /dev/null
+++ b/drivers/interconnect/mediatek/Kconfig
@@ -0,0 +1,13 @@
+config INTERCONNECT_MTK
+ bool "Mediatek Network-on-Chip interconnect drivers"
+ depends on ARCH_MEDIATEK
+ help
+ Support for Mediatek's Network-on-Chip interconnect hardware.
+
+config INTERCONNECT_MTK_EMI
+ tristate "Mediatek EMI interconnect driver"
+ depends on INTERCONNECT_MTK
+ depends on (MTK_DVFSRC && OF)
+ help
+ This is a driver for the Mediatek Network-on-Chip on DVFSRC-based
+ platforms.
diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
new file mode 100644
index 0000000..353842b
--- /dev/null
+++ b/drivers/interconnect/mediatek/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_INTERCONNECT_MTK_EMI) += mtk-emi.o
\ No newline at end of file
diff --git a/drivers/interconnect/mediatek/mtk-emi.c b/drivers/interconnect/mediatek/mtk-emi.c
new file mode 100644
index 0000000..9670077
--- /dev/null
+++ b/drivers/interconnect/mediatek/mtk-emi.c
@@ -0,0 +1,330 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2020, The Linux Foundation. All rights reserved.
+ *
+ */
+
+#include <linux/device.h>
+#include <linux/interconnect-provider.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/soc/mediatek/mtk_dvfsrc.h>
+#include <dt-bindings/interconnect/mtk,mt8183-emi.h>
+#include <dt-bindings/interconnect/mtk,mt6873-emi.h>
+
+enum mtk_icc_name {
+ SLAVE_DDR_EMI,
+ MASTER_MCUSYS,
+ MASTER_GPUSYS,
+ MASTER_MMSYS,
+ MASTER_MM_VPU,
+ MASTER_MM_DISP,
+ MASTER_MM_VDEC,
+ MASTER_MM_VENC,
+ MASTER_MM_CAM,
+ MASTER_MM_IMG,
+ MASTER_MM_MDP,
+ MASTER_VPUSYS,
+ MASTER_VPU_PORT_0,
+ MASTER_VPU_PORT_1,
+ MASTER_MDLASYS,
+ MASTER_MDLA_PORT_0,
+ MASTER_UFS,
+ MASTER_PCIE,
+ MASTER_USB,
+ MASTER_WIFI,
+ MASTER_BT,
+ MASTER_NETSYS,
+ MASTER_DBGIF,
+
+ SLAVE_HRT_DDR_EMI,
+ MASTER_HRT_MMSYS,
+ MASTER_HRT_MM_DISP,
+ MASTER_HRT_MM_VDEC,
+ MASTER_HRT_MM_VENC,
+ MASTER_HRT_MM_CAM,
+ MASTER_HRT_MM_IMG,
+ MASTER_HRT_MM_MDP,
+ MASTER_HRT_DBGIF,
+};
+
+#define MT8183_MAX_LINKS 1
+
+/**
+ * struct mtk_icc_node - Mediatek specific interconnect nodes
+ * @name: the node name used in debugfs
+ * @ep : the type of this endpoint
+ * @id: a unique node identifier
+ * @links: an array of nodes where we can go next while traversing
+ * @num_links: the total number of @links
+ * @sum_avg: current sum aggregate value of all avg bw kBps requests
+ * @max_peak: current max aggregate value of all peak bw kBps requests
+ */
+struct mtk_icc_node {
+ unsigned char *name;
+ int ep;
+ u16 id;
+ u16 links[MT8183_MAX_LINKS];
+ u16 num_links;
+ u64 sum_avg;
+ u64 max_peak;
+};
+
+struct mtk_icc_desc {
+ struct mtk_icc_node **nodes;
+ size_t num_nodes;
+};
+
+#define DEFINE_MNODE(_name, _id, _ep, ...) \
+ static struct mtk_icc_node _name = { \
+ .name = #_name, \
+ .id = _id, \
+ .ep = _ep, \
+ .num_links = ARRAY_SIZE(((int[]){ __VA_ARGS__ })), \
+ .links = { __VA_ARGS__ }, \
+}
+
+DEFINE_MNODE(ddr_emi, SLAVE_DDR_EMI, 1);
+DEFINE_MNODE(mcusys, MASTER_MCUSYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(gpu, MASTER_GPUSYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(mmsys, MASTER_MMSYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(mm_vpu, MASTER_MM_VPU, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_disp, MASTER_MM_DISP, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_vdec, MASTER_MM_VDEC, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_venc, MASTER_MM_VENC, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_cam, MASTER_MM_CAM, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_img, MASTER_MM_IMG, 0, MASTER_MMSYS);
+DEFINE_MNODE(mm_mdp, MASTER_MM_MDP, 0, MASTER_MMSYS);
+DEFINE_MNODE(vpusys, MASTER_VPUSYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(vpu_port_0, MASTER_VPU_PORT_0, 0, MASTER_VPUSYS);
+DEFINE_MNODE(vpu_port_1, MASTER_VPU_PORT_1, 0, MASTER_VPUSYS);
+DEFINE_MNODE(mdlasys, MASTER_MDLASYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(mdla_port_0, MASTER_MDLA_PORT_0, 0, MASTER_MDLASYS);
+DEFINE_MNODE(ufs, MASTER_UFS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(pcie, MASTER_PCIE, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(usb, MASTER_USB, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(wifi, MASTER_WIFI, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(bt, MASTER_BT, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(netsys, MASTER_NETSYS, 0, SLAVE_DDR_EMI);
+DEFINE_MNODE(dbgif, MASTER_DBGIF, 0, SLAVE_DDR_EMI);
+
+DEFINE_MNODE(hrt_ddr_emi, SLAVE_HRT_DDR_EMI, 2);
+DEFINE_MNODE(hrt_mmsys, MASTER_HRT_MMSYS, 0, SLAVE_HRT_DDR_EMI);
+DEFINE_MNODE(hrt_mm_disp, MASTER_HRT_MM_DISP, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_mm_vdec, MASTER_HRT_MM_VDEC, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_mm_venc, MASTER_HRT_MM_VENC, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_mm_cam, MASTER_HRT_MM_CAM, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_mm_img, MASTER_HRT_MM_IMG, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_mm_mdp, MASTER_HRT_MM_MDP, 0, MASTER_HRT_MMSYS);
+DEFINE_MNODE(hrt_dbgif, MASTER_HRT_DBGIF, 0, SLAVE_HRT_DDR_EMI);
+
+static struct mtk_icc_node *mt8183_icc_nodes[] = {
+ [MT8183_SLAVE_DDR_EMI] = &ddr_emi,
+ [MT8183_MASTER_MCUSYS] = &mcusys,
+ [MT8183_MASTER_GPU] = &gpu,
+ [MT8183_MASTER_MMSYS] = &mmsys,
+ [MT8183_MASTER_MM_VPU] = &mm_vpu,
+ [MT8183_MASTER_MM_DISP] = &mm_disp,
+ [MT8183_MASTER_MM_VDEC] = &mm_vdec,
+ [MT8183_MASTER_MM_VENC] = &mm_venc,
+ [MT8183_MASTER_MM_CAM] = &mm_cam,
+ [MT8183_MASTER_MM_IMG] = &mm_img,
+ [MT8183_MASTER_MM_MDP] = &mm_mdp,
+};
+
+static const struct mtk_icc_desc mt8183_icc = {
+ .nodes = mt8183_icc_nodes,
+ .num_nodes = ARRAY_SIZE(mt8183_icc_nodes),
+};
+
+static struct mtk_icc_node *mt6873_icc_nodes[] = {
+ [MT6873_SLAVE_DDR_EMI] = &ddr_emi,
+ [MT6873_MASTER_MCUSYS] = &mcusys,
+ [MT6873_MASTER_GPUSYS] = &gpu,
+ [MT6873_MASTER_MMSYS] = &mmsys,
+ [MT6873_MASTER_MM_VPU] = &mm_vpu,
+ [MT6873_MASTER_MM_DISP] = &mm_disp,
+ [MT6873_MASTER_MM_VDEC] = &mm_vdec,
+ [MT6873_MASTER_MM_VENC] = &mm_venc,
+ [MT6873_MASTER_MM_CAM] = &mm_cam,
+ [MT6873_MASTER_MM_IMG] = &mm_img,
+ [MT6873_MASTER_MM_MDP] = &mm_mdp,
+ [MT6873_MASTER_VPUSYS] = &vpusys,
+ [MT6873_MASTER_VPU_0] = &vpu_port_0,
+ [MT6873_MASTER_VPU_1] = &vpu_port_1,
+ [MT6873_MASTER_MDLASYS] = &mdlasys,
+ [MT6873_MASTER_MDLA_0] = &mdla_port_0,
+ [MT6873_MASTER_UFS] = &ufs,
+ [MT6873_MASTER_PCIE] = &pcie,
+ [MT6873_MASTER_USB] = &usb,
+ [MT6873_MASTER_WIFI] = &wifi,
+ [MT6873_MASTER_BT] = &bt,
+ [MT6873_MASTER_NETSYS] = &netsys,
+ [MT6873_MASTER_DBGIF] = &dbgif,
+
+ [MT6873_SLAVE_HRT_DDR_EMI] = &hrt_ddr_emi,
+ [MT6873_MASTER_HRT_MMSYS] = &hrt_mmsys,
+ [MT6873_MASTER_HRT_MM_DISP] = &hrt_mm_disp,
+ [MT6873_MASTER_HRT_MM_VDEC] = &hrt_mm_vdec,
+ [MT6873_MASTER_HRT_MM_VENC] = &hrt_mm_venc,
+ [MT6873_MASTER_HRT_MM_CAM] = &hrt_mm_cam,
+ [MT6873_MASTER_HRT_MM_IMG] = &hrt_mm_img,
+ [MT6873_MASTER_HRT_MM_MDP] = &hrt_mm_mdp,
+ [MT6873_MASTER_HRT_DBGIF] = &hrt_dbgif,
+};
+
+static struct mtk_icc_desc mt6873_icc = {
+ .nodes = mt6873_icc_nodes,
+ .num_nodes = ARRAY_SIZE(mt6873_icc_nodes),
+};
+
+static const struct of_device_id emi_icc_of_match[] = {
+ { .compatible = "mediatek,mt8183-dvfsrc", .data = &mt8183_icc },
+ { .compatible = "mediatek,mt8192-dvfsrc", .data = &mt6873_icc },
+ { .compatible = "mediatek,mt6873-dvfsrc", .data = &mt6873_icc },
+ { },
+};
+MODULE_DEVICE_TABLE(of, emi_icc_of_match);
+
+static int emi_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
+ u32 peak_bw, u32 *agg_avg, u32 *agg_peak)
+{
+ struct mtk_icc_node *in;
+
+ in = node->data;
+
+ *agg_avg += avg_bw;
+ *agg_peak = max_t(u32, *agg_peak, peak_bw);
+
+ in->sum_avg = *agg_avg;
+ in->max_peak = *agg_peak;
+
+ return 0;
+}
+
+static int emi_icc_set(struct icc_node *src, struct icc_node *dst)
+{
+ int ret = 0;
+ struct mtk_icc_node *node;
+
+ node = dst->data;
+
+ if (node->ep == 1) {
+ mtk_dvfsrc_send_request(src->provider->dev,
+ MTK_DVFSRC_CMD_PEAK_BW_REQUEST,
+ node->max_peak);
+ mtk_dvfsrc_send_request(src->provider->dev,
+ MTK_DVFSRC_CMD_BW_REQUEST,
+ node->sum_avg);
+ } else if (node->ep == 2) {
+ mtk_dvfsrc_send_request(src->provider->dev,
+ MTK_DVFSRC_CMD_HRTBW_REQUEST,
+ node->sum_avg);
+ }
+
+ return ret;
+}
+
+static int emi_icc_remove(struct platform_device *pdev);
+static int emi_icc_probe(struct platform_device *pdev)
+{
+ const struct of_device_id *match;
+ const struct mtk_icc_desc *desc;
+ struct device *dev = &pdev->dev;
+ struct icc_node *node;
+ struct icc_onecell_data *data;
+ struct icc_provider *provider;
+ struct mtk_icc_node **mnodes;
+ size_t num_nodes, i, j;
+ int ret;
+
+ match = of_match_node(emi_icc_of_match, dev->parent->of_node);
+
+ if (!match) {
+ dev_err(dev, "invalid compatible string\n");
+ return -ENODEV;
+ }
+
+ desc = match->data;
+ mnodes = desc->nodes;
+ num_nodes = desc->num_nodes;
+
+ provider = devm_kzalloc(dev, sizeof(*provider), GFP_KERNEL);
+ if (!provider)
+ return -ENOMEM;
+
+ data = devm_kzalloc(dev, struct_size(data, nodes, num_nodes),
+ GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ provider->dev = pdev->dev.parent;
+ provider->set = emi_icc_set;
+ provider->aggregate = emi_icc_aggregate;
+ provider->xlate = of_icc_xlate_onecell;
+ INIT_LIST_HEAD(&provider->nodes);
+ provider->data = data;
+
+ ret = icc_provider_add(provider);
+ if (ret) {
+ dev_err(&pdev->dev, "error adding interconnect provider\n");
+ return ret;
+ }
+
+ for (i = 0; i < num_nodes; i++) {
+ node = icc_node_create(mnodes[i]->id);
+ if (IS_ERR(node)) {
+ ret = PTR_ERR(node);
+ goto err;
+ }
+
+ node->name = mnodes[i]->name;
+ node->data = mnodes[i];
+ icc_node_add(node, provider);
+
+ for (j = 0; j < mnodes[i]->num_links; j++)
+ icc_link_create(node, mnodes[i]->links[j]);
+
+ data->nodes[i] = node;
+ }
+ data->num_nodes = num_nodes;
+
+ platform_set_drvdata(pdev, provider);
+
+ return 0;
+err:
+ icc_nodes_remove(provider);
+ return ret;
+}
+
+static int emi_icc_remove(struct platform_device *pdev)
+{
+ struct icc_provider *provider = platform_get_drvdata(pdev);
+
+ icc_nodes_remove(provider);
+ return icc_provider_del(provider);
+}
+
+static struct platform_driver emi_icc_driver = {
+ .probe = emi_icc_probe,
+ .remove = emi_icc_remove,
+ .driver = {
+ .name = "mediatek-emi-icc",
+ },
+};
+
+static int __init mtk_emi_icc_init(void)
+{
+ return platform_driver_register(&emi_icc_driver);
+}
+subsys_initcall(mtk_emi_icc_init);
+
+static void __exit mtk_emi_icc_exit(void)
+{
+ platform_driver_unregister(&emi_icc_driver);
+}
+module_exit(mtk_emi_icc_exit);
+
+MODULE_AUTHOR("Henry Chen <henryc.chen@mediatek.com>");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 09/13] arm64: dts: mt8183: add dvfsrc related nodes
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (5 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 10/13] arm64: dts: mt8192: " Henry Chen
` (3 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Add DDR EMI provider dictating dram interconnect bus performance found on
MT8183-based platforms
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 06ef8e0..22b3a68 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -11,6 +11,7 @@
#include <dt-bindings/reset-controller/mt8183-resets.h>
#include <dt-bindings/phy/phy.h>
#include "mt8183-pinfunc.h"
+#include <dt-bindings/interconnect/mtk,mt8183-emi.h>
/ {
compatible = "mediatek,mt8183";
@@ -331,6 +332,7 @@
ddr_emi: dvfsrc@10012000 {
compatible = "mediatek,mt8183-dvfsrc";
reg = <0 0x10012000 0 0x1000>;
+ #interconnect-cells = <1>;
};
pwrap: pwrap@1000d000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 10/13] arm64: dts: mt8192: add dvfsrc related nodes
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (6 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 09/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 12/13] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
` (2 subsequent siblings)
10 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Add DDR EMI provider dictating dram interconnect bus performance found on
MT8192-based platforms
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8192.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index 1e5d506..14c521d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -9,6 +9,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/pinctrl/mt8192-pinfunc.h>
+#include <dt-bindings/interconnect/mtk,mt6873-emi.h>
/ {
compatible = "mediatek,mt8192";
@@ -266,6 +267,7 @@
ddr_emi: dvfsrc@10012000 {
compatible = "mediatek,mt8192-dvfsrc";
reg = <0 0x10012000 0 0x1000>;
+ #interconnect-cells = <1>;
};
systimer: timer@10017000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH V6 12/13] arm64: dts: mt8183: add dvfsrc regulator nodes
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (7 preceding siblings ...)
2020-12-24 6:08 ` [PATCH V6 10/13] arm64: dts: mt8192: " Henry Chen
@ 2020-12-24 6:08 ` Henry Chen
[not found] ` <1608790134-27425-8-git-send-email-henryc.chen@mediatek.com>
2021-01-05 16:07 ` (subset) [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Mark Brown
10 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-24 6:08 UTC (permalink / raw)
To: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm, Henry Chen
Add dvfsrc regulator nodes which is for MT8183-based platforms
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 22b3a68..182b851 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -333,6 +333,12 @@
compatible = "mediatek,mt8183-dvfsrc";
reg = <0 0x10012000 0 0x1000>;
#interconnect-cells = <1>;
+ dvfsrc_vcore: dvfsrc-vcore {
+ regulator-name = "dvfsrc-vcore";
+ regulator-min-microvolt = <725000>;
+ regulator-max-microvolt = <800000>;
+ regulator-always-on;
+ };
};
pwrap: pwrap@1000d000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support
2020-12-24 6:08 ` [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
@ 2020-12-24 14:33 ` Chun-Kuang Hu
2020-12-25 5:14 ` Henry Chen
0 siblings, 1 reply; 23+ messages in thread
From: Chun-Kuang Hu @ 2020-12-24 14:33 UTC (permalink / raw)
To: Henry Chen
Cc: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown, Mark Rutland, Nicolas Boichat, DTML,
linux-pm, linux-kernel, Fan Chen,
moderated list:ARM/Mediatek SoC support, Arvin Wang, James Liao,
Linux ARM
Hi, Henry:
Henry Chen <henryc.chen@mediatek.com> 於 2020年12月24日 週四 下午2:09寫道：
>
> Add dvfsrc driver for MT6873/MT8183/MT8192
Separate this patch for each SoC.
Regards,
Chun-Kuang.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 12 +
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-dvfsrc.c | 538 ++++++++++++++++++++++++++++++++
> include/linux/soc/mediatek/mtk_dvfsrc.h | 35 +++
> 4 files changed, 586 insertions(+)
> create mode 100644 drivers/soc/mediatek/mtk-dvfsrc.c
> create mode 100644 include/linux/soc/mediatek/mtk_dvfsrc.h
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings
2020-12-24 6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
@ 2020-12-24 17:01 ` Rob Herring
2020-12-25 5:12 ` Henry Chen
0 siblings, 1 reply; 23+ messages in thread
From: Rob Herring @ 2020-12-24 17:01 UTC (permalink / raw)
To: Henry Chen
Cc: linux-arm-kernel, Mark Brown, Nicolas Boichat, Stephen Boyd,
Fan Chen, Arvin Wang, linux-pm, James Liao, linux-mediatek,
Rob Herring, Matthias Brugger, linux-kernel, devicetree,
Mark Rutland, Georgi Djakov, Ryan Case
On Thu, 24 Dec 2020 14:08:42 +0800, Henry Chen wrote:
> Document the binding for enabling dvfsrc on MediaTek SoC.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 68 ++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/soc/mtk,dvfsrc.h: No such file or directory
19 | #include <dt-bindings/soc/mtk,dvfsrc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dt.yaml] Error 1
make: *** [Makefile:1370: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1420382
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings
2020-12-24 17:01 ` Rob Herring
@ 2020-12-25 5:12 ` Henry Chen
0 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-25 5:12 UTC (permalink / raw)
To: Rob Herring
Cc: linux-arm-kernel, Mark Brown, Nicolas Boichat, Stephen Boyd,
Fan Chen, Arvin Wang, linux-pm, James Liao, linux-mediatek,
Rob Herring, Matthias Brugger, linux-kernel, devicetree,
Mark Rutland, Georgi Djakov, Ryan Case
On Thu, 2020-12-24 at 10:01 -0700, Rob Herring wrote:
> On Thu, 24 Dec 2020 14:08:42 +0800, Henry Chen wrote:
> > Document the binding for enabling dvfsrc on MediaTek SoC.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > .../devicetree/bindings/soc/mediatek/dvfsrc.yaml | 68 ++++++++++++++++++++++
> > 1 file changed, 68 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dts:19:18: fatal error: dt-bindings/soc/mtk,dvfsrc.h: No such file or directory
> 19 | #include <dt-bindings/soc/mtk,dvfsrc.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/soc/mediatek/dvfsrc.example.dt.yaml] Error 1
> make: *** [Makefile:1370: dt_binding_check] Error 2
>
> See https://patchwork.ozlabs.org/patch/1420382
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
Hi Rob,
Sorry for the check error, I will re-check and submit again.
Thanks,
Henry
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support
2020-12-24 14:33 ` Chun-Kuang Hu
@ 2020-12-25 5:14 ` Henry Chen
0 siblings, 0 replies; 23+ messages in thread
From: Henry Chen @ 2020-12-25 5:14 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: Georgi Djakov, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown, Mark Rutland, Nicolas Boichat, DTML,
linux-pm, linux-kernel, Fan Chen,
moderated list:ARM/Mediatek SoC support, Arvin Wang, James Liao,
Linux ARM
On Thu, 2020-12-24 at 22:33 +0800, Chun-Kuang Hu wrote:
Hi CK,
> Hi, Henry:
>
> Henry Chen <henryc.chen@mediatek.com> 於 2020年12月24日 週四 下午2:09寫道：
> >
> > Add dvfsrc driver for MT6873/MT8183/MT8192
>
> Separate this patch for each SoC.
OK, thanks.
Henry
>
> Regards,
> Chun-Kuang.
>
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > drivers/soc/mediatek/Kconfig | 12 +
> > drivers/soc/mediatek/Makefile | 1 +
> > drivers/soc/mediatek/mtk-dvfsrc.c | 538 ++++++++++++++++++++++++++++++++
> > include/linux/soc/mediatek/mtk_dvfsrc.h | 35 +++
> > 4 files changed, 586 insertions(+)
> > create mode 100644 drivers/soc/mediatek/mtk-dvfsrc.c
> > create mode 100644 include/linux/soc/mediatek/mtk_dvfsrc.h
> >
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 07/13] dt-bindings: interconnect: add MT6873 interconnect dt-bindings
[not found] ` <1608790134-27425-8-git-send-email-henryc.chen@mediatek.com>
@ 2021-01-04 18:34 ` Georgi Djakov
0 siblings, 0 replies; 23+ messages in thread
From: Georgi Djakov @ 2021-01-04 18:34 UTC (permalink / raw)
To: Henry Chen, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
On 12/24/20 08:08, Henry Chen wrote:
> From: "henryc.chen" <henryc.chen@mediatek.com>
>
> Add interconnect provider dt-bindings for MT6873.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
checkpatch complains:
From:/Signed-off-by: email name mismatch:
'From: "henryc.chen" <henryc.chen@mediatek.com>' != 'Signed-off-by: Henry Chen
<henryc.chen@mediatek.com>'
Thanks,
Georgi
> ---
> include/dt-bindings/interconnect/mtk,mt6873-emi.h | 41 +++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 include/dt-bindings/interconnect/mtk,mt6873-emi.h
>
> diff --git a/include/dt-bindings/interconnect/mtk,mt6873-emi.h b/include/dt-bindings/interconnect/mtk,mt6873-emi.h
> new file mode 100644
> index 0000000..7a0bbfb
> --- /dev/null
> +++ b/include/dt-bindings/interconnect/mtk,mt6873-emi.h
> @@ -0,0 +1,41 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Copyright (c) 2020 MediaTek Inc.
> + */
> +
> +#ifndef __DT_BINDINGS_INTERCONNECT_MTK_MT6873_EMI_H
> +#define __DT_BINDINGS_INTERCONNECT_MTK_MT6873_EMI_H
> +
> +#define MT6873_SLAVE_DDR_EMI 0
> +#define MT6873_MASTER_MCUSYS 1
> +#define MT6873_MASTER_GPUSYS 2
> +#define MT6873_MASTER_MMSYS 3
> +#define MT6873_MASTER_MM_VPU 4
> +#define MT6873_MASTER_MM_DISP 5
> +#define MT6873_MASTER_MM_VDEC 6
> +#define MT6873_MASTER_MM_VENC 7
> +#define MT6873_MASTER_MM_CAM 8
> +#define MT6873_MASTER_MM_IMG 9
> +#define MT6873_MASTER_MM_MDP 10
> +#define MT6873_MASTER_VPUSYS 11
> +#define MT6873_MASTER_VPU_0 12
> +#define MT6873_MASTER_VPU_1 13
> +#define MT6873_MASTER_MDLASYS 14
> +#define MT6873_MASTER_MDLA_0 15
> +#define MT6873_MASTER_UFS 16
> +#define MT6873_MASTER_PCIE 17
> +#define MT6873_MASTER_USB 18
> +#define MT6873_MASTER_DBGIF 19
> +#define MT6873_SLAVE_HRT_DDR_EMI 20
> +#define MT6873_MASTER_HRT_MMSYS 21
> +#define MT6873_MASTER_HRT_MM_DISP 22
> +#define MT6873_MASTER_HRT_MM_VDEC 23
> +#define MT6873_MASTER_HRT_MM_VENC 24
> +#define MT6873_MASTER_HRT_MM_CAM 25
> +#define MT6873_MASTER_HRT_MM_IMG 26
> +#define MT6873_MASTER_HRT_MM_MDP 27
> +#define MT6873_MASTER_HRT_DBGIF 28
> +#define MT6873_MASTER_WIFI 29
> +#define MT6873_MASTER_BT 30
> +#define MT6873_MASTER_NETSYS 31
> +#endif
>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2020-12-24 6:08 ` [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
@ 2021-01-04 18:36 ` Georgi Djakov
2021-01-06 7:30 ` Henry Chen
0 siblings, 1 reply; 23+ messages in thread
From: Georgi Djakov @ 2021-01-04 18:36 UTC (permalink / raw)
To: Henry Chen, Rob Herring, Matthias Brugger, Stephen Boyd,
Ryan Case, Mark Brown
Cc: Mark Rutland, Nicolas Boichat, Fan Chen, James Liao, Arvin Wang,
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
On 12/24/20 08:08, Henry Chen wrote:
> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> using the interconnect framework.
>
> ICC provider ICC Nodes
> ---- ----
> --------- |CPU | |--- |VPU |
> ----- | |----- ---- | ----
> |DRAM |--|DRAM | ---- | ----
> | |--|scheduler|----- |GPU | |--- |DISP|
> | |--|(EMI) | ---- | ----
> | |--| | ----- | ----
> ----- | |----- |MMSYS|--|--- |VDEC|
> --------- ----- | ----
> /|\ | ----
> |change DRAM freq |--- |VENC|
> ---------- | ----
> | DVFSR | |
> | | | ----
> ---------- |--- |IMG |
> | ----
> | ----
> |--- |CAM |
> ----
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> drivers/interconnect/Kconfig | 1 +
> drivers/interconnect/Makefile | 1 +
> drivers/interconnect/mediatek/Kconfig | 13 ++
> drivers/interconnect/mediatek/Makefile | 3 +
> drivers/interconnect/mediatek/mtk-emi.c | 330 ++++++++++++++++++++++++++++++++
> 5 files changed, 348 insertions(+)
> create mode 100644 drivers/interconnect/mediatek/Kconfig
> create mode 100644 drivers/interconnect/mediatek/Makefile
> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
>
> diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
> index 5b7204e..e939f5a 100644
> --- a/drivers/interconnect/Kconfig
> +++ b/drivers/interconnect/Kconfig
> @@ -13,5 +13,6 @@ if INTERCONNECT
>
> source "drivers/interconnect/imx/Kconfig"
> source "drivers/interconnect/qcom/Kconfig"
> +source "drivers/interconnect/mediatek/Kconfig"
Sort alphabetically please.
>
> endif
> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
> index d203520..0643a24 100644
> --- a/drivers/interconnect/Makefile
> +++ b/drivers/interconnect/Makefile
> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
> obj-$(CONFIG_INTERCONNECT) += icc-core.o
> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
> +obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/
Ditto.
> diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig
> new file mode 100644
> index 0000000..972d3bb
> --- /dev/null
> +++ b/drivers/interconnect/mediatek/Kconfig
> @@ -0,0 +1,13 @@
> +config INTERCONNECT_MTK
> + bool "Mediatek Network-on-Chip interconnect drivers"
> + depends on ARCH_MEDIATEK
> + help
> + Support for Mediatek's Network-on-Chip interconnect hardware.
> +
> +config INTERCONNECT_MTK_EMI
> + tristate "Mediatek EMI interconnect driver"
> + depends on INTERCONNECT_MTK
> + depends on (MTK_DVFSRC && OF)
Would it be possible to enable COMPILE_TEST?
> + help
> + This is a driver for the Mediatek Network-on-Chip on DVFSRC-based
> + platforms.
> diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
> new file mode 100644
> index 0000000..353842b
> --- /dev/null
> +++ b/drivers/interconnect/mediatek/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +obj-$(CONFIG_INTERCONNECT_MTK_EMI) += mtk-emi.o
> \ No newline at end of file
> diff --git a/drivers/interconnect/mediatek/mtk-emi.c b/drivers/interconnect/mediatek/mtk-emi.c
> new file mode 100644
> index 0000000..9670077
> --- /dev/null
> +++ b/drivers/interconnect/mediatek/mtk-emi.c
> @@ -0,0 +1,330 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
Just a reminder that the year should be updated when you re-submit.
> + *
> + */
> +
> +#include <linux/device.h>
> +#include <linux/interconnect-provider.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/soc/mediatek/mtk_dvfsrc.h>
> +#include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> +#include <dt-bindings/interconnect/mtk,mt6873-emi.h>
Nit: Alphanumeric order please.
[..]
> +static int emi_icc_remove(struct platform_device *pdev);
> +static int emi_icc_probe(struct platform_device *pdev)
> +{
> + const struct of_device_id *match;
> + const struct mtk_icc_desc *desc;
> + struct device *dev = &pdev->dev;
> + struct icc_node *node;
> + struct icc_onecell_data *data;
> + struct icc_provider *provider;
> + struct mtk_icc_node **mnodes;
> + size_t num_nodes, i, j;
> + int ret;
> +
> + match = of_match_node(emi_icc_of_match, dev->parent->of_node);
> +
> + if (!match) {
> + dev_err(dev, "invalid compatible string\n");
> + return -ENODEV;
> + }
> +
> + desc = match->data;
> + mnodes = desc->nodes;
> + num_nodes = desc->num_nodes;
> +
> + provider = devm_kzalloc(dev, sizeof(*provider), GFP_KERNEL);
> + if (!provider)
> + return -ENOMEM;
> +
> + data = devm_kzalloc(dev, struct_size(data, nodes, num_nodes),
> + GFP_KERNEL);
> + if (!data)
> + return -ENOMEM;
> +
> + provider->dev = pdev->dev.parent;
> + provider->set = emi_icc_set;
> + provider->aggregate = emi_icc_aggregate;
> + provider->xlate = of_icc_xlate_onecell;
> + INIT_LIST_HEAD(&provider->nodes);
> + provider->data = data;
> +
> + ret = icc_provider_add(provider);
> + if (ret) {
> + dev_err(&pdev->dev, "error adding interconnect provider\n");
> + return ret;
> + }
> +
> + for (i = 0; i < num_nodes; i++) {
> + node = icc_node_create(mnodes[i]->id);
> + if (IS_ERR(node)) {
> + ret = PTR_ERR(node);
> + goto err;
> + }
> +
> + node->name = mnodes[i]->name;
> + node->data = mnodes[i];
> + icc_node_add(node, provider);
> +
> + for (j = 0; j < mnodes[i]->num_links; j++)
> + icc_link_create(node, mnodes[i]->links[j]);
> +
> + data->nodes[i] = node;
> + }
> + data->num_nodes = num_nodes;
> +
> + platform_set_drvdata(pdev, provider);
> +
> + return 0;
> +err:
> + icc_nodes_remove(provider);
Also call icc_provider_del() to restore the original state on error.
Thanks,
Georgi
> + return ret;
> +}
> +
> +static int emi_icc_remove(struct platform_device *pdev)
> +{
> + struct icc_provider *provider = platform_get_drvdata(pdev);
> +
> + icc_nodes_remove(provider);
> + return icc_provider_del(provider);
> +}
> +
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: (subset) [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
` (9 preceding siblings ...)
[not found] ` <1608790134-27425-8-git-send-email-henryc.chen@mediatek.com>
@ 2021-01-05 16:07 ` Mark Brown
10 siblings, 0 replies; 23+ messages in thread
From: Mark Brown @ 2021-01-05 16:07 UTC (permalink / raw)
To: Ryan Case, Matthias Brugger, Rob Herring, Georgi Djakov,
Stephen Boyd, Henry Chen
Cc: Mark Rutland, Arvin Wang, James Liao, devicetree, linux-mediatek,
linux-pm, Fan Chen, Nicolas Boichat, linux-arm-kernel,
linux-kernel
On Thu, 24 Dec 2020 14:08:41 +0800, Henry Chen wrote:
> This series is based on v5.10-rc1.
>
> The patchsets add support for MediaTek hardware module named DVFSRC
> (dynamic voltage and frequency scaling resource collector). The DVFSRC is
> a HW module which is used to collect all the requests from both software
> and hardware and turn into the decision of minimum operating voltage and
> minimum DRAM frequency to fulfill those requests.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[11/13] regulator: Regulator driver for the Mediatek DVFSRC
commit: a0db6b0aa670ba040f959a000ef24dd4238e016b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2021-01-04 18:36 ` Georgi Djakov
@ 2021-01-06 7:30 ` Henry Chen
2021-01-06 8:14 ` Georgi Djakov
0 siblings, 1 reply; 23+ messages in thread
From: Henry Chen @ 2021-01-06 7:30 UTC (permalink / raw)
To: Georgi Djakov
Cc: Rob Herring, Matthias Brugger, Stephen Boyd, Ryan Case,
Mark Brown, Mark Rutland, Nicolas Boichat, Fan Chen, James Liao,
Arvin Wang, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, linux-pm
On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
> On 12/24/20 08:08, Henry Chen wrote:
> > Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> > using the interconnect framework.
> >
> > ICC provider ICC Nodes
> > ---- ----
> > --------- |CPU | |--- |VPU |
> > ----- | |----- ---- | ----
> > |DRAM |--|DRAM | ---- | ----
> > | |--|scheduler|----- |GPU | |--- |DISP|
> > | |--|(EMI) | ---- | ----
> > | |--| | ----- | ----
> > ----- | |----- |MMSYS|--|--- |VDEC|
> > --------- ----- | ----
> > /|\ | ----
> > |change DRAM freq |--- |VENC|
> > ---------- | ----
> > | DVFSR | |
> > | | | ----
> > ---------- |--- |IMG |
> > | ----
> > | ----
> > |--- |CAM |
> > ----
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > drivers/interconnect/Kconfig | 1 +
> > drivers/interconnect/Makefile | 1 +
> > drivers/interconnect/mediatek/Kconfig | 13 ++
> > drivers/interconnect/mediatek/Makefile | 3 +
> > drivers/interconnect/mediatek/mtk-emi.c | 330 ++++++++++++++++++++++++++++++++
> > 5 files changed, 348 insertions(+)
> > create mode 100644 drivers/interconnect/mediatek/Kconfig
> > create mode 100644 drivers/interconnect/mediatek/Makefile
> > create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
> >
> > diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
> > index 5b7204e..e939f5a 100644
> > --- a/drivers/interconnect/Kconfig
> > +++ b/drivers/interconnect/Kconfig
> > @@ -13,5 +13,6 @@ if INTERCONNECT
> >
> > source "drivers/interconnect/imx/Kconfig"
> > source "drivers/interconnect/qcom/Kconfig"
> > +source "drivers/interconnect/mediatek/Kconfig"
>
> Sort alphabetically please.
Ok
>
> >
> > endif
> > diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
> > index d203520..0643a24 100644
> > --- a/drivers/interconnect/Makefile
> > +++ b/drivers/interconnect/Makefile
> > @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
> > obj-$(CONFIG_INTERCONNECT) += icc-core.o
> > obj-$(CONFIG_INTERCONNECT_IMX) += imx/
> > obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
> > +obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/
>
> Ditto.
Ok
>
> > diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig
> > new file mode 100644
> > index 0000000..972d3bb
> > --- /dev/null
> > +++ b/drivers/interconnect/mediatek/Kconfig
> > @@ -0,0 +1,13 @@
> > +config INTERCONNECT_MTK
> > + bool "Mediatek Network-on-Chip interconnect drivers"
> > + depends on ARCH_MEDIATEK
> > + help
> > + Support for Mediatek's Network-on-Chip interconnect hardware.
> > +
> > +config INTERCONNECT_MTK_EMI
> > + tristate "Mediatek EMI interconnect driver"
> > + depends on INTERCONNECT_MTK
> > + depends on (MTK_DVFSRC && OF)
>
> Would it be possible to enable COMPILE_TEST?
Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
>
> > + help
> > + This is a driver for the Mediatek Network-on-Chip on DVFSRC-based
> > + platforms.
> > diff --git a/drivers/interconnect/mediatek/Makefile b/drivers/interconnect/mediatek/Makefile
> > new file mode 100644
> > index 0000000..353842b
> > --- /dev/null
> > +++ b/drivers/interconnect/mediatek/Makefile
> > @@ -0,0 +1,3 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +obj-$(CONFIG_INTERCONNECT_MTK_EMI) += mtk-emi.o
> > \ No newline at end of file
> > diff --git a/drivers/interconnect/mediatek/mtk-emi.c b/drivers/interconnect/mediatek/mtk-emi.c
> > new file mode 100644
> > index 0000000..9670077
> > --- /dev/null
> > +++ b/drivers/interconnect/mediatek/mtk-emi.c
> > @@ -0,0 +1,330 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
>
> Just a reminder that the year should be updated when you re-submit.
OK, thanks for reminding me.
>
> > + *
> > + */
> > +
> > +#include <linux/device.h>
> > +#include <linux/interconnect-provider.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/soc/mediatek/mtk_dvfsrc.h>
> > +#include <dt-bindings/interconnect/mtk,mt8183-emi.h>
> > +#include <dt-bindings/interconnect/mtk,mt6873-emi.h>
>
> Nit: Alphanumeric order please.
OK.
>
> [..]
> > +static int emi_icc_remove(struct platform_device *pdev);
> > +static int emi_icc_probe(struct platform_device *pdev)
> > +{
> > + const struct of_device_id *match;
> > + const struct mtk_icc_desc *desc;
> > + struct device *dev = &pdev->dev;
> > + struct icc_node *node;
> > + struct icc_onecell_data *data;
> > + struct icc_provider *provider;
> > + struct mtk_icc_node **mnodes;
> > + size_t num_nodes, i, j;
> > + int ret;
> > +
> > + match = of_match_node(emi_icc_of_match, dev->parent->of_node);
> > +
> > + if (!match) {
> > + dev_err(dev, "invalid compatible string\n");
> > + return -ENODEV;
> > + }
> > +
> > + desc = match->data;
> > + mnodes = desc->nodes;
> > + num_nodes = desc->num_nodes;
> > +
> > + provider = devm_kzalloc(dev, sizeof(*provider), GFP_KERNEL);
> > + if (!provider)
> > + return -ENOMEM;
> > +
> > + data = devm_kzalloc(dev, struct_size(data, nodes, num_nodes),
> > + GFP_KERNEL);
> > + if (!data)
> > + return -ENOMEM;
> > +
> > + provider->dev = pdev->dev.parent;
> > + provider->set = emi_icc_set;
> > + provider->aggregate = emi_icc_aggregate;
> > + provider->xlate = of_icc_xlate_onecell;
> > + INIT_LIST_HEAD(&provider->nodes);
> > + provider->data = data;
> > +
> > + ret = icc_provider_add(provider);
> > + if (ret) {
> > + dev_err(&pdev->dev, "error adding interconnect provider\n");
> > + return ret;
> > + }
> > +
> > + for (i = 0; i < num_nodes; i++) {
> > + node = icc_node_create(mnodes[i]->id);
> > + if (IS_ERR(node)) {
> > + ret = PTR_ERR(node);
> > + goto err;
> > + }
> > +
> > + node->name = mnodes[i]->name;
> > + node->data = mnodes[i];
> > + icc_node_add(node, provider);
> > +
> > + for (j = 0; j < mnodes[i]->num_links; j++)
> > + icc_link_create(node, mnodes[i]->links[j]);
> > +
> > + data->nodes[i] = node;
> > + }
> > + data->num_nodes = num_nodes;
> > +
> > + platform_set_drvdata(pdev, provider);
> > +
> > + return 0;
> > +err:
> > + icc_nodes_remove(provider);
>
> Also call icc_provider_del() to restore the original state on error.
OK.
Thanks,
Henry
>
> Thanks,
> Georgi
>
> > + return ret;
> > +}
> > +
> > +static int emi_icc_remove(struct platform_device *pdev)
> > +{
> > + struct icc_provider *provider = platform_get_drvdata(pdev);
> > +
> > + icc_nodes_remove(provider);
> > + return icc_provider_del(provider);
> > +}
> > +
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2021-01-06 7:30 ` Henry Chen
@ 2021-01-06 8:14 ` Georgi Djakov
2021-01-06 10:44 ` HenryC Chen (陳建豪)
0 siblings, 1 reply; 23+ messages in thread
From: Georgi Djakov @ 2021-01-06 8:14 UTC (permalink / raw)
To: Henry Chen
Cc: Rob Herring, Matthias Brugger, Stephen Boyd, Ryan Case,
Mark Brown, Mark Rutland, Nicolas Boichat, Fan Chen, James Liao,
Arvin Wang, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, linux-pm
On 1/6/21 09:30, Henry Chen wrote:
> On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
>> On 12/24/20 08:08, Henry Chen wrote:
>>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
>>> using the interconnect framework.
>>>
>>> ICC provider ICC Nodes
>>> ---- ----
>>> --------- |CPU | |--- |VPU |
>>> ----- | |----- ---- | ----
>>> |DRAM |--|DRAM | ---- | ----
>>> | |--|scheduler|----- |GPU | |--- |DISP|
>>> | |--|(EMI) | ---- | ----
>>> | |--| | ----- | ----
>>> ----- | |----- |MMSYS|--|--- |VDEC|
>>> --------- ----- | ----
>>> /|\ | ----
>>> |change DRAM freq |--- |VENC|
>>> ---------- | ----
>>> | DVFSR | |
>>> | | | ----
>>> ---------- |--- |IMG |
>>> | ----
>>> | ----
>>> |--- |CAM |
>>> ----
>>>
>>> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
>>> ---
>>> drivers/interconnect/Kconfig | 1 +
>>> drivers/interconnect/Makefile | 1 +
>>> drivers/interconnect/mediatek/Kconfig | 13 ++
>>> drivers/interconnect/mediatek/Makefile | 3 +
>>> drivers/interconnect/mediatek/mtk-emi.c | 330 ++++++++++++++++++++++++++++++++
>>> 5 files changed, 348 insertions(+)
>>> create mode 100644 drivers/interconnect/mediatek/Kconfig
>>> create mode 100644 drivers/interconnect/mediatek/Makefile
>>> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
>>>
>>> diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
>>> index 5b7204e..e939f5a 100644
>>> --- a/drivers/interconnect/Kconfig
>>> +++ b/drivers/interconnect/Kconfig
>>> @@ -13,5 +13,6 @@ if INTERCONNECT
>>>
>>> source "drivers/interconnect/imx/Kconfig"
>>> source "drivers/interconnect/qcom/Kconfig"
>>> +source "drivers/interconnect/mediatek/Kconfig"
>>
>> Sort alphabetically please.
> Ok
>>
>>>
>>> endif
>>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
>>> index d203520..0643a24 100644
>>> --- a/drivers/interconnect/Makefile
>>> +++ b/drivers/interconnect/Makefile
>>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
>>> obj-$(CONFIG_INTERCONNECT) += icc-core.o
>>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
>>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
>>> +obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/
>>
>> Ditto.
> Ok
>>
>>> diff --git a/drivers/interconnect/mediatek/Kconfig b/drivers/interconnect/mediatek/Kconfig
>>> new file mode 100644
>>> index 0000000..972d3bb
>>> --- /dev/null
>>> +++ b/drivers/interconnect/mediatek/Kconfig
>>> @@ -0,0 +1,13 @@
>>> +config INTERCONNECT_MTK
>>> + bool "Mediatek Network-on-Chip interconnect drivers"
>>> + depends on ARCH_MEDIATEK
>>> + help
>>> + Support for Mediatek's Network-on-Chip interconnect hardware.
>>> +
>>> +config INTERCONNECT_MTK_EMI
>>> + tristate "Mediatek EMI interconnect driver"
>>> + depends on INTERCONNECT_MTK
>>> + depends on (MTK_DVFSRC && OF)
>>
>> Would it be possible to enable COMPILE_TEST?
> Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could even change
it for INTERCONNECT_MTK to something like:
depends on ARCH_MEDIATEK || COMPILE_TEST
Will this work?
Thanks,
Georgi
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2021-01-06 8:14 ` Georgi Djakov
@ 2021-01-06 10:44 ` HenryC Chen (陳建豪)
2021-01-06 12:49 ` Georgi Djakov
0 siblings, 1 reply; 23+ messages in thread
From: HenryC Chen (陳建豪) @ 2021-01-06 10:44 UTC (permalink / raw)
To: Georgi Djakov
Cc: Rob Herring, Matthias Brugger, Stephen Boyd, Ryan Case,
Mark Brown, Mark Rutland, Nicolas Boichat,
Fan Chen (陳凡),
JamesJJ Liao (廖建智),
Arvin Wang (王志銘),
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
> -----Original Message-----
> From: Georgi Djakov [mailto:georgi.djakov@linaro.org]
> Sent: Wednesday, January 06, 2021 4:14 PM
> To: HenryC Chen (陳建豪)
> Cc: Rob Herring; Matthias Brugger; Stephen Boyd; Ryan Case; Mark Brown; Mark
> Rutland; Nicolas Boichat; Fan Chen (陳凡); JamesJJ Liao (廖建智); Arvin Wang
> (王志銘); devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> pm@vger.kernel.org
> Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect
> provider driver
>
> On 1/6/21 09:30, Henry Chen wrote:
> > On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
> >> On 12/24/20 08:08, Henry Chen wrote:
> >>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> >>> using the interconnect framework.
> >>>
> >>> ICC provider ICC Nodes
> >>> ---- ----
> >>> --------- |CPU | |--- |VPU |
> >>> ----- | |----- ---- | ----
> >>> |DRAM |--|DRAM | ---- | ----
> >>> | |--|scheduler|----- |GPU | |--- |DISP|
> >>> | |--|(EMI) | ---- | ----
> >>> | |--| | ----- | ----
> >>> ----- | |----- |MMSYS|--|--- |VDEC|
> >>> --------- ----- | ----
> >>> /|\ | ----
> >>> |change DRAM freq |--- |VENC|
> >>> ---------- | ----
> >>> | DVFSR | |
> >>> | | | ----
> >>> ---------- |--- |IMG |
> >>> | ----
> >>> | ----
> >>> |--- |CAM |
> >>> ----
> >>>
> >>> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> >>> ---
> >>> drivers/interconnect/Kconfig | 1 +
> >>> drivers/interconnect/Makefile | 1 +
> >>> drivers/interconnect/mediatek/Kconfig | 13 ++
> >>> drivers/interconnect/mediatek/Makefile | 3 +
> >>> drivers/interconnect/mediatek/mtk-emi.c | 330
> ++++++++++++++++++++++++++++++++
> >>> 5 files changed, 348 insertions(+)
> >>> create mode 100644 drivers/interconnect/mediatek/Kconfig
> >>> create mode 100644 drivers/interconnect/mediatek/Makefile
> >>> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
> >>>
> >>> diff --git a/drivers/interconnect/Kconfig
> >>> b/drivers/interconnect/Kconfig index 5b7204e..e939f5a 100644
> >>> --- a/drivers/interconnect/Kconfig
> >>> +++ b/drivers/interconnect/Kconfig
> >>> @@ -13,5 +13,6 @@ if INTERCONNECT
> >>>
> >>> source "drivers/interconnect/imx/Kconfig"
> >>> source "drivers/interconnect/qcom/Kconfig"
> >>> +source "drivers/interconnect/mediatek/Kconfig"
> >>
> >> Sort alphabetically please.
> > Ok
> >>
> >>>
> >>> endif
> >>> diff --git a/drivers/interconnect/Makefile
> >>> b/drivers/interconnect/Makefile index d203520..0643a24 100644
> >>> --- a/drivers/interconnect/Makefile
> >>> +++ b/drivers/interconnect/Makefile
> >>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
> >>> obj-$(CONFIG_INTERCONNECT) += icc-core.o
> >>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
> >>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
> >>> +obj-$(CONFIG_INTERCONNECT_MTK) += mediatek/
> >>
> >> Ditto.
> > Ok
> >>
> >>> diff --git a/drivers/interconnect/mediatek/Kconfig
> >>> b/drivers/interconnect/mediatek/Kconfig
> >>> new file mode 100644
> >>> index 0000000..972d3bb
> >>> --- /dev/null
> >>> +++ b/drivers/interconnect/mediatek/Kconfig
> >>> @@ -0,0 +1,13 @@
> >>> +config INTERCONNECT_MTK
> >>> + bool "Mediatek Network-on-Chip interconnect drivers"
> >>> + depends on ARCH_MEDIATEK
> >>> + help
> >>> + Support for Mediatek's Network-on-Chip interconnect hardware.
> >>> +
> >>> +config INTERCONNECT_MTK_EMI
> >>> + tristate "Mediatek EMI interconnect driver"
> >>> + depends on INTERCONNECT_MTK
> >>> + depends on (MTK_DVFSRC && OF)
> >>
> >> Would it be possible to enable COMPILE_TEST?
> > Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
>
> Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could even
> change it for INTERCONNECT_MTK to something like:
> depends on ARCH_MEDIATEK || COMPILE_TEST Will this work?
Hi Georgi,
So..only change to as following?
config INTERCONNECT_MTK
bool "Mediatek Network-on-Chip interconnect drivers"
depends on ARCH_MEDIATEK || COMPILE_TEST
help
Support for Mediatek's Network-on-Chip interconnect hardware.
>
> Thanks,
> Georgi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2021-01-06 10:44 ` HenryC Chen (陳建豪)
@ 2021-01-06 12:49 ` Georgi Djakov
2021-01-06 13:11 ` HenryC Chen (陳建豪)
0 siblings, 1 reply; 23+ messages in thread
From: Georgi Djakov @ 2021-01-06 12:49 UTC (permalink / raw)
To: HenryC Chen (陳建豪)
Cc: Rob Herring, Matthias Brugger, Stephen Boyd, Ryan Case,
Mark Brown, Mark Rutland, Nicolas Boichat,
Fan Chen (陳凡),
JamesJJ Liao (廖建智),
Arvin Wang (王志銘),
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
On 6.01.21 12:44, HenryC Chen (陳建豪) wrote:
>> -----Original Message-----
>> From: Georgi Djakov [mailto:georgi.djakov@linaro.org]
>> Sent: Wednesday, January 06, 2021 4:14 PM
>> To: HenryC Chen (陳建豪)
>> Cc: Rob Herring; Matthias Brugger; Stephen Boyd; Ryan Case; Mark Brown; Mark
>> Rutland; Nicolas Boichat; Fan Chen (陳凡); JamesJJ Liao (廖建智); Arvin Wang
>> (王志銘); devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
>> pm@vger.kernel.org
>> Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect
>> provider driver
>>
>> On 1/6/21 09:30, Henry Chen wrote:
>> > On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
>> >> On 12/24/20 08:08, Henry Chen wrote:
>> >>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
>> >>> using the interconnect framework.
>> >>>
>> >>> ICC provider ICC Nodes
>> >>> ---- ----
>> >>> --------- |CPU | |--- |VPU |
>> >>> ----- | |----- ---- | ----
>> >>> |DRAM |--|DRAM | ---- | ----
>> >>> | |--|scheduler|----- |GPU | |--- |DISP|
>> >>> | |--|(EMI) | ---- | ----
>> >>> | |--| | ----- | ----
>> >>> ----- | |----- |MMSYS|--|--- |VDEC|
>> >>> --------- ----- | ----
>> >>> /|\ | ----
>> >>> |change DRAM freq |--- |VENC|
>> >>> ---------- | ----
>> >>> | DVFSR | |
>> >>> | | | ----
>> >>> ---------- |--- |IMG |
>> >>> | ----
>> >>> | ----
>> >>> |--- |CAM |
>> >>> ----
>> >>>
>> >>> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
>> >>> ---
>> >>> drivers/interconnect/Kconfig | 1 +
>> >>> drivers/interconnect/Makefile | 1 +
>> >>> drivers/interconnect/mediatek/Kconfig | 13 ++
>> >>> drivers/interconnect/mediatek/Makefile | 3 +
>> >>> drivers/interconnect/mediatek/mtk-emi.c | 330
>> ++++++++++++++++++++++++++++++++
>> >>> 5 files changed, 348 insertions(+)
>> >>> create mode 100644 drivers/interconnect/mediatek/Kconfig
>> >>> create mode 100644 drivers/interconnect/mediatek/Makefile
>> >>> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
>> >>>
>> >>> diff --git a/drivers/interconnect/Kconfig
>> >>> b/drivers/interconnect/Kconfig index 5b7204e..e939f5a 100644
>> >>> --- a/drivers/interconnect/Kconfig
>> >>> +++ b/drivers/interconnect/Kconfig
>> >>> @@ -13,5 +13,6 @@ if INTERCONNECT
>> >>>
>> >>> source "drivers/interconnect/imx/Kconfig"
>> >>> source "drivers/interconnect/qcom/Kconfig"
>> >>> +source "drivers/interconnect/mediatek/Kconfig"
>> >>
>> >> Sort alphabetically please.
>> > Ok
>> >>
>> >>>
>> >>> endif
>> >>> diff --git a/drivers/interconnect/Makefile
>> >>> b/drivers/interconnect/Makefile index d203520..0643a24 100644
>> >>> --- a/drivers/interconnect/Makefile
>> >>> +++ b/drivers/interconnect/Makefile
>> >>> @@ -6,3 +6,4 @@ icc-core-objs:= core.o bulk.o
>> >>> obj-$(CONFIG_INTERCONNECT)+= icc-core.o
>> >>> obj-$(CONFIG_INTERCONNECT_IMX)+= imx/
>> >>> obj-$(CONFIG_INTERCONNECT_QCOM)+= qcom/
>> >>> +obj-$(CONFIG_INTERCONNECT_MTK)+= mediatek/
>> >>
>> >> Ditto.
>> > Ok
>> >>
>> >>> diff --git a/drivers/interconnect/mediatek/Kconfig
>> >>> b/drivers/interconnect/mediatek/Kconfig
>> >>> new file mode 100644
>> >>> index 0000000..972d3bb
>> >>> --- /dev/null
>> >>> +++ b/drivers/interconnect/mediatek/Kconfig
>> >>> @@ -0,0 +1,13 @@
>> >>> +config INTERCONNECT_MTK
>> >>> +bool "Mediatek Network-on-Chip interconnect drivers"
>> >>> +depends on ARCH_MEDIATEK
>> >>> +help
>> >>> + Support for Mediatek's Network-on-Chip interconnect hardware.
>> >>> +
>> >>> +config INTERCONNECT_MTK_EMI
>> >>> +tristate "Mediatek EMI interconnect driver"
>> >>> +depends on INTERCONNECT_MTK
>> >>> +depends on (MTK_DVFSRC && OF)
>> >>
>> >> Would it be possible to enable COMPILE_TEST?
>> > Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
>>
>> Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could even
>> change it for INTERCONNECT_MTK to something like:
>> depends on ARCH_MEDIATEK || COMPILE_TEST Will this work?
> Hi Georgi,
>
> So..only change to as following?
>
> config INTERCONNECT_MTK
> bool "Mediatek Network-on-Chip interconnect drivers"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> help
> Support for Mediatek's Network-on-Chip interconnect hardware.
I would say to add COMPILE_TEST for both INTERCONNECT_MTK and
INTERCONNECT_MTK_EMI, unless there is some dependency which does
not allow us to do so.
Thanks,
Georgi
^ permalink raw reply [flat|nested] 23+ messages in thread
* RE: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
2021-01-06 12:49 ` Georgi Djakov
@ 2021-01-06 13:11 ` HenryC Chen (陳建豪)
0 siblings, 0 replies; 23+ messages in thread
From: HenryC Chen (陳建豪) @ 2021-01-06 13:11 UTC (permalink / raw)
To: Georgi Djakov
Cc: Rob Herring, Matthias Brugger, Stephen Boyd, Ryan Case,
Mark Brown, Mark Rutland, Nicolas Boichat,
Fan Chen (陳凡),
JamesJJ Liao (廖建智),
Arvin Wang (王志銘),
devicetree, linux-arm-kernel, linux-mediatek, linux-kernel,
linux-pm
> -----Original Message-----
> From: Georgi Djakov [mailto:georgi.djakov@linaro.org]
> Sent: Wednesday, January 06, 2021 8:50 PM
> To: HenryC Chen (陳建豪)
> Cc: Rob Herring; Matthias Brugger; Stephen Boyd; Ryan Case; Mark Brown; Mark
> Rutland; Nicolas Boichat; Fan Chen (陳凡); JamesJJ Liao (廖建智); Arvin Wang
> (王志銘); devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> pm@vger.kernel.org
> Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect
> provider driver
>
> On 6.01.21 12:44, HenryC Chen (陳建豪) wrote:
> >> -----Original Message-----
> >> From: Georgi Djakov [mailto:georgi.djakov@linaro.org]
> >> Sent: Wednesday, January 06, 2021 4:14 PM
> >> To: HenryC Chen (陳建豪)
> >> Cc: Rob Herring; Matthias Brugger; Stephen Boyd; Ryan Case; Mark
> >> Brown; Mark Rutland; Nicolas Boichat; Fan Chen (陳凡); JamesJJ Liao
> >> (廖建智); Arvin Wang
> >> (王志銘); devicetree@vger.kernel.org;
> >> linux-arm-kernel@lists.infradead.org;
> >> linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org;
> >> linux- pm@vger.kernel.org
> >> Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add
> >> interconnect provider driver
> >>
> >> On 1/6/21 09:30, Henry Chen wrote:
> >> > On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
> >> >> On 12/24/20 08:08, Henry Chen wrote:
> >> >>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> >> >>> using the interconnect framework.
> >> >>>
> >> >>> ICC provider ICC Nodes
> >> >>> ---- ----
> >> >>> --------- |CPU | |--- |VPU |
> >> >>> ----- | |----- ---- | ----
> >> >>> |DRAM |--|DRAM | ---- | ----
> >> >>> | |--|scheduler|----- |GPU | |--- |DISP|
> >> >>> | |--|(EMI) | ---- | ----
> >> >>> | |--| | ----- | ----
> >> >>> ----- | |----- |MMSYS|--|--- |VDEC|
> >> >>> --------- ----- | ----
> >> >>> /|\ | ----
> >> >>> |change DRAM freq |--- |VENC|
> >> >>> ---------- | ----
> >> >>> | DVFSR | |
> >> >>> | | | ----
> >> >>> ---------- |--- |IMG |
> >> >>> | ----
> >> >>> | ----
> >> >>> |--- |CAM |
> >> >>> ----
> >> >>>
> >> >>> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> >> >>> ---
> >> >>> drivers/interconnect/Kconfig | 1 +
> >> >>> drivers/interconnect/Makefile | 1 +
> >> >>> drivers/interconnect/mediatek/Kconfig | 13 ++
> >> >>> drivers/interconnect/mediatek/Makefile | 3 +
> >> >>> drivers/interconnect/mediatek/mtk-emi.c | 330
> >> ++++++++++++++++++++++++++++++++
> >> >>> 5 files changed, 348 insertions(+)
> >> >>> create mode 100644 drivers/interconnect/mediatek/Kconfig
> >> >>> create mode 100644 drivers/interconnect/mediatek/Makefile
> >> >>> create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
> >> >>>
> >> >>> diff --git a/drivers/interconnect/Kconfig
> >> >>> b/drivers/interconnect/Kconfig index 5b7204e..e939f5a 100644
> >> >>> --- a/drivers/interconnect/Kconfig
> >> >>> +++ b/drivers/interconnect/Kconfig
> >> >>> @@ -13,5 +13,6 @@ if INTERCONNECT
> >> >>>
> >> >>> source "drivers/interconnect/imx/Kconfig"
> >> >>> source "drivers/interconnect/qcom/Kconfig"
> >> >>> +source "drivers/interconnect/mediatek/Kconfig"
> >> >>
> >> >> Sort alphabetically please.
> >> > Ok
> >> >>
> >> >>>
> >> >>> endif
> >> >>> diff --git a/drivers/interconnect/Makefile
> >> >>> b/drivers/interconnect/Makefile index d203520..0643a24 100644
> >> >>> --- a/drivers/interconnect/Makefile
> >> >>> +++ b/drivers/interconnect/Makefile
> >> >>> @@ -6,3 +6,4 @@ icc-core-objs:= core.o bulk.o
> >> >>> obj-$(CONFIG_INTERCONNECT)+= icc-core.o
> >> >>> obj-$(CONFIG_INTERCONNECT_IMX)+= imx/
> >> >>> obj-$(CONFIG_INTERCONNECT_QCOM)+= qcom/
> >> >>> +obj-$(CONFIG_INTERCONNECT_MTK)+= mediatek/
> >> >>
> >> >> Ditto.
> >> > Ok
> >> >>
> >> >>> diff --git a/drivers/interconnect/mediatek/Kconfig
> >> >>> b/drivers/interconnect/mediatek/Kconfig
> >> >>> new file mode 100644
> >> >>> index 0000000..972d3bb
> >> >>> --- /dev/null
> >> >>> +++ b/drivers/interconnect/mediatek/Kconfig
> >> >>> @@ -0,0 +1,13 @@
> >> >>> +config INTERCONNECT_MTK
> >> >>> +bool "Mediatek Network-on-Chip interconnect drivers"
> >> >>> +depends on ARCH_MEDIATEK
> >> >>> +help
> >> >>> + Support for Mediatek's Network-on-Chip interconnect hardware.
> >> >>> +
> >> >>> +config INTERCONNECT_MTK_EMI
> >> >>> +tristate "Mediatek EMI interconnect driver"
> >> >>> +depends on INTERCONNECT_MTK
> >> >>> +depends on (MTK_DVFSRC && OF)
> >> >>
> >> >> Would it be possible to enable COMPILE_TEST?
> >> > Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
> >>
> >> Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could
> >> even change it for INTERCONNECT_MTK to something like:
> >> depends on ARCH_MEDIATEK || COMPILE_TEST Will this work?
> > Hi Georgi,
> >
> > So..only change to as following?
> >
> > config INTERCONNECT_MTK
> > bool "Mediatek Network-on-Chip interconnect drivers"
> > depends on ARCH_MEDIATEK || COMPILE_TEST help
> > Support for Mediatek's Network-on-Chip interconnect hardware.
>
> I would say to add COMPILE_TEST for both INTERCONNECT_MTK and
> INTERCONNECT_MTK_EMI, unless there is some dependency which does not allow us
> to do so.
Understood, thanks.
>
> Thanks,
> Georgi
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings
2020-12-24 6:08 ` [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
@ 2021-01-08 2:53 ` Rob Herring
0 siblings, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-01-08 2:53 UTC (permalink / raw)
To: Henry Chen
Cc: linux-arm-kernel, Stephen Boyd, linux-mediatek, linux-pm,
Matthias Brugger, Rob Herring, Fan Chen, Mark Brown,
Mark Rutland, linux-kernel, Ryan Case, James Liao, devicetree,
Arvin Wang, Georgi Djakov, Nicolas Boichat
On Thu, 24 Dec 2020 14:08:47 +0800, Henry Chen wrote:
> Add interconnect provider dt-bindings for MT8183.
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
> include/dt-bindings/interconnect/mtk,mt8183-emi.h | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 include/dt-bindings/interconnect/mtk,mt8183-emi.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2021-01-08 2:54 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-24 6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-12-24 6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2020-12-24 17:01 ` Rob Herring
2020-12-25 5:12 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 02/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
2020-12-24 6:08 ` [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
2020-12-24 14:33 ` Chun-Kuang Hu
2020-12-25 5:14 ` Henry Chen
2020-12-24 6:08 ` [PATCH V6 04/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-12-24 6:08 ` [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2021-01-08 2:53 ` Rob Herring
2020-12-24 6:08 ` [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
2021-01-04 18:36 ` Georgi Djakov
2021-01-06 7:30 ` Henry Chen
2021-01-06 8:14 ` Georgi Djakov
2021-01-06 10:44 ` HenryC Chen (陳建豪)
2021-01-06 12:49 ` Georgi Djakov
2021-01-06 13:11 ` HenryC Chen (陳建豪)
2020-12-24 6:08 ` [PATCH V6 09/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-12-24 6:08 ` [PATCH V6 10/13] arm64: dts: mt8192: " Henry Chen
2020-12-24 6:08 ` [PATCH V6 12/13] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
[not found] ` <1608790134-27425-8-git-send-email-henryc.chen@mediatek.com>
2021-01-04 18:34 ` [PATCH V6 07/13] dt-bindings: interconnect: add MT6873 interconnect dt-bindings Georgi Djakov
2021-01-05 16:07 ` (subset) [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).