linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Laurence Oberman <loberman@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] V2 init/main.c Enable watchdog_thresh control from kernel line
Date: Wed, 24 Oct 2018 09:19:01 -0700	[thread overview]
Message-ID: <88de4b50-b3cd-1870-8944-92163df84bb3@infradead.org> (raw)
In-Reply-To: <1540396387-20337-1-git-send-email-loberman@redhat.com>

On 10/24/18 8:53 AM, Laurence Oberman wrote:
> Both graphics and serial consoles are exposed to hard lockups
> when handling a large amount of messaging. The kernel watchdog_thresh
> parameter up to now has not been available to be set on the kernel line for
> early boot. 
> This patch allows the setting of watchdog_thresh to be increased
> when needed to avoid the hard lockups in the console code.
> 
> Signed-off-by: Laurence Oberman <loberman@redhat.com>
> ---
>  init/main.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/init/main.c b/init/main.c
> index e4a3160..5882750 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -977,6 +977,15 @@ static int __init set_debug_rodata(char *str)
>  __setup("rodata=", set_debug_rodata);
>  #endif
>  
> +static int __init
> +is_watchdog_thresh_setup(char *str)
> +{
> +	get_option(&str, &watchdog_thresh);
> +	return 1;
> +}
> +__setup("watchdog_thresh=", is_watchdog_thresh_setup);
> +
> +
>  #ifdef CONFIG_STRICT_KERNEL_RWX
>  static void mark_readonly(void)
>  {
> 

Hi Laurence,

Let's make this into more of a complete patch.

a.  update the diffstat to include the Documentation change

b.  send the patch with the Documentation change as part of the same patch,
not as a separate patch (It looks like the multiple "---" lines in the
email are confusing.)

c.  send the patch to someone who can merge it: scripts/get_maintainer.pl top
suggestions are:
Thomas Gleixner <tglx@linutronix.de> or Ingo Molnar <mingo@kernel.org>

thanks,
-- 
~Randy

      reply	other threads:[~2018-10-24 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 15:53 [PATCH] V2 init/main.c Enable watchdog_thresh control from kernel line Laurence Oberman
2018-10-24 16:19 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88de4b50-b3cd-1870-8944-92163df84bb3@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loberman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).