From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Tong Tiangen <tongtiangen@huawei.com>,
Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Robin Murphy <robin.murphy@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, <x86@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: <linuxppc-dev@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Xie XiuQi <xiexiuqi@huawei.com>, Guohanjun <guohanjun@huawei.com>
Subject: Re: [PATCH -next v6 00/10]arm64: add machine check safe support
Date: Tue, 28 Jun 2022 19:17:15 +0800 [thread overview]
Message-ID: <88e574b4-3191-8c0f-1dc3-7c54c426142c@huawei.com> (raw)
In-Reply-To: <20220621072638.1273594-1-tongtiangen@huawei.com>
On 2022/6/21 15:26, Tong Tiangen wrote:
> With the increase of memory capacity and density, the probability of
> memory error increases. The increasing size and density of server RAM
> in the data center and cloud have shown increased uncorrectable memory
> errors.
>
> Currently, the kernel has a mechanism to recover from hardware memory
> errors. This patchset provides an new recovery mechanism.
>
> For arm64, the hardware memory error handling is do_sea() which divided
> into two cases:
> 1. The user state consumed the memory errors, the solution is kill the
> user process and isolate the error page.
> 2. The kernel state consumed the memory errors, the solution is panic.
>
> For case 2, Undifferentiated panic maybe not the optimal choice, it can be
> handled better, in some scenarios, we can avoid panic, such as uaccess, if the
> uaccess fails due to memory error, only the user process will be affected,
> kill the user process and isolate the user page with hardware memory errors
> is a better choice.
>
> This patchset can be divided into two parts:
> 1. Patch 1~6 - do some restructuring to arm64 extable.
> 2. Patch 7~10 - arm64 add support for machine check safe framework,
> then ,add two specific scenarios(uaccess/cow) to machine check safe.
It's a good to see more RAS feature on arm64, and we do meet some panic
during copy_from/to_user and CoW processing in our production, for series,
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Since V5:
> 1. Add patch2/3 to add uaccess assembly helpers.
> 2. Optimize the implementation logic of arm64_do_kernel_sea() in patch8.
> 3. Remove kernel access fixup in patch9.
> All suggestion are from Mark.
>
> Since V4:
> 1. According Michael's suggestion, add patch5.
> 2. According Mark's suggestiog, do some restructuring to arm64
> extable, then a new adaptation of machine check safe support is made based
> on this.
> 3. According Mark's suggestion, support machine check safe in do_mte() in
> cow scene.
> 4. In V4, two patches have been merged into -next, so V5 not send these
> two patches.
>
> Since V3:
> 1. According to Robin's suggestion, direct modify user_ldst and
> user_ldp in asm-uaccess.h and modify mte.S.
> 2. Add new macro USER_MC in asm-uaccess.h, used in copy_from_user.S
> and copy_to_user.S.
> 3. According to Robin's suggestion, using micro in copy_page_mc.S to
> simplify code.
> 4. According to KeFeng's suggestion, modify powerpc code in patch1.
> 5. According to KeFeng's suggestion, modify mm/extable.c and some code
> optimization.
>
> Since V2:
> 1. According to Mark's suggestion, all uaccess can be recovered due to
> memory error.
> 2. Scenario pagecache reading is also supported as part of uaccess
> (copy_to_user()) and duplication code problem is also solved.
> Thanks for Robin's suggestion.
> 3. According Mark's suggestion, update commit message of patch 2/5.
> 4. According Borisllav's suggestion, update commit message of patch 1/5.
>
> Since V1:
> 1.Consistent with PPC/x86, Using CONFIG_ARCH_HAS_COPY_MC instead of
> ARM64_UCE_KERNEL_RECOVERY.
> 2.Add two new scenes, cow and pagecache reading.
> 3.Fix two small bug(the first two patch).
>
> V1 in here:
> https://lore.kernel.org/lkml/20220323033705.3966643-1-tongtiangen@huawei.com/
>
> Tong Tiangen (10):
> arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support
> arm64: asm-extable: move data fields
> arm64: asm-extable: add asm uacess helpers
> arm64: extable: make uaaccess helper use extable type
> EX_TYPE_UACCESS_ERR_ZERO
> arm64: extable: move _cond_extable to _cond_uaccess_extable
> arm64: extable: cleanup redundant extable type EX_TYPE_FIXUP
> Add generic fallback version of copy_mc_to_user()
> arm64: add support for machine check error safe
> arm64: add uaccess to machine check safe
> arm64: add cow to machine check safe
>
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/asm-extable.h | 84 ++++++++++++++++++-------
> arch/arm64/include/asm/asm-uaccess.h | 12 ++--
> arch/arm64/include/asm/assembler.h | 8 ++-
> arch/arm64/include/asm/extable.h | 1 +
> arch/arm64/include/asm/mte.h | 4 ++
> arch/arm64/include/asm/page.h | 10 +++
> arch/arm64/include/asm/uaccess.h | 94 ++++++++++++++--------------
> arch/arm64/lib/Makefile | 2 +
> arch/arm64/lib/copy_page_mc.S | 82 ++++++++++++++++++++++++
> arch/arm64/lib/mte.S | 19 ++++++
> arch/arm64/mm/copypage.c | 41 +++++++++---
> arch/arm64/mm/extable.c | 21 ++++++-
> arch/arm64/mm/fault.c | 29 ++++++++-
> arch/powerpc/include/asm/uaccess.h | 1 +
> arch/x86/include/asm/uaccess.h | 1 +
> include/linux/highmem.h | 8 +++
> include/linux/uaccess.h | 9 +++
> mm/memory.c | 2 +-
> 19 files changed, 339 insertions(+), 90 deletions(-)
> create mode 100644 arch/arm64/lib/copy_page_mc.S
>
next prev parent reply other threads:[~2022-06-28 11:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 7:26 [PATCH -next v6 00/10]arm64: add machine check safe support Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 01/10] arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 02/10] arm64: asm-extable: move data fields Tong Tiangen
2022-06-28 11:15 ` Will Deacon
2022-06-21 7:26 ` [PATCH -next v6 03/10] arm64: asm-extable: add asm uacess helpers Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 04/10] arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 05/10] arm64: extable: move _cond_extable to _cond_uaccess_extable Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 06/10] arm64: extable: cleanup redundant extable type EX_TYPE_FIXUP Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 07/10] Add generic fallback version of copy_mc_to_user() Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 08/10] arm64: add support for machine check error safe Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 09/10] arm64: add uaccess to machine check safe Tong Tiangen
2022-06-21 7:26 ` [PATCH -next v6 10/10] arm64: add cow " Tong Tiangen
2022-06-28 11:17 ` Kefeng Wang [this message]
2022-06-28 12:30 ` [PATCH -next v6 00/10]arm64: add machine check safe support Tong Tiangen
2022-06-28 17:02 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e574b4-3191-8c0f-1dc3-7c54c426142c@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=guohanjun@huawei.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=tongtiangen@huawei.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).