From: Tony Chuang <yhchuang@realtek.com>
To: Dejin Zheng <zhengdejin5@gmail.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"sgruszka@redhat.com" <sgruszka@redhat.com>,
"briannorris@chromium.org" <briannorris@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources
Date: Mon, 4 May 2020 08:37:15 +0000 [thread overview]
Message-ID: <88e6cc654a73472f9591fb0c6b74f768@realtek.com> (raw)
In-Reply-To: <20200504083442.3033-1-zhengdejin5@gmail.com>
> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources
>
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
>
> Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw88/pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c
> b/drivers/net/wireless/realtek/rtw88/pci.c
> index 695c2c0d64b0..a9752c34c9d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev
> *rtwdev,
> len = pci_resource_len(pdev, bar_id);
> rtwpci->mmap = pci_iomap(pdev, bar_id, len);
> if (!rtwpci->mmap) {
> + pci_release_regions(pdev);
> rtw_err(rtwdev, "failed to map pci memory\n");
> return -ENOMEM;
> }
> --
> 2.25.0
next prev parent reply other threads:[~2020-05-04 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:34 [PATCH net v1] net: rtw88: fix an issue about leak system resources Dejin Zheng
2020-05-04 8:37 ` Tony Chuang [this message]
2020-05-06 8:38 ` [PATCH net v1] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e6cc654a73472f9591fb0c6b74f768@realtek.com \
--to=yhchuang@realtek.com \
--cc=andy.shevchenko@gmail.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).