From: YueHaibing <yuehaibing@huawei.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Oliver O'Halloran <oohall@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings
Date: Mon, 18 Feb 2019 21:21:11 +0800 [thread overview]
Message-ID: <88ec8c6a-68ac-a96c-0a82-b2537fc699f2@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1902181353150.3532@hadrien>
On 2019/2/18 20:53, Julia Lawall wrote:
>
>
> On Mon, 18 Feb 2019, YueHaibing wrote:
>
>> Remove .owner field if calls are used which set it automatically
>> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> arch/powerpc/platforms/pseries/papr_scm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
>> index bba281b1fe1b..e3f5c1a01950 100644
>> --- a/arch/powerpc/platforms/pseries/papr_scm.c
>> +++ b/arch/powerpc/platforms/pseries/papr_scm.c
>> @@ -21,6 +21,7 @@
>> (1ul << ND_CMD_GET_CONFIG_DATA) | \
>> (1ul << ND_CMD_SET_CONFIG_DATA))
>>
>> +
>
> No need to add a blank line.
Yes, will fix it.
>
> julia
>
>> struct papr_scm_priv {
>> struct platform_device *pdev;
>> struct device_node *dn;
>> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = {
>> .remove = papr_scm_remove,
>> .driver = {
>> .name = "papr_scm",
>> - .owner = THIS_MODULE,
>> .of_match_table = papr_scm_match,
>> },
>> };
>>
>>
>>
>>
>
> .
>
next prev parent reply other threads:[~2019-02-18 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 12:59 [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings YueHaibing
2019-02-18 12:53 ` Julia Lawall
2019-02-18 13:21 ` YueHaibing [this message]
2019-02-18 13:39 ` [PATCH v2 " YueHaibing
2019-11-14 9:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ec8c6a-68ac-a96c-0a82-b2537fc699f2@huawei.com \
--to=yuehaibing@huawei.com \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).