From: Bart Van Assche <bvanassche@acm.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
axboe@kernel.dk, viro@zeniv.linux.org.uk,
gregkh@linuxfoundation.org, rostedt@goodmis.org,
mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com,
nstange@suse.de, akpm@linux-foundation.org
Cc: mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Hannes Reinecke <hare@suse.com>, Michal Hocko <mhocko@kernel.org>,
syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com
Subject: Re: [RFC v2 2/5] blktrace: fix debugfs use after free
Date: Thu, 9 Apr 2020 19:52:59 -0700 [thread overview]
Message-ID: <88f94070-cd34-7435-9175-e0518a7d7db8@acm.org> (raw)
In-Reply-To: <20200409214530.2413-3-mcgrof@kernel.org>
On 2020-04-09 14:45, Luis Chamberlain wrote:
> +void blk_q_debugfs_register(struct request_queue *q)
> +{
> + q->debugfs_dir = debugfs_create_dir(kobject_name(q->kobj.parent),
> + blk_debugfs_root);
> +}
> +
> +void blk_q_debugfs_unregister(struct request_queue *q)
> +{
> + debugfs_remove_recursive(q->debugfs_dir);
> + q->debugfs_dir = NULL;
> +}
There are no other functions in the block layer that start with the
prefix blk_q_. How about changing that prefix into blk_?
> -#ifdef CONFIG_BLK_DEBUG_FS
> +#ifdef CONFIG_DEBUG_FS
> struct dentry *debugfs_dir;
> +#endif
Please add a comment above 'debugfs_dir' that it is used not only by the
code in block/blk-*debugfs.c but also by the code in
kernel/trace/blktrace.c. Otherwise this patch looks good to me.
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-10 2:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 21:45 [RFC v2 0/5] blktrace: fix use after free Luis Chamberlain
2020-04-09 21:45 ` [RFC v2 1/5] block: move main block debugfs initialization to its own file Luis Chamberlain
2020-04-10 2:48 ` Bart Van Assche
2020-04-09 21:45 ` [RFC v2 2/5] blktrace: fix debugfs use after free Luis Chamberlain
2020-04-10 2:52 ` Bart Van Assche [this message]
2020-04-10 19:58 ` Luis Chamberlain
2020-04-11 23:09 ` Bart Van Assche
2020-04-14 3:32 ` Luis Chamberlain
2020-04-09 21:45 ` [RFC v2 3/5] blktrace: ref count the request_queue during ioctl Luis Chamberlain
2020-04-10 2:58 ` Bart Van Assche
2020-04-09 21:45 ` [RFC v2 4/5] mm/swapfile: refcount block and queue before using blkcg_schedule_throttle() Luis Chamberlain
2020-04-10 3:02 ` Bart Van Assche
2020-04-10 14:34 ` Luis Chamberlain
2020-04-09 21:45 ` [RFC v2 5/5] block: revert back to synchronous request_queue removal Luis Chamberlain
2020-04-10 3:12 ` Bart Van Assche
2020-04-10 14:34 ` Luis Chamberlain
2020-04-10 20:50 ` Luis Chamberlain
2020-04-10 21:27 ` Luis Chamberlain
2020-04-11 23:21 ` Bart Van Assche
2020-04-14 3:38 ` Luis Chamberlain
2020-04-10 19:37 [RFC v2 2/5] blktrace: fix debugfs use after free Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88f94070-cd34-7435-9175-e0518a7d7db8@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=nstange@suse.de \
--cc=osandov@fb.com \
--cc=rostedt@goodmis.org \
--cc=syzbot+603294af2d01acfdd6da@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).