From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Perry Yuan <Perry.Yuan@amd.com>,
rafael.j.wysocki@intel.com, ray.huang@amd.com,
viresh.kumar@linaro.org
Cc: Deepak.Sharma@amd.com, Nathan.Fontenot@amd.com,
Alexander.Deucher@amd.com, Shimmer.Huang@amd.com,
Xiaojian.Du@amd.com, Li.Meng@amd.com, wyes.karny@amd.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 7/9] cpufreq: amd-pstate: add frequency dynamic boost sysfs control
Date: Mon, 14 Nov 2022 16:30:28 -0600 [thread overview]
Message-ID: <8901dfd7-cdf4-1f1d-5d34-be57e74112de@amd.com> (raw)
In-Reply-To: <20221110175847.3098728-8-Perry.Yuan@amd.com>
On 11/10/2022 11:58, Perry Yuan wrote:
> Add one sysfs entry to control the CPU cores frequency boost state
> The attribute file can allow user to set max performance boosted or
> keeping at normal perf level.
>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 66 ++++++++++++++++++++++++++++++++++--
> 1 file changed, 64 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 645706d65173..b71bfbbb7639 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -765,12 +765,46 @@ static ssize_t show_energy_performance_preference(
> return sprintf(buf, "%s\n", energy_perf_strings[preference]);
> }
>
> +static void amd_pstate_update_policies(void)
> +{
> + int cpu;
> +
> + for_each_possible_cpu(cpu)
> + cpufreq_update_policy(cpu);
> +}
> +
> +static ssize_t show_boost(struct kobject *kobj,
> + struct kobj_attribute *attr, char *buf)
> +{
> + return sprintf(buf, "%u\n", cppc_boost);
For new code I believe you should use the new helper sysfs_emit() instead.
> +}
> +
> +static ssize_t store_boost(struct kobject *a,
> + struct kobj_attribute *b,
> + const char *buf, size_t count)
> +{
> + bool new_state;
> + int ret;
> +
> + ret = kstrtobool(buf, &new_state);
> + if (ret)
> + return -EINVAL;
> +
> + mutex_lock(&amd_pstate_driver_lock);
> + cppc_boost = !!new_state;
> + amd_pstate_update_policies();
> + mutex_unlock(&amd_pstate_driver_lock);
> +
> + return count;
> +}
> +
> cpufreq_freq_attr_ro(amd_pstate_max_freq);
> cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>
> cpufreq_freq_attr_ro(amd_pstate_highest_perf);
> cpufreq_freq_attr_rw(energy_performance_preference);
> cpufreq_freq_attr_ro(energy_performance_available_preferences);
> +define_one_global_rw(boost);
>
> static struct freq_attr *amd_pstate_attr[] = {
> &amd_pstate_max_freq,
> @@ -788,6 +822,15 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
> NULL,
> };
>
> +static struct attribute *pstate_global_attributes[] = {
> + &boost.attr,
> + NULL
> +};
> +
> +static const struct attribute_group amd_pstate_global_attr_group = {
> + .attrs = pstate_global_attributes,
> +};
> +
> static inline void update_boost_state(void)
> {
> u64 misc_en;
> @@ -1398,9 +1441,28 @@ static int __init amd_pstate_init(void)
>
> ret = cpufreq_register_driver(default_pstate_driver);
> if (ret)
> - pr_err("failed to register amd pstate driver with return %d\n",
> - ret);
> + pr_err("failed to register driver with return %d\n", ret);
> +
> + amd_pstate_kobj = kobject_create_and_add("amd-pstate", &cpu_subsys.dev_root->kobj);
> + if (!amd_pstate_kobj) {
> + ret = -EINVAL;
> + pr_err("global sysfs registration failed.\n");
> + goto kobject_free;
> + }
> +
> + ret = sysfs_create_group(amd_pstate_kobj, &amd_pstate_global_attr_group);
> + if (ret) {
> + pr_err("sysfs attribute export failed with error %d.\n", ret);
> + goto global_attr_free;
> + }
> +
> + return ret;
>
> +global_attr_free:
> + kobject_put(amd_pstate_kobj);
> +kobject_free:
> + kfree(cpudata);
> + cpufreq_unregister_driver(default_pstate_driver);
> return ret;
> }
> device_initcall(amd_pstate_init);
next prev parent reply other threads:[~2022-11-14 22:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 17:58 [PATCH v4 0/9] Implement AMD Pstate EPP Driver Perry Yuan
2022-11-10 17:58 ` [PATCH v4 1/9] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-11-10 17:58 ` [PATCH v4 2/9] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-11-10 17:58 ` [PATCH v4 3/9] cpufreq: amd-pstate: change amd-pstate driver to be built-in type Perry Yuan
2022-11-14 22:46 ` Limonciello, Mario
2022-11-15 2:02 ` Yuan, Perry
2022-11-10 17:58 ` [PATCH v4 4/9] cpufreq: amd_pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2022-11-14 22:40 ` Limonciello, Mario
2022-11-30 17:12 ` Yuan, Perry
2022-12-02 8:18 ` Yuan, Perry
2022-11-17 14:02 ` Wyes Karny
2022-11-18 3:54 ` Yuan, Perry
2022-11-10 17:58 ` [PATCH v4 5/9] cpufreq: amd_pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-11-10 17:58 ` [PATCH v4 6/9] cpufreq: amd-pstate: implement suspend and resume callbacks Perry Yuan
2022-11-10 17:58 ` [PATCH v4 7/9] cpufreq: amd-pstate: add frequency dynamic boost sysfs control Perry Yuan
2022-11-14 22:30 ` Limonciello, Mario [this message]
2022-11-30 17:13 ` Yuan, Perry
2022-11-10 17:58 ` [PATCH v4 8/9] cpufreq: amd_pstate: add driver working mode status sysfs entry Perry Yuan
2022-11-14 22:30 ` Limonciello, Mario
2022-11-30 17:13 ` Yuan, Perry
2022-11-10 17:58 ` [PATCH v4 9/9] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-11-14 22:29 ` Limonciello, Mario
2022-12-02 8:20 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8901dfd7-cdf4-1f1d-5d34-be57e74112de@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Li.Meng@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).