From: Bart Van Assche <bvanassche@acm.org>
To: Asutosh Das <quic_asutoshd@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: quic_cang@quicinc.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, quic_nguyenb@quicinc.com,
quic_xiaosenh@quicinc.com, stanley.chu@mediatek.com,
eddie.huang@mediatek.com, daejun7.park@samsung.com,
avri.altman@wdc.com, beanhuo@micron.com,
linux-arm-msm@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Jinyoung Choi <j-young.choi@samsung.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>,
Kiwoong Kim <kwmad.kim@samsung.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 07/16] ufs: core: mcq: Calculate queue depth
Date: Mon, 28 Nov 2022 12:33:03 -0800 [thread overview]
Message-ID: <89037602-f09a-f0da-69f7-f6aae72acc76@acm.org> (raw)
In-Reply-To: <20221128195430.GD20677@asutoshd-linux1.qualcomm.com>
On 11/28/22 11:54, Asutosh Das wrote:
> On Mon, Nov 28 2022 at 07:15 -0800, Manivannan Sadhasivam wrote:
>> On Tue, Nov 22, 2022 at 08:10:20PM -0800, Asutosh Das wrote:
>>> +static inline int ufshcd_mcq_vops_get_hba_mac(struct ufs_hba *hba)
>>
>> Again, no inline please.
>>
> It spits out the following warning for all files that include this
> header, when
> inline is removed:
> warning: 'ufshcd_mcq_vops_get_hba_mac' defined but not used
> [-Wunused-function]
My understanding is that the "no inline" rule applies to .c files only
and also that functions defined in header files should be declared
"static inline".
Thanks,
Bart.
next prev parent reply other threads:[~2022-11-28 20:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1669176158.git.quic_asutoshd@quicinc.com>
2022-11-23 4:10 ` [PATCH v5 01/16] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-11-28 12:20 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-11-28 12:53 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 03/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-11-26 0:20 ` Bart Van Assche
2022-11-28 14:29 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-11-26 0:28 ` Bart Van Assche
2022-11-28 14:42 ` Manivannan Sadhasivam
2022-11-28 17:50 ` Asutosh Das
2022-11-23 4:10 ` [PATCH v5 05/16] ufs: core: mcq: Add Multi Circular Queue support Asutosh Das
2022-11-26 0:52 ` Bart Van Assche
2022-11-28 14:53 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-11-26 1:10 ` Bart Van Assche
2022-11-23 4:10 ` [PATCH v5 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-11-26 1:14 ` Bart Van Assche
2022-11-28 15:15 ` Manivannan Sadhasivam
2022-11-28 19:54 ` Asutosh Das
2022-11-28 20:33 ` Bart Van Assche [this message]
2022-11-23 4:10 ` [PATCH v5 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-11-26 1:20 ` Bart Van Assche
2022-11-28 15:48 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-11-26 1:28 ` Bart Van Assche
2022-11-28 22:08 ` Asutosh Das
2022-11-28 22:50 ` Bart Van Assche
2022-11-28 15:55 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 10/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-11-28 15:59 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-11-28 16:05 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-11-28 16:08 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-11-28 16:11 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-11-28 17:00 ` Manivannan Sadhasivam
2022-11-28 17:47 ` Bart Van Assche
2022-11-23 4:10 ` [PATCH v5 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-11-28 17:02 ` Manivannan Sadhasivam
2022-11-23 4:10 ` [PATCH v5 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-11-28 17:03 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89037602-f09a-f0da-69f7-f6aae72acc76@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=daejun7.park@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=j-young.choi@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@somainline.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).