From: "Ju, Seokmann" <Seokmann.Ju@lsil.com>
To: "Daniel Walker" <dwalker@mvista.com>, <akpm@osdl.org>
Cc: <alan@lxorguk.ukuu.org.uk>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -mm] updated megaraid gcc 4.1 warning fix
Date: Thu, 11 May 2006 07:17:53 -0600 [thread overview]
Message-ID: <890BF3111FB9484E9526987D912B261901BD64@NAMAIL3.ad.lsil.com> (raw)
Hi,
Wednesday, May 10, 2006 1:27 PM, Daniel Walker wrote:
> drivers/scsi/megaraid.c: In function âEUR~megadev_ioctlâEUR(tm):
> drivers/scsi/megaraid.c:3665: warning: ignoring return value
> of âEUR~copy_to_userâEUR(tm), declared with attribute warn_unused_result
Thank you for the patch.
I accept the patch.
> -----Original Message-----
> From: Daniel Walker [mailto:dwalker@mvista.com]
> Sent: Wednesday, May 10, 2006 1:27 PM
> To: akpm@osdl.org
> Cc: Ju, Seokmann; alan@lxorguk.ukuu.org.uk;
> linux-kernel@vger.kernel.org
> Subject: [PATCH -mm] updated megaraid gcc 4.1 warning fix
>
> Hows that Alan?
>
> Fixes the following warning,
>
> drivers/scsi/megaraid.c: In function âEUR~megadev_ioctlâEUR(tm):
> drivers/scsi/megaraid.c:3665: warning: ignoring return value
> of âEUR~copy_to_userâEUR(tm), declared with attribute warn_unused_result
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
>
> Index: linux-2.6.16/drivers/scsi/megaraid.c
> ===================================================================
> --- linux-2.6.16.orig/drivers/scsi/megaraid.c
> +++ linux-2.6.16/drivers/scsi/megaraid.c
> @@ -3662,8 +3662,9 @@ megadev_ioctl(struct inode *inode, struc
> * Send the request sense data also,
> irrespective of
> * whether the user has asked for it or not.
> */
> - copy_to_user(upthru->reqsensearea,
> - pthru->reqsensearea, 14);
> + if (copy_to_user(upthru->reqsensearea,
> + pthru->reqsensearea, 14))
> + rval = (-EFAULT);
>
> freemem_and_return:
> if( pthru->dataxferlen ) {
>
next reply other threads:[~2006-05-11 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-11 13:17 Ju, Seokmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-10 17:26 [PATCH -mm] updated megaraid gcc 4.1 warning fix Daniel Walker
2006-05-11 13:12 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=890BF3111FB9484E9526987D912B261901BD64@NAMAIL3.ad.lsil.com \
--to=seokmann.ju@lsil.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).