From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF53C00A89 for ; Fri, 30 Oct 2020 10:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146252224E for ; Fri, 30 Oct 2020 10:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbgJ3KzT (ORCPT ); Fri, 30 Oct 2020 06:55:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgJ3KzS (ORCPT ); Fri, 30 Oct 2020 06:55:18 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6133DC0613CF for ; Fri, 30 Oct 2020 03:55:18 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 9783A1F45E6C From: Enric Balletbo i Serra Subject: Re: [PATCH v3 04/16] soc: mediatek: pm-domains: Add bus protection protocol To: Weiyi Lu Cc: linux-kernel@vger.kernel.org, matthias.bgg@gmail.com, drinkcat@chromium.org, hsinyi@chromium.org, Collabora Kernel ML , fparent@baylibre.com, Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20201026175526.2915399-1-enric.balletbo@collabora.com> <20201026175526.2915399-5-enric.balletbo@collabora.com> <1603796869.16422.2.camel@mtksdaap41> Message-ID: <891af5b7-42e1-3d52-b2b6-45139a92ec1a@collabora.com> Date: Fri, 30 Oct 2020 11:55:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1603796869.16422.2.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Weiyi Lu, Many thanks for your comments. On 27/10/20 12:07, Weiyi Lu wrote: > On Mon, 2020-10-26 at 18:55 +0100, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> Bus protection will need to update more then one register >> in infracfg. Add support for several operations. >> >> Signed-off-by: Matthias Brugger >> Signed-off-by: Enric Balletbo i Serra >> --- >> >> Changes in v3: None >> Changes in v2: None >> >> drivers/soc/mediatek/mt8173-pm-domains.h | 4 +-- >> drivers/soc/mediatek/mtk-pm-domains.c | 36 +++++++++++++++++------- >> drivers/soc/mediatek/mtk-pm-domains.h | 4 ++- >> 3 files changed, 31 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/soc/mediatek/mt8173-pm-domains.h >> index a2a624bbd8b8..341cc287c8ce 100644 >> --- a/drivers/soc/mediatek/mt8173-pm-domains.h >> +++ b/drivers/soc/mediatek/mt8173-pm-domains.h >> @@ -34,7 +34,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8173[] = { >> .ctl_offs = SPM_DIS_PWR_CON, >> .sram_pdn_bits = GENMASK(11, 8), >> .sram_pdn_ack_bits = GENMASK(12, 12), >> - .bp_infracfg = { >> + .bp_infracfg[0] = { >> .bus_prot_reg_update = true, >> .bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MM_M0 | >> MT8173_TOP_AXI_PROT_EN_MM_M1, >> @@ -76,7 +76,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8173[] = { >> .ctl_offs = SPM_MFG_PWR_CON, >> .sram_pdn_bits = GENMASK(13, 8), >> .sram_pdn_ack_bits = GENMASK(21, 16), >> - .bp_infracfg = { >> + .bp_infracfg[0] = { >> .bus_prot_reg_update = true, >> .bus_prot_mask = MT8173_TOP_AXI_PROT_EN_MFG_S | >> MT8173_TOP_AXI_PROT_EN_MFG_M0 | >> diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c >> index 16503d6db6a8..2121e05cb9a4 100644 >> --- a/drivers/soc/mediatek/mtk-pm-domains.c >> +++ b/drivers/soc/mediatek/mtk-pm-domains.c >> @@ -89,24 +89,40 @@ static int scpsys_sram_disable(struct scpsys_domain *pd) >> >> static int scpsys_bus_protect_enable(struct scpsys_domain *pd) >> { >> - const struct scpsys_bus_prot_data *bp_data = &pd->data->bp_infracfg; >> + const struct scpsys_bus_prot_data *bpd = pd->data->bp_infracfg; >> + int i, ret; >> >> - if (!bp_data->bus_prot_mask) >> - return 0; >> + for (i = 0; i < SPM_MAX_BUS_PROT_DATA; i++) { >> + if (!bpd[i].bus_prot_mask) >> + break; >> >> - return mtk_infracfg_set_bus_protection(pd->infracfg, bp_data->bus_prot_mask, >> - bp_data->bus_prot_reg_update); >> + ret = mtk_infracfg_set_bus_protection(pd->infracfg, >> + bpd[i].bus_prot_mask, >> + bpd[i].bus_prot_reg_update); >> + if (ret) >> + return ret; >> + } >> + >> + return 0; >> } >> >> static int scpsys_bus_protect_disable(struct scpsys_domain *pd) >> { >> - const struct scpsys_bus_prot_data *bp_data = &pd->data->bp_infracfg; >> + const struct scpsys_bus_prot_data *bpd = pd->data->bp_infracfg; >> + int i, ret; >> >> - if (!bp_data->bus_prot_mask) >> - return 0; >> + for (i = 0; i < SPM_MAX_BUS_PROT_DATA; i++) { > > I thought it should be > > for (i = SPM_MAX_BUS_PROT_DATA - 1; i > 0; i--) { > if (!bpd[i].bus_prot_mask) > continue; > Done. > ... > >> + if (!bpd[i].bus_prot_mask) >> + return 0; >> >> - return mtk_infracfg_clear_bus_protection(pd->infracfg, bp_data->bus_prot_mask, >> - bp_data->bus_prot_reg_update); >> + ret = mtk_infracfg_clear_bus_protection(pd->infracfg, >> + bpd[i].bus_prot_mask, >> + bpd[i].bus_prot_reg_update); >> + if (ret) >> + return ret; >> + } >> + >> + return 0; >> } >> >> static int scpsys_power_on(struct generic_pm_domain *genpd) >> diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h >> index 7c8efcb3cef2..e428fe23a7e3 100644 >> --- a/drivers/soc/mediatek/mtk-pm-domains.h >> +++ b/drivers/soc/mediatek/mtk-pm-domains.h >> @@ -32,6 +32,8 @@ >> #define PWR_STATUS_AUDIO BIT(24) >> #define PWR_STATUS_USB BIT(25) >> >> +#define SPM_MAX_BUS_PROT_DATA 3 >> + > > #define SPM_MAX_BUS_PROT_DATA 5 > > to be compatible with MT8192 > Done. >> struct scpsys_bus_prot_data { >> u32 bus_prot_mask; >> bool bus_prot_reg_update; >> @@ -52,7 +54,7 @@ struct scpsys_domain_data { >> u32 sram_pdn_bits; >> u32 sram_pdn_ack_bits; >> u8 caps; >> - const struct scpsys_bus_prot_data bp_infracfg; >> + const struct scpsys_bus_prot_data bp_infracfg[SPM_MAX_BUS_PROT_DATA]; >> }; >> >> struct scpsys_soc_data { >