From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Conor.Dooley@microchip.com, mail@conchuod.ie, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
sam@ravnborg.org, Eugeniy.Paltsev@synopsys.com, vkoul@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org, fancer.lancer@gmail.com,
daniel.lezcano@linaro.org, palmer@dabbelt.com,
palmer@rivosinc.com
Cc: tglx@linutronix.de, paul.walmsley@sifive.com,
aou@eecs.berkeley.edu, masahiroy@kernel.org,
geert@linux-m68k.org, niklas.cassel@wdc.com,
dillon.minfei@gmail.com, jee.heng.sia@intel.com,
joabreu@synopsys.com, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, alsa-devel@alsa-project.org,
linux-spi@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node
Date: Mon, 20 Jun 2022 09:25:38 +0900 [thread overview]
Message-ID: <891cf74c-ac0a-b380-1d5f-dd7ce5aeda9d@opensource.wdc.com> (raw)
In-Reply-To: <e1fbf363-d057-1000-a846-3df524801f15@microchip.com>
On 6/20/22 08:54, Conor.Dooley@microchip.com wrote:
> On 20/06/2022 00:38, Damien Le Moal wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 6/18/22 21:30, Conor Dooley wrote:
>>> From: Conor Dooley <conor.dooley@microchip.com>
>>>
>>> The k210 memory node has a compatible string that does not match with
>>> any driver or dt-binding & has several non standard properties.
>>> Replace the reg names with a comment and delete the rest.
>>>
>>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>>> ---
>>> ---
>>> arch/riscv/boot/dts/canaan/k210.dtsi | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi
>>> index 44d338514761..287ea6eebe47 100644
>>> --- a/arch/riscv/boot/dts/canaan/k210.dtsi
>>> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi
>>> @@ -69,15 +69,9 @@ cpu1_intc: interrupt-controller {
>>>
>>> sram: memory@80000000 {
>>> device_type = "memory";
>>> - compatible = "canaan,k210-sram";
>>> reg = <0x80000000 0x400000>,
>>> <0x80400000 0x200000>,
>>> <0x80600000 0x200000>;
>>> - reg-names = "sram0", "sram1", "aisram";
>>> - clocks = <&sysclk K210_CLK_SRAM0>,
>>> - <&sysclk K210_CLK_SRAM1>,
>>> - <&sysclk K210_CLK_AI>;
>>> - clock-names = "sram0", "sram1", "aisram";
>>> };
>>
>> These are used by u-boot to setup the memory clocks and initialize the
>> aisram. Sure the kernel actually does not use this, but to be in sync with
>> u-boot DT, I would prefer keeping this as is. Right now, u-boot *and* the
>> kernel work fine with both u-boot internal DT and the kernel DT.
>
> Right, but unfortunately that desire alone doesn't do anything about
> the dtbs_check complaints.
>
> I guess the alternative approach of actually documenting the compatible
> would be more palatable?
Yes, I think so. That would allow keeping the fields without the DTB build
warnings.
>
> Thanks,
> Conor.
>
>
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-06-20 0:25 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 12:30 [PATCH 00/14] Canaan devicetree fixes Conor Dooley
2022-06-18 12:30 ` [PATCH 01/14] dt-bindings: display: convert ilitek,ili9341.txt to dt-schema Conor Dooley
2022-06-27 23:20 ` Rob Herring
2022-06-18 12:30 ` [PATCH 02/14] dt-bindings: display: panel: allow ilitek,ili9341 in isolation Conor Dooley
2022-06-27 23:17 ` Rob Herring
2022-06-28 6:26 ` Conor.Dooley
2022-06-18 12:30 ` [PATCH 03/14] ASoC: dt-bindings: convert designware-i2s to dt-schema Conor Dooley
2022-06-27 23:22 ` Rob Herring
2022-06-18 12:30 ` [PATCH 04/14] dt-bindings: dma: add Canaan k210 to Synopsys DesignWare DMA Conor Dooley
2022-06-27 23:29 ` Rob Herring
2022-06-28 6:30 ` Conor.Dooley
2022-06-28 7:08 ` Geert Uytterhoeven
2022-06-28 7:13 ` Conor.Dooley
2022-06-28 11:04 ` Serge Semin
2022-06-18 12:30 ` [PATCH 05/14] dt-bindings: timer: add Canaan k210 to Synopsys DesignWare timer Conor Dooley
2022-06-27 23:30 ` Rob Herring
2022-06-28 11:06 ` Serge Semin
2022-06-18 12:30 ` [PATCH 06/14] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width for dwc-ssi Conor Dooley
2022-06-20 8:02 ` Geert Uytterhoeven
2022-06-20 8:47 ` Conor.Dooley
2022-06-20 20:56 ` Serge Semin
2022-06-20 21:06 ` Conor.Dooley
2022-06-20 22:46 ` Damien Le Moal
2022-06-20 22:49 ` Conor Dooley
2022-06-20 23:17 ` Damien Le Moal
2022-06-21 16:06 ` Conor.Dooley
2022-06-23 10:25 ` Serge Semin
2022-06-23 12:41 ` Conor Dooley
2022-06-27 17:15 ` Rob Herring
2022-06-27 18:05 ` Conor.Dooley
2022-06-21 7:03 ` Geert Uytterhoeven
2022-06-21 9:32 ` Serge Semin
2022-06-18 12:30 ` [PATCH 07/14] riscv: dts: canaan: fix the k210's memory node Conor Dooley
2022-06-18 12:35 ` Conor.Dooley
2022-06-19 23:38 ` Damien Le Moal
2022-06-19 23:54 ` Conor.Dooley
2022-06-20 0:25 ` Damien Le Moal [this message]
2022-06-21 9:49 ` Conor.Dooley
2022-06-27 6:55 ` Krzysztof Kozlowski
2022-06-27 7:06 ` Conor.Dooley
2022-06-27 9:24 ` Krzysztof Kozlowski
2022-06-27 11:03 ` Conor.Dooley
2022-06-18 12:30 ` [PATCH 08/14] riscv: dts: canaan: add a specific compatible for k210's dma Conor Dooley
2022-06-18 12:30 ` [PATCH 09/14] riscv: dts: canaan: add a specific compatible for k210's timers Conor Dooley
2022-06-18 12:30 ` [PATCH 10/14] riscv: dts: canaan: fix mmc node names Conor Dooley
2022-06-18 12:30 ` [PATCH 11/14] riscv: dts: canaan: fix kd233 display spi frequency Conor Dooley
2022-06-18 12:30 ` [PATCH 12/14] riscv: dts: canaan: use custom compatible for k210 i2s Conor Dooley
2022-06-18 12:30 ` [PATCH 13/14] riscv: dts: canaan: remove spi-max-frequency from controllers Conor Dooley
2022-06-18 12:30 ` [PATCH 14/14] riscv: dts: canaan: build all devicetress if SOC_CANAAN Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891cf74c-ac0a-b380-1d5f-dd7ce5aeda9d@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=Conor.Dooley@microchip.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fancer.lancer@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jee.heng.sia@intel.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@conchuod.ie \
--cc=masahiroy@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).