From: Taniya Das <tdas@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>, Rajendra Nayak <rnayak@codeaurora.org>
Cc: agross@kernel.org, robh+dt@kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
Date: Wed, 16 Oct 2019 13:22:55 +0530 [thread overview]
Message-ID: <89225569-1cd3-ae0e-94ed-bbb2b3dd8e9c@codeaurora.org> (raw)
In-Reply-To: <20191016052535.GC2654@vkoul-mobl>
Hi Vinod,
On 10/16/2019 10:55 AM, Vinod Koul wrote:
> On 15-10-19, 16:03, Rajendra Nayak wrote:
>
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
>> + };
>> +
>> + clocks {
>
> Can we have these sorted alphabetically please
>
>> + xo_board: xo-board {
>> + compatible = "fixed-clock";
>> + clock-frequency = <38400000>;
>> + clock-output-names = "xo_board";
>> + #clock-cells = <0>;
>> + };
>> +
>> + sleep_clk: sleep-clk {
>> + compatible = "fixed-clock";
>> + clock-frequency = <32764>;
>> + clock-output-names = "sleep_clk";
>> + #clock-cells = <0>;
>> + };
>> +
>> + bi_tcxo: bi_tcxo {
>
> why is this a clock defined here? Isnt this gcc clock?
>
This is a RPMH-controlled clock and not from GCC. It is the parent clock
for GCC RCGs/PLLs.
Once the RPMH clock support is added these would be removed.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2019-10-16 7:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 10:33 [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-15 10:33 ` [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-16 5:25 ` Vinod Koul
2019-10-16 7:52 ` Taniya Das [this message]
2019-10-16 8:24 ` Vinod Koul
2019-10-16 10:43 ` Taniya Das
2019-10-16 8:15 ` Rajendra Nayak
2019-10-16 5:21 ` [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89225569-1cd3-ae0e-94ed-bbb2b3dd8e9c@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).