From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81441C48BE5 for ; Fri, 11 Jun 2021 02:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64AB461285 for ; Fri, 11 Jun 2021 02:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231509AbhFKC2q (ORCPT ); Thu, 10 Jun 2021 22:28:46 -0400 Received: from regular1.263xmail.com ([211.150.70.195]:56612 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbhFKC2p (ORCPT ); Thu, 10 Jun 2021 22:28:45 -0400 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id 75F991DAC; Fri, 11 Jun 2021 10:26:37 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [172.16.12.73] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P24500T139649095816960S1623378394803816_; Fri, 11 Jun 2021 10:26:36 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <76434981b7eff221154a68cfe3f38365> X-RL-SENDER: jon.lin@rock-chips.com X-SENDER: jon.lin@rock-chips.com X-LOGIN-NAME: jon.lin@rock-chips.com X-FST-TO: macromorgan@hotmail.com X-RCPT-COUNT: 19 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Subject: Re: [PATCH v7 9/9] arm64: dts: rockchip: Enable SFC for Odroid Go Advance To: Chris Morgan Cc: linux-spi@vger.kernel.org, broonie@kernel.org, robh+dt@kernel.org, heiko@sntech.de, jbx6244@gmail.com, hjc@rock-chips.com, yifeng.zhao@rock-chips.com, sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org, linux-mtd@lists.infradead.org, p.yadav@ti.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, Chris Morgan References: <20210609140412.16058-1-jon.lin@rock-chips.com> <20210609141348.19178-1-jon.lin@rock-chips.com> <20210609141348.19178-5-jon.lin@rock-chips.com> <20210610173657.GA20228@wintermute.localdomain> From: Jon Lin Message-ID: <89283da6-b00e-4d0f-5c4a-0169bda101d3@rock-chips.com> Date: Fri, 11 Jun 2021 10:26:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210610173657.GA20228@wintermute.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris May you attach the XT25F128B device code to me, and I'll try to work it out. On 6/11/21 1:36 AM, Chris Morgan wrote: > On Wed, Jun 09, 2021 at 10:13:48PM +0800, Jon Lin wrote: >> From: Chris Morgan >> >> This enables the Rockchip Serial Flash Controller for the Odroid Go >> Advance. Note that while the attached SPI NOR flash and the controller >> both support quad read mode, only 2 of the required 4 pins are present. >> The rx and tx bus width is set to 2 for this reason. >> >> Signed-off-by: Chris Morgan >> Signed-off-by: Jon Lin >> --- >> >> Changes in v7: None >> Changes in v6: None >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> Changes in v1: None >> >> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts >> index 49c97f76df77..f78e11dd8447 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts >> @@ -484,6 +484,22 @@ >> status = "okay"; >> }; >> >> +&sfc { >> + pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus2>; >> + pinctrl-names = "default"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + status = "okay"; >> + >> + flash@0 { >> + compatible = "jedec,spi-nor"; >> + reg = <0>; >> + spi-max-frequency = <108000000>; >> + spi-rx-bus-width = <2>; >> + spi-tx-bus-width = <2>; > Note that I am still working with Jon Lin to research this, but it was > found in testing that if I set the tx bus width to 1 the problems I > encountered in earlier are resolved. At this time I do not know if it > is an issue with the driver for the flash controller, or if the NOR, or > board itself has some sort of errata which prevent dual tx from working > correctly. Note that as of right now the flash chip I am using (an > XTX XT25F128B) is not currently supported in mainline, so it's very > possible this is some sort of errata with the chip. It's also possible > that there is something with the board that is interferring with dual > mode TX. When Jon comes back that he has tested dual mode on the SFC > with a different board/chip I will recommend that we change the tx > bus width here to a 1, and then once the XT25F128B gets mainlined we > can see if someone else has issues with dual tx mode so we can note > that as a problem with the chip. Or maybe there is something weird > with dual tx mode yet on the SFC driver/controller, I don't know yet. > I'm all too happy to work with a Rockchip engineer so things like > this can be determined before we hit mainline. :-) > > The XTX25F128B driver is currently awaiting a decision on how to handle > continuation codes, as this chip ID should be using continuation codes, > but doesn't appear to return them when you query for manufacturer ID. > So I should also note in the commit here that the SFC will still be > unusable on the Odroid Go Advance until the XTX25F128B is also > mainlined. > > Thank you. > >> + }; >> +}; >> + >> &tsadc { >> status = "okay"; >> }; >> -- >> 2.17.1 >> >> >> > >