From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9FEBC433ED for ; Tue, 4 May 2021 05:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8A72613BA for ; Tue, 4 May 2021 05:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229786AbhEDFJJ (ORCPT ); Tue, 4 May 2021 01:09:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbhEDFJH (ORCPT ); Tue, 4 May 2021 01:09:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04BB1C061574; Mon, 3 May 2021 22:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=/l3ME+YyFSdYbM3W3a/AxJLnYEq4c0HL5DB1Few+tsY=; b=fnIuE8Usqiz+a4CZLKnOkXfjVJ L1km8jYZPUtgQgMylkarrD2aaff0nMK2iBLrcye228unywIpAk28B6ZRcp+n/0j5rIgXtKLrXrzhu 9zFLC1afNQX2M+mCCRPoqQ/ujWWgiB85ACOVoji/gIzTvvtlQQEX1ashC0STdrMwE1s9OqskC6IBB GzQ97qD1RHNTxqpNq+7Vu38eN5uEP0zL0OLsdTsDZA8Sd3kM8XqO3oFBefCWmI0DYBWxYZnWPbSM5 vEWAYh4teTS/J6fCCSuPTx9hCFbYqvOOSj/vAMjckWZvALOOUeEOXu/G+CxR/Bc0+ti3H6bi/Zej6 D2EiXx0Q==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1ldnHp-00G88E-81; Tue, 04 May 2021 05:08:00 +0000 Subject: Re: [PATCH] EDAC: aspeed: print resource_size_t using %pa To: Andrew Jeffery , linux-kernel@vger.kernel.org Cc: kbuild test robot , linux-aspeed@lists.ozlabs.org, Mauro Carvalho Chehab , Tony Luck , Borislav Petkov , Stefan M Schaeckeler , Borislav Petkov , linux-edac@vger.kernel.org, Arnd Bergmann References: <20210503163409.31944-1-rdunlap@infradead.org> From: Randy Dunlap Message-ID: <892dfd15-a8f7-9db9-86bb-9630e88e0e3c@infradead.org> Date: Mon, 3 May 2021 22:07:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/3/21 9:57 PM, Andrew Jeffery wrote: > > > On Tue, 4 May 2021, at 02:04, Randy Dunlap wrote: >> Fix build warnings for using "%x" to print resource_size_t in 2 places. >> resource_size_t can be either of u32 or u64. We have a special format >> "%pa" for printing a resource_size_t, which is the same as a phys_addr_t. >> See Documentation/core-api/printk-formats.rst. >> >> CC drivers/edac/aspeed_edac.o >> ../drivers/edac/aspeed_edac.c: In function 'init_csrows': >> ../drivers/edac/aspeed_edac.c:257:21: warning: format '%x' expects >> argument of type 'unsigned int', but argument 4 has type >> 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=] >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> ../drivers/edac/aspeed_edac.c:257:21: warning: format '%x' expects >> argument of type 'unsigned int', but argument 5 has type >> 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=] >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> 257 | dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> >> Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") >> Signed-off-by: Randy Dunlap >> Reported-by: kernel test robot >> Cc: Troy Lee >> Cc: Stefan Schaeckeler >> Cc: linux-edac@vger.kernel.org >> Cc: Borislav Petkov >> Cc: Borislav Petkov >> Cc: Mauro Carvalho Chehab >> Cc: Tony Luck >> Cc: linux-aspeed@lists.ozlabs.org >> --- >> Found in linux-next but applies to mainline. > >> >> drivers/edac/aspeed_edac.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> --- linux-next-20210503.orig/drivers/edac/aspeed_edac.c >> +++ linux-next-20210503/drivers/edac/aspeed_edac.c >> @@ -234,6 +234,7 @@ static int init_csrows(struct mem_ctl_in >> u32 nr_pages, dram_type; >> struct dimm_info *dimm; >> struct device_node *np; >> + resource_size_t rsize; >> struct resource r; >> u32 reg04; >> int rc; >> @@ -254,11 +255,12 @@ static int init_csrows(struct mem_ctl_in >> return rc; >> } >> >> - dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n", >> - r.start, resource_size(&r), PAGE_SHIFT); >> + rsize = resource_size(&r); >> + dev_dbg(mci->pdev, "dt: /memory node resources: first page >> r.start=0x%pa, resource_size=0x%pa, PAGE_SHIFT macro=0x%x\n", >> + &r.start, &rsize, PAGE_SHIFT); > > Arnd posted a fix a few days back that feels more intuitive, though > probably could have cleaned up the grammar: > > https://lore.kernel.org/lkml/20210421135500.3518661-1-arnd@kernel.org/ Oh, that's fine. I just missed it. :( thanks. -- ~Randy