From: Atish Patra <atish.patra@wdc.com>
To: Andreas Schwab <schwab@suse.de>,
Paul Walmsley <paul.walmsley@sifive.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>
Subject: Re: [PATCH] arch: riscv: fix logic error in parse_dtb
Date: Thu, 7 Feb 2019 14:47:20 -0800 [thread overview]
Message-ID: <893c55bd-07e1-6ea4-6d67-5d225d9f2db1@wdc.com> (raw)
In-Reply-To: <mvmr2cjy7xx.fsf@suse.de>
On 2/7/19 6:44 AM, Andreas Schwab wrote:
> The function early_init_dt_scan returns true if a DTB was detected.
>
> Fixes: 8fd6e05c7463 ("arch: riscv: support kernel command line forcing when no DTB passed")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> ---
> arch/riscv/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 45e9a2f053dc..84f19ca6d88b 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -140,7 +140,7 @@ asmlinkage void __init setup_vm(void)
>
> void __init parse_dtb(unsigned int hartid, void *dtb)
> {
> - if (!early_init_dt_scan(__va(dtb)))
> + if (early_init_dt_scan(__va(dtb)))
> return;
>
> pr_err("No DTB passed to the kernel\n");
>
Good catch. I was surprised to see "No DTB passed.." message with rc5.
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Regards,
Atish
next prev parent reply other threads:[~2019-02-07 22:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 3:15 [PATCH] arch: riscv: support kernel command line forcing when no DTB passed Paul Walmsley
2019-01-15 15:44 ` Christoph Hellwig
2019-02-05 17:43 ` Andreas Schwab
2019-02-19 21:19 ` Paul Walmsley
2019-02-07 14:44 ` [PATCH] arch: riscv: fix logic error in parse_dtb Andreas Schwab
2019-02-07 22:47 ` Atish Patra [this message]
2019-02-19 21:20 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893c55bd-07e1-6ea4-6d67-5d225d9f2db1@wdc.com \
--to=atish.patra@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@pwsan.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).