From: Casey Schaufler <casey@schaufler-ca.com>
To: David Howells <dhowells@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
viro@zeniv.linux.org.uk, Jeff Layton <jlayton@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Scott Mayhew <smayhew@redhat.com>,
Paul Moore <paul@paul-moore.com>,
linux-nfs@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dwysocha@redhat.com,
linux-kernel@vger.kernel.org, casey@schaufler-ca.com
Subject: Re: [PATCH v4] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing
Date: Tue, 30 Aug 2022 06:47:52 -0700 [thread overview]
Message-ID: <89548338-f716-c110-0f85-3ef880bbd723@schaufler-ca.com> (raw)
In-Reply-To: <1903709.1661849345@warthog.procyon.org.uk>
On 8/30/2022 1:49 AM, David Howells wrote:
> Casey Schaufler <casey@schaufler-ca.com> wrote:
>
>> The authors of this version of the mount code failed to look
>> especially closely at how Smack maintains label names. Once a
>> label name is used in the kernel it is kept on a list forever.
>> All the copies of smk_known here and in the rest of the mount
>> infrastructure are unnecessary and wasteful. The entire set of
>> Smack hooks that deal with mounting need to be reworked to remove
>> that waste. It's on my list of Smack cleanups, but I'd be happy
>> if someone else wanted a go at it.
> I don't have time to overhaul Smack right now. Should I drop the Smack part
> of the patch?
No. I appreciate that you're including Smack as part of the effort.
I would much rather have the code working as you have it than have
to go in later and do it all from scratch. With luck I should be able
to get someone with a considerably lower level of expertise to work
on it.
> David
next prev parent reply other threads:[~2022-08-30 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 10:09 [PATCH v4] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing David Howells
2022-08-26 8:24 ` Christian Brauner
2022-08-26 17:11 ` Casey Schaufler
2022-08-30 8:49 ` David Howells
2022-08-30 13:47 ` Casey Schaufler [this message]
2022-08-31 13:48 ` David Howells
2022-08-31 16:52 ` Casey Schaufler
2022-09-01 5:04 ` Al Viro
2022-09-01 11:47 ` David Howells
2022-09-08 19:35 ` Anna Schumaker
2022-09-08 20:31 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89548338-f716-c110-0f85-3ef880bbd723@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=anna@kernel.org \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=smayhew@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).