From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F1FC4743F for ; Mon, 7 Jun 2021 03:19:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8245260240 for ; Mon, 7 Jun 2021 03:19:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230237AbhFGDUh (ORCPT ); Sun, 6 Jun 2021 23:20:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25716 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbhFGDUg (ORCPT ); Sun, 6 Jun 2021 23:20:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623035925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ABnq2QuOpr7byvnRGusIkVvj+20PbgeaIPvM27YKhg4=; b=NYm6lC/x5w+kG1yUkFR90+hzVOMxnCkewRQicenItQsa2e5MtntXQ2aq5+AeY8MguVe0bs 5DGG+DtAaxOapbqTQoebSL2HpXHRq9Ji+SsuwUZ4p6LlbykKOAuG7XU0TIcR7VO9ny38Uo dTymUwE3t6A3I/OVwheVwARLq4pmbc0= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-Zc2mFRReOM6qUMBE4y2WgQ-1; Sun, 06 Jun 2021 23:18:44 -0400 X-MC-Unique: Zc2mFRReOM6qUMBE4y2WgQ-1 Received: by mail-pj1-f69.google.com with SMTP id om12-20020a17090b3a8cb029016a4ee7d56fso10486679pjb.7 for ; Sun, 06 Jun 2021 20:18:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ABnq2QuOpr7byvnRGusIkVvj+20PbgeaIPvM27YKhg4=; b=B3DLqXjEkcWYK2hP9ydWn/Q5Y4TOVgzh3Qr6e7dKg21jLht9qTRYkEeRDkVb4GilPR 61lJiczBK36YwZYGWGgf1nD13aFWjAzCLy4BgJJdcO0JnRdjYpcLppzqkDJPg0aFPHJo vpN4MuEpf3Q2e2ArAILlpjvp/bbNblS7UPMdAbwtkSV43x+cony0XCFzTWRwwUQaRnwQ Fr6TnO8+eoo+uYi9E4vURCfG9Dg/vue1IUHn1PbM81TxL13eXgLfjWKHSbwOBRobwWqz NlFgdun/AO8AZFH9pRkS8oSqNnatT6T3n4njnIQsu76slJw8flm5frzl8sUm1pcloew/ /CVA== X-Gm-Message-State: AOAM531FU+DEBmo6Mz5SlqmdjApkVIV9bl9hmltWTs6YV4ztBSpdaA36 m2MBWr+Cltzigg52JXIgHXveUqqYj/tzq4gipruEI9rWEbuozA410n6r9+gw8Wx8NJQik1rUK2D j1WveWumdKQ0Qs0UCIIwPOtFb X-Received: by 2002:a17:90a:390d:: with SMTP id y13mr18291776pjb.52.1623035922897; Sun, 06 Jun 2021 20:18:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxyhCGMAJgmD0wCDBmip4ixPdmhcn5mWCmYZELjB4tRm0TDYopxIzBxkopd2Rpl9Ugu+p2EA== X-Received: by 2002:a17:90a:390d:: with SMTP id y13mr18291758pjb.52.1623035922656; Sun, 06 Jun 2021 20:18:42 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id w10sm6719572pfg.196.2021.06.06.20.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Jun 2021 20:18:42 -0700 (PDT) Subject: Re: [RFC] /dev/ioasid uAPI proposal To: Jason Gunthorpe Cc: Alex Williamson , "Tian, Kevin" , Jean-Philippe Brucker , "Jiang, Dave" , "Raj, Ashok" , "kvm@vger.kernel.org" , Jonathan Corbet , Robin Murphy , LKML , "iommu@lists.linux-foundation.org" , David Gibson , Kirti Wankhede , David Woodhouse References: <20210602111117.026d4a26.alex.williamson@redhat.com> <20210602173510.GE1002214@nvidia.com> <20210602120111.5e5bcf93.alex.williamson@redhat.com> <20210602180925.GH1002214@nvidia.com> <20210602130053.615db578.alex.williamson@redhat.com> <20210602195404.GI1002214@nvidia.com> <20210602143734.72fb4fa4.alex.williamson@redhat.com> <6a9426d7-ed55-e006-9c4c-6b7c78142e39@redhat.com> <20210603130927.GZ1002214@nvidia.com> <65614634-1db4-7119-1a90-64ba5c6e9042@redhat.com> <20210604115805.GG1002214@nvidia.com> From: Jason Wang Message-ID: <895671cc-5ef8-bc1a-734c-e9e2fdf03652@redhat.com> Date: Mon, 7 Jun 2021 11:18:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210604115805.GG1002214@nvidia.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/4 ÏÂÎç7:58, Jason Gunthorpe дµÀ: > On Fri, Jun 04, 2021 at 09:11:03AM +0800, Jason Wang wrote: >>> nor do any virtio drivers implement the required platform specific >>> cache flushing to make no-snoop TLPs work. >> I don't get why virtio drivers needs to do that. I think DMA API should hide >> those arch/platform specific stuffs from us. > It is not arch/platform stuff. If the device uses no-snoop then a > very platform specific recovery is required in the device driver. > > It is not part of the normal DMA API, it is side APIs like > flush_agp_cache() or wbinvd() that are used by GPU drivers only. Yes and virtio doesn't support AGP. > > If drivers/virtio doesn't explicitly call these things it doesn't > support no-snoop - hence no VDPA device can ever use no-snoop. Note that no drivers call these things doesn't meant it was not supported by the spec. Actually, spec doesn't forbid the non coherent DMA, anyway we can raise a new thread in the virtio mailing list to discuss about that. But consider virtio has already supported GPU, crypto and sound device, and the devices like codec and video are being proposed. It doesn't help if we mandate coherent DMA now. Thanks > > Since VIRTIO_F_ACCESS_PLATFORM doesn't trigger wbinvd on x86 it has > nothing to do with no-snoop. > > Jason >