From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB43C433DF for ; Thu, 2 Jul 2020 09:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FA2D2084C for ; Thu, 2 Jul 2020 09:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbgGBJwB (ORCPT ); Thu, 2 Jul 2020 05:52:01 -0400 Received: from mail.loongson.cn ([114.242.206.163]:34110 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728257AbgGBJwA (ORCPT ); Thu, 2 Jul 2020 05:52:00 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxL+g5rv1eD3FOAA--.7310S3; Thu, 02 Jul 2020 17:51:54 +0800 (CST) From: Tiezhu Yang Subject: Re: [PATCH v2] gpu/drm: Remove debug info about CPU address To: =?UTF-8?Q?Christian_K=c3=b6nig?= , alexander.deucher@amd.com References: <1593656863-1894-1-git-send-email-yangtiezhu@loongson.cn> <85c81fa9-2994-d861-0690-a79600ed84b3@amd.com> <7aa4d0c5-14ba-594d-e3fb-9acba82cf45d@amd.com> Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <897b806e-dba8-710f-6b62-2493e3033417@loongson.cn> Date: Thu, 2 Jul 2020 17:51:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <7aa4d0c5-14ba-594d-e3fb-9acba82cf45d@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9AxL+g5rv1eD3FOAA--.7310S3 X-Coremail-Antispam: 1UD129KBjvJXoWxGw4xJrWUZFyrKrW8tFWDArb_yoWrGw1xpa yrGa4YkrykZw1jv342vryUXFyFyw47XFW8WryDC34a9wn0vFnFyF1xAw4UuFW8Wrs7KF4I vr18u3yfWF1jyrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv67AKxVW8JVWxJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE14v_GFWl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r12 6r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAF wI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa 7IUYU5r3UUUUU== X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2020 04:39 PM, Christian König wrote: > Am 02.07.20 um 10:35 schrieb Tiezhu Yang: >> On 07/02/2020 04:27 PM, Christian König wrote: >>> Am 02.07.20 um 04:27 schrieb Tiezhu Yang: >>>> When I update the latest kernel, I see the following >>>> "____ptrval____" boot >>>> messages. >>>> >>>> [ 1.872600] radeon 0000:01:05.0: fence driver on ring 0 use gpu >>>> addr 0x0000000048000c00 and cpu addr 0x(____ptrval____) >>>> [ 1.879095] radeon 0000:01:05.0: fence driver on ring 5 use gpu >>>> addr 0x0000000040056038 and cpu addr 0x(____ptrval____) >>>> >>>> Both radeon_fence_driver_start_ring() and >>>> amdgpu_fence_driver_start_ring() >>>> have the similar issue, there exists the following two methods to >>>> solve it: >>>> (1) Use "%pK" instead of "%p" so that the CPU address can be >>>> printed when >>>> the kptr_restrict sysctl is set to 1. >>>> (2) Just completely drop the CPU address suggested by Christian, >>>> because >>>> the CPU address was useful in the past, but isn't any more. We now >>>> have a >>>> debugfs file to read the current fence values. >>>> >>>> Since the CPU address is not much useful, just remove the debug >>>> info about >>>> CPU address. >>>> >>>> Signed-off-by: Tiezhu Yang >>> >>> Splitting it into one patch for radeon and one for amdgpu might be >>> nice to have. >> >> Should I split this patch into two patches and then send v3? >> If yes, I will do it soon. > > For me it's ok to merge it like it is now. > > Only Alex could insists to split the patches, but then he will > probably do it himself. OK, then I will not send v3. > > Thanks for the help, > Christian. > >> >>> >>> But either way Reviewed-by: Christian König >>> for the patch. >>> >>> Thanks, >>> Christian. >>> >>>> --- >>>> >>>> v2: >>>> - Just remove the debug info about CPU address suggested by >>>> Christian >>>> - Modify the patch subject and update the commit message >>>> >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 5 ++--- >>>> drivers/gpu/drm/radeon/radeon_fence.c | 4 ++-- >>>> 2 files changed, 4 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c >>>> index d878fe7..a29f2f9 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c >>>> @@ -422,9 +422,8 @@ int amdgpu_fence_driver_start_ring(struct >>>> amdgpu_ring *ring, >>>> ring->fence_drv.irq_type = irq_type; >>>> ring->fence_drv.initialized = true; >>>> - DRM_DEV_DEBUG(adev->dev, "fence driver on ring %s use gpu >>>> addr " >>>> - "0x%016llx, cpu addr 0x%p\n", ring->name, >>>> - ring->fence_drv.gpu_addr, ring->fence_drv.cpu_addr); >>>> + DRM_DEV_DEBUG(adev->dev, "fence driver on ring %s use gpu addr >>>> 0x%016llx\n", >>>> + ring->name, ring->fence_drv.gpu_addr); >>>> return 0; >>>> } >>>> diff --git a/drivers/gpu/drm/radeon/radeon_fence.c >>>> b/drivers/gpu/drm/radeon/radeon_fence.c >>>> index 43f2f93..8735bf2 100644 >>>> --- a/drivers/gpu/drm/radeon/radeon_fence.c >>>> +++ b/drivers/gpu/drm/radeon/radeon_fence.c >>>> @@ -865,8 +865,8 @@ int radeon_fence_driver_start_ring(struct >>>> radeon_device *rdev, int ring) >>>> } >>>> radeon_fence_write(rdev, >>>> atomic64_read(&rdev->fence_drv[ring].last_seq), ring); >>>> rdev->fence_drv[ring].initialized = true; >>>> - dev_info(rdev->dev, "fence driver on ring %d use gpu addr >>>> 0x%016llx and cpu addr 0x%p\n", >>>> - ring, rdev->fence_drv[ring].gpu_addr, >>>> rdev->fence_drv[ring].cpu_addr); >>>> + dev_info(rdev->dev, "fence driver on ring %d use gpu addr >>>> 0x%016llx\n", >>>> + ring, rdev->fence_drv[ring].gpu_addr); >>>> return 0; >>>> } >>