From: Coly Li <colyli@suse.de>
To: xkernel.wang@foxmail.com
Cc: linux-bcache@vger.kernel.org, kent.overstreet@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: add a check for the return of kzalloc()
Date: Fri, 8 Apr 2022 00:58:55 +0800 [thread overview]
Message-ID: <89ad6f76-a947-edd9-2de3-84dbc4901835@suse.de> (raw)
In-Reply-To: <tencent_C028FEC2BF94C0FF5740D298F572B9396C09@qq.com>
On 3/25/22 11:27 AM, xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kzalloc() is a memory allocation function which can return NULL when
> some internal memory errors happen. So it is better to check it to
> prevent potential wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> Note: I just roughly handled the error and this seems to affect the
> original functionality. If this cannot fail, maybe the tag
> `__GFP_NOFAIL` should be considered.
The error handling is incorrect indeed. And IIRC there is someone else
already fixes it properly and the patch is not upstream yet.
Thanks.
Coly Li
> drivers/md/bcache/request.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index 6d1de88..1dc9821 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1107,14 +1107,16 @@ static void detached_dev_do_request(struct bcache_device *d, struct bio *bio,
> * which would call closure_get(&dc->disk.cl)
> */
> ddip = kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO);
> - ddip->d = d;
> - /* Count on the bcache device */
> - ddip->orig_bdev = orig_bdev;
> - ddip->start_time = start_time;
> - ddip->bi_end_io = bio->bi_end_io;
> - ddip->bi_private = bio->bi_private;
> - bio->bi_end_io = detached_dev_end_io;
> - bio->bi_private = ddip;
> + if (ddip) {
> + ddip->d = d;
> + /* Count on the bcache device */
> + ddip->orig_bdev = orig_bdev;
> + ddip->start_time = start_time;
> + ddip->bi_end_io = bio->bi_end_io;
> + ddip->bi_private = bio->bi_private;
> + bio->bi_end_io = detached_dev_end_io;
> + bio->bi_private = ddip;
> + }
>
> if ((bio_op(bio) == REQ_OP_DISCARD) &&
> !blk_queue_discard(bdev_get_queue(dc->bdev)))
prev parent reply other threads:[~2022-04-07 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 3:27 [PATCH] bcache: add a check for the return of kzalloc() xkernel.wang
2022-04-07 16:58 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89ad6f76-a947-edd9-2de3-84dbc4901835@suse.de \
--to=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).