From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18372C43441 for ; Tue, 13 Nov 2018 09:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB33722419 for ; Tue, 13 Nov 2018 09:23:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB33722419 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731494AbeKMTVE (ORCPT ); Tue, 13 Nov 2018 14:21:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:47482 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727530AbeKMTVD (ORCPT ); Tue, 13 Nov 2018 14:21:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 69D88B029; Tue, 13 Nov 2018 09:23:49 +0000 (UTC) Subject: Re: Performance regression in ast drm driver To: Jean Delvare , Takashi Iwai Cc: David Airlie , christian.koenig@amd.com, dri-devel , linux-kernel References: <20181101162707.598c1718@endymion> <20181108130509.3b2d42ff@endymion> <1542033367.2661.33.camel@suse.de> <1542040904.2661.35.camel@suse.de> From: Thomas Zimmermann Openpgp: preference=signencrypt Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNKFRob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmNvbT7CwJQEEwEIAD4W IQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznTtgIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRBoDcEdUwt6I7D7CACBK42XW+7mCiK8ioXMEy1NzGbXC51RzGea8N83oEJS 1KVUtQxrkDxgrW/WLSl/TfqHFsJpdEFOv1XubWbleun3uKPy0e5vZCd5UjZPkeNjnqfCYTDy hVVsdOuFbtWDppJyJrThLqr9AgSFmoCNNUt1SVpYEEOLNE6C32BhlnSq21VLC+YXTgO/ZHTa YXkq54hHj63jwrcjkBSCkXLh37kHeqnl++GHpN+3R+o3w2OpwHAlvVjdKPT27v1tVkiydsFG 65Vd0n3m/ft+IOrGgxQM1C20uqKvsZGB4r3OGR50ekAybO7sjEJJ1Obl4ge/6RRqcvKz4LMb tGs85D6tPIeFzsBNBFs50uABCADGJj+DP1fk+UWOWrf4O61HTbC4Vr9QD2K4fUUHnzg2B6zU R1BPXqLGG0+lzK8kfYU/F5RjmEcClsIkAaFkg4kzKP14tvY1J5+AV3yNqcdg018HNtiyrSwI E0Yz/qm1Ot2NMZ0DdvVBg22IMsiudQ1tx9CH9mtyTbIXgACvl3PW2o9CxiHPE/bohFhwZwh/ kXYYAE51lhinQ3oFEeQZA3w4OTvxSEspiQR8dg8qJJb+YOAc5IKk6sJmmM7JfFMWSr22satM 23oQ3WvJb4RV6HTRTAIEyyZS7g2DhiytgMG60t0qdABG5KXSQW+OKlZRpuWwKWaLh3if/p/u 69dvpanbABEBAAHCwHwEGAEIACYWIQRyF/usjOnPY0ShaOVoDcEdUwt6IwUCWznS4AIbDAUJ A8JnAAAKCRBoDcEdUwt6I6X3CACJ8D+TpXBCqJE5xwog08+Dp8uBpx0T9n1wE0GQisZruACW NofYn8PTX9k4wmegDLwt7YQDdKxQ4+eTfZeLNQqWg6OCftH5Kx7sjWnJ09tOgniVdROzWJ7c VJ/i0okazncsJ+nq48UYvRGE1Swh3A4QRIyphWX4OADOBmTFl9ZYNPnh23eaC9WrNvFr7yP7 iGjMlfEW8l6Lda//EC5VpXVNza0xeae0zFNst2R9pn+bLkihwDLWxOIyifGRxTqNxoS4I1aw VhxPSVztPMSpIA/sOr/N/p6JrBLn+gui2K6mP7bGb8hF+szfArYqz3T1rv1VzUWAJf5Wre5U iNx9uqqx Message-ID: <89ae9adf-27e7-ae80-639c-c67202a0d0b7@suse.de> Date: Tue, 13 Nov 2018 10:23:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <1542040904.2661.35.camel@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uJhK9pxET5IISNnSgFOKRTad4101zcVct" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uJhK9pxET5IISNnSgFOKRTad4101zcVct Content-Type: multipart/mixed; boundary="CGeSyHpaAak19SFh8lkqYDJ1Fva3PbkY7"; protected-headers="v1" From: Thomas Zimmermann To: Jean Delvare , Takashi Iwai Cc: David Airlie , christian.koenig@amd.com, dri-devel , linux-kernel Message-ID: <89ae9adf-27e7-ae80-639c-c67202a0d0b7@suse.de> Subject: Re: Performance regression in ast drm driver References: <20181101162707.598c1718@endymion> <20181108130509.3b2d42ff@endymion> <1542033367.2661.33.camel@suse.de> <1542040904.2661.35.camel@suse.de> In-Reply-To: <1542040904.2661.35.camel@suse.de> --CGeSyHpaAak19SFh8lkqYDJ1Fva3PbkY7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Jean, ast doesn't remove the vesafb's framebuffer before attaching to the device. I have a patch at [1]. If you have a way of testing it, I'd appreciate. Best regards Thomas [1] https://bugzilla.suse.com/show_bug.cgi?id=3D1112963 Am 12.11.18 um 17:41 schrieb Jean Delvare: > On Mon, 2018-11-12 at 15:45 +0100, Takashi Iwai wrote: >> On Mon, 12 Nov 2018 15:36:07 +0100, >> Jean Delvare wrote: >>> Takashi asked me to compare the contents of >>> /sys/kernel/debug/x86/pat_memtype_list before and after the commit >>> above. Before the commit, we have: >>> >>> uncached-minus @ 0xfafe0000-0xfb000000 >>> uncached-minus @ 0xfb000000-0xfb005000 >>> write-combining @ 0xfb005000-0xfb584000 >>> >>> After the commit, we have: >>> >>> uncached-minus @ 0xfafe0000-0xfb000000 >>> uncached-minus @ 0xfb000000-0xfb005000 >>> uncached-minus @ 0xfb000000-0xfb800000 >>> uncached-minus @ 0xfb005000-0xfb584000 >> >> Just to be sure: >> could you double-check whether you're checking the right order >> (i.e. not checking against the revert)? The change above looks >> illogical from what I can see from the commit... >=20 > Yes, I double checked and can only confirm what I wrote above. However > while checking I noticed another strange thing: the contents of > pat_memtype_list depend on whether I'm reading the file from an xterm > or from the text console (Ctrl+Alt+F2). So I summarize again: >=20 > Commit "drm/drivers: add support for using the arch wc mapping API" > APPLIED, reading pat_memtype_list from the text console: >=20 > uncached-minus @ 0xfafe0000-0xfb000000 > uncached-minus @ 0xfb000000-0xfb005000 > uncached-minus @ 0xfb000000-0xfb800000 > uncached-minus @ 0xfb005000-0xfb584000 >=20 > Commit "drm/drivers: add support for using the arch wc mapping API" > APPLIED, reading pat_memtype_list from an xterm: >=20 > uncached-minus @ 0xfafe0000-0xfb000000 > uncached-minus @ 0xfb000000-0xfb005000 > uncached-minus @ 0xfb000000-0xfb800000 >=20 > Commit "drm/drivers: add support for using the arch wc mapping API" > REVERTED, reading pat_memtype_list from the text console: >=20 > uncached-minus @ 0xfafe0000-0xfb000000 > uncached-minus @ 0xfb000000-0xfb005000 > write-combining @ 0xfb005000-0xfb584000 >=20 > Commit "drm/drivers: add support for using the arch wc mapping API" > REVERTED, reading pat_memtype_list from an xterm: >=20 > uncached-minus @ 0xfafe0000-0xfb000000 > uncached-minus @ 0xfb000000-0xfb005000 >=20 > If you don't find it logical, remember that if things were the way they= > are supposed to be, customers and myself would not be reporting this > bug ;-) >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Linux GmbH, Maxfeldstr. 5, D-90409 N=C3=BCrnberg Tel: +49-911-74053-0; Fax: +49-911-7417755; https://www.suse.com/ SUSE Linux GmbH, GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N=C3=BCrnberg) --CGeSyHpaAak19SFh8lkqYDJ1Fva3PbkY7-- --uJhK9pxET5IISNnSgFOKRTad4101zcVct Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEchf7rIzpz2NEoWjlaA3BHVMLeiMFAlvqmCQACgkQaA3BHVML eiNqkgf/R7oGkMTC5RYJp8JYPfsVteVKVEHe3lJRykkfHHJIFeNFt0CLkXycskEX eE8CVZKvM4XASHX3R0gOTogfIkAZWYqB2nvkUMHyvauxeinJs8Ak89T0R/2u4fMv XCaDF2cDITkHcPH0m/l/9bZO7076CroCGHC/hD66e1qsUF/odgbi7vkrZPTnvzio Q9BOIo/pUnm+d00/iApQth3PPC69TJgrhKJRfOvJow41RG8Joo2OxNiPIsBGhUnS ZhIrDxQIuVB9YoCN5aBG7sNWdiuvm74suwi0o/DVQiE/l6lXHtfZbrB32COXuCyX 5pmIoYVbyX9aGSCvnjkgjXvX6b53sA== =UVhW -----END PGP SIGNATURE----- --uJhK9pxET5IISNnSgFOKRTad4101zcVct--