From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH v12 6/7] arm64: mte: Save/Restore TFSR_EL1 during suspend
Date: Tue, 9 Feb 2021 18:25:31 +0000 [thread overview]
Message-ID: <89c95a1e-cfd2-7840-3175-deaeb336190b@arm.com> (raw)
In-Reply-To: <20210209172821.GI1435@arm.com>
On 2/9/21 5:28 PM, Catalin Marinas wrote:
>> I don't think though you can "check" with IRQs disabled so I suspect
>> that TFSR_EL1 has to be saved/restored (which means that there is a
>> black out period where we run kernel code without being able to detect
>> faults but there is no solution to that other than delaying saving the
>> value to just before calling into PSCI). Likewise on resume from low
>> power.
> It depends on whether kasan_report can be called with IRQs disabled. I
> don't see why not, so if this works I'd rather just call mte_check_async
> (or whatever it's called) on the suspend path and zero the register on
> resume (mte_suspend_exit). We avoid any saving of the state.
Fine by me, I tried a quick test and can confirm that kasan_report can be
invoked with IRQ disabled.
--
Regards,
Vincenzo
next prev parent reply other threads:[~2021-02-09 19:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 16:56 [PATCH v12 0/7] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 1/7] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 2/7] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 3/7] kasan: Add report for async mode Vincenzo Frascino
2021-02-09 7:39 ` kernel test robot
2021-02-09 11:32 ` Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 4/7] arm64: mte: Enable TCO in functions that can read beyond buffer limits Vincenzo Frascino
2021-02-09 11:35 ` Catalin Marinas
2021-02-09 11:45 ` Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 5/7] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 6/7] arm64: mte: Save/Restore TFSR_EL1 during suspend Vincenzo Frascino
2021-02-08 18:56 ` Lorenzo Pieralisi
2021-02-09 10:41 ` Vincenzo Frascino
2021-02-09 11:55 ` Catalin Marinas
2021-02-09 14:33 ` Lorenzo Pieralisi
2021-02-09 14:54 ` Vincenzo Frascino
2021-02-09 17:28 ` Catalin Marinas
2021-02-09 18:25 ` Vincenzo Frascino [this message]
2021-02-08 16:56 ` [PATCH v12 7/7] kasan: don't run tests in async mode Vincenzo Frascino
2021-02-09 6:32 ` kernel test robot
2021-02-09 11:33 ` Vincenzo Frascino
2021-02-10 6:33 ` [kbuild-all] " Rong Chen
2021-02-09 12:02 ` Catalin Marinas
2021-02-09 12:20 ` Vincenzo Frascino
2021-02-09 15:02 ` Andrey Konovalov
2021-02-09 17:06 ` Catalin Marinas
2021-02-09 17:26 ` Andrey Konovalov
2021-02-09 17:37 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89c95a1e-cfd2-7840-3175-deaeb336190b@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).