From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD37C433EF for ; Sun, 29 May 2022 08:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbiE2IIG (ORCPT ); Sun, 29 May 2022 04:08:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiE2IIB (ORCPT ); Sun, 29 May 2022 04:08:01 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE7E59943 for ; Sun, 29 May 2022 01:07:59 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id f9so15782491ejc.0 for ; Sun, 29 May 2022 01:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=/9oKQoiIHCtLJ1GiPNcOALfaJrc/XLY9k2oODVX8Eww=; b=pv4gsODv8js7J2ZgEckaxk4Syo6mbxwoGURgIzB+/fBFy+2coOTX+1ZawHUZbKHqWF jYr4bXyX9PE1K0ObIz2S4tMh3pBNME174vnZcut/24uDizDJsbkQaraekMapUH3iVT5i M6CVhqeAkNr7lakjLEy1+VZjClM7ZqfeMNb8VcqMcKoKUmDfWYf9UW1+78E8kxDCIO75 4hNhp0J8epVs2xbnPm4SK4J49MUskVtz8qJY7USgjszj2kdrT7Cb5VMSZ7r8JsbsU/zp VSzjOY6zCUlZgDWJYbu2/Poe5ohrBPNSiVtymmmOwdQcZ+yIYGHx6En9A4wVEeLj5Sji YFrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=/9oKQoiIHCtLJ1GiPNcOALfaJrc/XLY9k2oODVX8Eww=; b=TQI9jP0xzZAtgFZfy2Shvwl5Xg86b6GBuk1FaxOPAEdAS/sinOTP6dr41L8KjNBfyq ELyXJXFZRXYFl8TsZ1dYIlKTNwutI9WEjj/Cvtd71QW2B7FgvoJF0PncIHLttljBaiyj J7JFu3KIypD7CiMjQi2Np0sxjvNe9vg/9Fmh9K1pgS06u20cnjVMs+XCeIvDs4PC55eY rWI1Un9jLsoT8WQ7AJR1u+t6JvsPm79LOznlvA6l1U/5fVBnXLMm1ONCnerx9zLfrI5X FnfEsQI+P88twESg4F7MXXvF4BF40e22Ds05rclJRH4gTOkXKcHwLePbago70g5YDyJE AhzA== X-Gm-Message-State: AOAM531xWkr4XOfbgXHHsMS/E5B9Bbibwezh82uDft5RmwkC68s60bDt o7f3CGts4QwYJtdmcESsdodZrg== X-Google-Smtp-Source: ABdhPJy2rTrwJjkzwEbnjBlix/SQVyAjaLRROArqJUFGXbwwsBqpTnCdUXq1Bry4EYrEXx/2LauiKA== X-Received: by 2002:a17:906:3958:b0:6fe:90ef:c4b with SMTP id g24-20020a170906395800b006fe90ef0c4bmr44916053eje.36.1653811677641; Sun, 29 May 2022 01:07:57 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id v2-20020a509542000000b0042dcd6f9994sm595545eda.9.2022.05.29.01.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 01:07:57 -0700 (PDT) Message-ID: <89cc9ef4-7a6c-4dd0-3aac-8ad22d8ada2e@linaro.org> Date: Sun, 29 May 2022 10:07:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/7] ARM: dts: s3c2410: use local header for pinctrl register values Content-Language: en-US To: Chanho Park , 'Rob Herring' , 'Krzysztof Kozlowski' , 'Alim Akhtar' , 'Tomasz Figa' , 'Sylwester Nawrocki' , 'Linus Walleij' , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20220526143707.767490-1-krzysztof.kozlowski@linaro.org> <20220526143707.767490-2-krzysztof.kozlowski@linaro.org> <012d01d87181$5b9e23c0$12da6b40$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <012d01d87181$5b9e23c0$12da6b40$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/2022 06:22, Chanho Park wrote: >> Subject: [PATCH 1/7] ARM: dts: s3c2410: use local header for pinctrl >> register values >> >> The DTS uses hardware register values directly in pin controller pin >> configuration. These are not some IDs or other abstraction layer but raw >> numbers used in the registers. >> >> These numbers were previously put in the bindings header to avoid code >> duplication and to provide some context meaning (name), but they do not >> fit the purpose of bindings. It is also quite confusing to use constants >> prefixed with Exynos for other SoC, because there is actually nothing here >> in common, except the actual value. >> >> Store the constants in a header next to DTS and use them instead of >> bindings. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/s3c2410-pinctrl.h | 19 +++++++++++++ >> arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 +++++++++++++------------- >> 2 files changed, 38 insertions(+), 19 deletions(-) create mode 100644 >> arch/arm/boot/dts/s3c2410-pinctrl.h >> >> diff --git a/arch/arm/boot/dts/s3c2410-pinctrl.h >> b/arch/arm/boot/dts/s3c2410-pinctrl.h >> new file mode 100644 >> index 000000000000..71cb0ac815b3 >> --- /dev/null >> +++ b/arch/arm/boot/dts/s3c2410-pinctrl.h >> @@ -0,0 +1,19 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Samsung's Exynos pinctrl bindings > > "Exynos" -> "s3c2410" > Thanks, I need to fix it also in other files. Best regards, Krzysztof