From: "David E. Box" <david.e.box@linux.intel.com>
To: Joe Perches <joe@perches.com>,
hdegoede@redhat.com, gregkh@linuxfoundation.org,
andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com,
mgross@linux.intel.com
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Mark Gross <markgross@kernel.org>
Subject: Re: [PATCH V6 1/3] platform/x86: Add Intel Software Defined Silicon driver
Date: Mon, 07 Feb 2022 21:55:31 -0800 [thread overview]
Message-ID: <89dacc424a729c247f6431e393b89dbf8901c4c8.camel@linux.intel.com> (raw)
In-Reply-To: <dd4150af8858115c96ebab690182190556669050.camel@perches.com>
On Mon, 2022-02-07 at 21:34 -0800, Joe Perches wrote:
> On Mon, 2022-02-07 at 18:54 -0800, David E. Box wrote:
> > On Mon, 2022-02-07 at 17:40 -0800, Joe Perches wrote:
> > > On Mon, 2022-02-07 at 16:54 -0800, David E. Box wrote:
> > > > Intel Software Defined Silicon (SDSi) is a post manufacturing mechanism
> > > > for
> > > > activating additional silicon features. Features are enabled through a
> > > > license activation process. The SDSi driver provides a per socket,
> > > > sysfs
> > > > attribute interface for applications to perform 3 main provisioning
> > > > functions:
> []
> > > > +static int sdsi_mbox_cmd_read(struct sdsi_priv *priv, struct
> > > > sdsi_mbox_info
> > > > *info,
> > > > + size_t *data_size)
> > > > +{
> > > > + struct device *dev = priv->dev;
> > > > + u32 total, loop, eom, status, message_size;
> > > []
> > > > + if (packet_size > SDSI_SIZE_MAILBOX) {
> > > > + dev_err(dev, "Packet size to large\n");
> > >
> > > too
> >
> > Sorry, I'm missing the question here. If it's whether packet_size could also
> > not
> > be a multiple of sizeof(u64) the answer here is yes. But I don't see how
> > that
> > matters. packet_size is a value read from the hardware. This is just a
> > sanity
> > check.
>
> just a to/too typo.
>
> "Packet size too large\n"
Doh!
>
>
next prev parent reply other threads:[~2022-02-08 5:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 0:54 [PATCH V6 0/3] Intel Software Defined Silicon David E. Box
2022-02-08 0:54 ` [PATCH V6 1/3] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2022-02-08 1:40 ` Joe Perches
2022-02-08 2:54 ` David E. Box
2022-02-08 5:34 ` Joe Perches
2022-02-08 5:55 ` David E. Box [this message]
2022-02-08 0:54 ` [PATCH V6 2/3] tools arch x86: Add Intel SDSi provisiong tool David E. Box
2022-02-08 0:54 ` [PATCH V6 3/3] selftests: sdsi: test sysfs setup David E. Box
2022-02-09 12:23 ` [PATCH V6 0/3] Intel Software Defined Silicon Hans de Goede
2022-02-09 16:46 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89dacc424a729c247f6431e393b89dbf8901c4c8.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).