From: Saeed Mahameed <saeedm@mellanox.com>
To: "natechancellor@gmail.com" <natechancellor@gmail.com>,
"leon@kernel.org" <leon@kernel.org>
Cc: Jiri Pirko <jiri@mellanox.com>, Aya Levin <ayal@mellanox.com>,
"clang-built-linux@googlegroups.com"
<clang-built-linux@googlegroups.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Moshe Shemesh <moshe@mellanox.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h
Date: Fri, 21 Feb 2020 18:37:50 +0000 [thread overview]
Message-ID: <89dda0680320d0ce1b42093e59985313e2a1ac50.camel@mellanox.com> (raw)
In-Reply-To: <20200221052437.2884-1-natechancellor@gmail.com>
On Thu, 2020-02-20 at 22:24 -0700, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from
> ../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9:
> warning:
> '__MLX5_RSC_DUMP_H' is used as a header guard here, followed by
> #define
> of a different macro [-Wheader-guard]
> #ifndef __MLX5_RSC_DUMP_H
> ^~~~~~~~~~~~~~~~~
> ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9:
> note:
> '__MLX5_RSC_DUMP__H' is defined here; did you mean
> '__MLX5_RSC_DUMP_H'?
> #define __MLX5_RSC_DUMP__H
> ^~~~~~~~~~~~~~~~~~
> __MLX5_RSC_DUMP_H
> 1 warning generated.
>
> Make them match to get the intended behavior and remove the warning.
Applied to net-next-mlx5
Thanks !
prev parent reply other threads:[~2020-02-21 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 5:24 [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h Nathan Chancellor
2020-02-21 13:30 ` Jason Gunthorpe
2020-02-21 18:37 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89dda0680320d0ce1b42093e59985313e2a1ac50.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=ayal@mellanox.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jiri@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).