From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EB9C7618B for ; Fri, 26 Jul 2019 17:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E771218D3 for ; Fri, 26 Jul 2019 17:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729025AbfGZRa2 (ORCPT ); Fri, 26 Jul 2019 13:30:28 -0400 Received: from mga02.intel.com ([134.134.136.20]:49865 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbfGZRa1 (ORCPT ); Fri, 26 Jul 2019 13:30:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 10:30:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="369611738" Received: from haiyuewa-mobl.ccr.corp.intel.com (HELO [10.255.31.18]) ([10.255.31.18]) by fmsmga005.fm.intel.com with ESMTP; 26 Jul 2019 10:30:25 -0700 Subject: Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman , openipmi-developer@lists.sourceforge.net References: <20190726053959.2003-1-andrew@aj.id.au> <20190726053959.2003-16-andrew@aj.id.au> From: "Wang, Haiyue" Message-ID: <89ea7e21-944e-3d89-05b7-2dedb7916fa9@linux.intel.com> Date: Sat, 27 Jul 2019 01:30:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190726053959.2003-16-andrew@aj.id.au> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2019-07-26 13:39, Andrew Jeffery дµÀ: > The v2 bindings allow us to extract the resources from the devicetree. > The table in the driver is retained to derive the channel index, which > removes the need for kcs_chan property from the v1 bindings. The v2 > bindings allow us to reduce the number of warnings generated by the > existing devicetree nodes. > > Cc: Haiyue Wang > Cc: Corey Minyard > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc:openipmi-developer@lists.sourceforge.net > Signed-off-by: Andrew Jeffery > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ > 1 file changed, 127 insertions(+), 29 deletions(-) Looks good, thanks for the hard work, the code is more clean! :) Reviewed-by: Haiyue Wang