From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44EA0C43217 for ; Tue, 29 Nov 2022 02:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235196AbiK2CvC (ORCPT ); Mon, 28 Nov 2022 21:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234785AbiK2Cu4 (ORCPT ); Mon, 28 Nov 2022 21:50:56 -0500 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE7BA49090 for ; Mon, 28 Nov 2022 18:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1669690255; x=1701226255; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=UtEbOOvyq7XztzxCqkG/C2315uObCORq8NXAbP7YuVA=; b=f8kPVOtS44khXC2vRCPFTSUYYH4+U99AzqKuXwfI8No9OUOfsQHdeWEJ J3AmraGZvU4Sn7nFtz8O54/tkyFJ2tDKdaGCeb+VDbHnPvUOki/SImx5O MGbr/kOv/Urz9b60WZZQAh9uyUaOe8bde8S8bwOXCfTChnR38/s5Zvl+6 s6PSQWhejVU+OfekAtg7v3rhowH0+ZBwHxnOabzjQjofDLC9sGWX3IYOL PX57aAbwnsADweA6NrYsmJ/kSZXaukZMFoIGhqTRd0dSW62eJKr3lATB6 VgGbUBdrVuHv0Tr5C5BozxKva3nnHF36skVv/PGyLgGjHEOblY2Ajl2Fx A==; X-IronPort-AV: E=Sophos;i="5.96,201,1665417600"; d="scan'208";a="222565569" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 29 Nov 2022 10:50:54 +0800 IronPort-SDR: LrpajiKr8JP9U0cjIvIqYqDXnMMlAKiOGZD+G3jxDlOe/OZux4F9bWL6gqH6dA2FFzC2VttygZ +tSpOsXMHa9NUibwGIfMdh8Hn6aZT6VYrzzVFC3PIz3CbuPqGABHBqI5F4urb7XRDM72OWhVEE aXHvmh0K41OigDWdoWOvjG0l/Y0LA2dFHf7XoT7MjGcBaPYqdINlRi4KawR+qeRuvJrIYmoIbQ iq+kpqlOuUxxDlPa8XuanLC/xUYEC6AyPqGsTkuMRJCs8v3MQXD9wtE/36PYtCv2cYKR8XXfBo +r0= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2022 18:09:35 -0800 IronPort-SDR: COTz8K7qqyJJc4YyxrKDWenU5tlxYudDLM/WT3lAl1NDSE2Ung0uNtiIH6ME0HgCwXC5kftnrj 4+zqFNM9skO/rr8GTO/0zCmEXBXVG7k7Wks20t8j8CRYuJXMzWcaYSCgJEPQbKrChvlgcm2zTs E1MF4FbG3WIFSgXZwFnm8HriRvFKFWj9Pdp47Gqez4lmXwh1rvuVLEPcTlPg3VZLL1j/DJMwPO 5V+XCqRmX6cORto4/eUtNwDz1hVVGyjE+hpLRJ0E0WvFt+oQzo/vznMatDZJuVjuGWHYOEPhJp tHc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 28 Nov 2022 18:50:55 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4NLmzy0JKrz1Rwrq for ; Mon, 28 Nov 2022 18:50:54 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1669690253; x=1672282254; bh=UtEbOOvyq7XztzxCqkG/C2315uObCORq8NX AbP7YuVA=; b=cfm+/pkl4x1dCEhJ/mStoWHTT5cc9whqedlQbIYG6ABRYIZ/iBl OX8Ai3DoDCPfBcmDArFcbygRsQBE+dRMhkDFjUBkLp2pWB2O5Nvz7KDXuLwotxQk n2zTK9/NDIxranJYzQgWZUUhUS6+Q0WE59RDhVbsrq7KQT8SfflLpFNUpK7H2AJY vBYHrngrMn9693Rz3DEPW4ZMIUhXSpnYz5VgDC5JVGUX33IG+sORKPjekK6oJ3Us +hQuV1DgT8xwZoRrRYi61lM7DjlvhS8xLelkUsBmxyLcTna6O8ZChlbYmbWxugP/ VWy4lEHFnGjk7RQ+lPsnAZ1lreCQSAGgJxw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cGEAR5vkMn6v for ; Mon, 28 Nov 2022 18:50:53 -0800 (PST) Received: from [10.149.53.254] (washi.fujisawa.hgst.com [10.149.53.254]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4NLmzw5mcSz1RvLy; Mon, 28 Nov 2022 18:50:52 -0800 (PST) Message-ID: <89f5e3a2-1cf7-8b9e-f3b9-af0fe4f72c60@opensource.wdc.com> Date: Tue, 29 Nov 2022 11:50:51 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: linux-next: Fixes tag needs some work in the block tree Content-Language: en-US To: Jens Axboe , Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List References: <20221129082715.78e44566@canb.auug.org.au> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/22 11:30, Jens Axboe wrote: > On 11/28/22 4:39?PM, Damien Le Moal wrote: >> On 11/29/22 06:27, Stephen Rothwell wrote: >>> Hi all, >>> >>> In commit >>> >>> 4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()") >>> >>> Fixes tag >>> >>> Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs") >>> >>> has these problem(s): >>> >>> - SHA1 should be at least 12 digits long >>> This can be fixed for the future by setting core.abbrev to 12 (or >>> more) or (for git v2.11 or later) just making sure it is not set >>> (or set to "auto"). >> >> Oops. Sorry about that. It seems I cannot count up to 12 anymore :) >> It should be: >> >> Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write >> streams to zoned HDDs") >> >> Jens, can you fix this ? > > Sure, it's not that important though as it's just missing one digit. For > the record, this is what I have in my .gitconfig : > > [alias] > fixes = log -1 --format=fixes > > [pretty] > fixes = Fixes: %h (\"%s\") > > [core] > abbrev = 12 > > and then you just do 'git fixes ' and it spits out the line for the > commit without needing to count anything and eliminates this error. Thanks for the info. Will try this ! -- Damien Le Moal Western Digital Research