From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v4 0/4] media: meson: vdec: Add compliant H264 support
Date: Mon, 10 Feb 2020 11:16:16 +0100 [thread overview]
Message-ID: <8BAAA12D-B4D6-4F42-B763-B634C47539FD@gmail.com> (raw)
In-Reply-To: <cc8defafcf4849f48786c41d94c4e44414903fac.camel@ndufresne.ca>
> Wiadomość napisana przez Nicolas Dufresne <nicolas@ndufresne.ca> w dniu 08.02.2020, o godz. 22:08:
>
> I'm currently running Fedora 31 (Debian unstable should provide the
> same), with the stock GStreamer 1.16.1. And doing playback with:
>
> gst-play-1.0 Videos/bbb_sunflower_1080p_30fps_normal.mp4 --videosink="kmssink" --flags=video
>
> With this player, you can seek with the arrows (left/right), or go back
> to the start using 0 key. When you seek, the streaming stalls. If you
> switch the --videosink to fakevideosink as an example, seeking works
> perfectly, and kernel does not complain anymore. Same if you don't use
> a zero-copy path, like fbdevsink.
>
Nicolas,
Are You using streamer compiled with internal gst FFmpeg?
If so - then IIRC 1.16 gst build-in ffmpeg is at 4.2.1 level and it has missing some ffmpeg master v4l2 commits which are improving amlogic vdec<->ffmpeg cooperation.
Also I personally found adding https://github.com/tmm1/FFmpeg/commit/196bab90a29323722050111e936532ac9ac9bfda makes mythtv on s912/panfrost with DRM_PRIME EGL_LINUX_DMA_BUF_EXPORT working well - at least with H264 bluray content (progressive; probability of stream errors=low).
Playback of TV interlaced content however still has issues on current vdec (5.5.2+Neil's v5 ML patch series): video playback sometimes becomes jumpy.
At this moment I suspect it is because bitstream errors (TV recordings recorded from SAT so stream errors are highly probable) are confusing vdec and vdec hw + ffmpeg v4l2 are not able to deal/recover with this….
(this more demanding error handling is IMHO general attribute of stateful decoders when compared to state-less)
Generally I think vdec error recovery in vdec<->ffmpeg needs be inspected and maybe there is place to improvement…..
prev parent reply other threads:[~2020-02-10 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 13:30 [PATCH v4 0/4] media: meson: vdec: Add compliant H264 support Neil Armstrong
2020-01-16 13:30 ` [PATCH v4 1/4] media: v4l2-mem2mem: handle draining, stopped and next-buf-is-last states Neil Armstrong
2020-01-16 13:30 ` [PATCH v4 2/4] media: vicodec: use v4l2-mem2mem draining, stopped and next-buf-is-last states handling Neil Armstrong
2020-01-16 13:30 ` [PATCH v4 3/4] media: meson: vdec: bring up to compliance Neil Armstrong
2020-01-16 13:30 ` [PATCH v4 4/4] media: meson: vdec: add H.264 decoding support Neil Armstrong
2020-02-01 15:34 ` [PATCH v4 0/4] media: meson: vdec: Add compliant H264 support Nicolas Dufresne
2020-02-01 15:38 ` Nicolas Dufresne
2020-02-06 7:57 ` Neil Armstrong
2020-02-08 21:08 ` Nicolas Dufresne
2020-02-10 10:16 ` Piotr Oniszczuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8BAAA12D-B4D6-4F42-B763-B634C47539FD@gmail.com \
--to=piotr.oniszczuk@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=nicolas@ndufresne.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).