RE: [Pcihpd-discuss] Re: PCI Hot-plug driver patch for 2.5.74 kernel

RE: [Pcihpd-discuss] Re: PCI Hot-plug driver patch for 2.5.74 kernel

[Zink, Dan]

We've looked at the patch a bit and would prefer that it not
be applied as is.  In particular, it seems to remove proper
detection for features that are in the driver today.  For example,
the decisions that are made off the subsytem ID...

Would it be possible to split this into smaller patches that
each do one particular thing?

Regards,
Dan  

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com] 
> Sent: Thursday, July 10, 2003 8:39 PM
> To: Dely Sy
> Cc: linux-kernel@vger.kernel.org; 
> pcihpd-discuss@lists.sourceforge.net; tony.luck@intel.com
> Subject: [Pcihpd-discuss] Re: PCI Hot-plug driver patch for 
> 2.5.74 kernel
> 
> 
> Thanks, I'm going to wait to see what the HP/Compaq people 
> have to say about this patch before applying it.
> 
> greg k-h
> 
> 
> -------------------------------------------------------
> This SF.Net email sponsored by: Parasoft
> Error proof Web apps, automate testing & more.
> Download & eval WebKing and get a free book. 
> www.parasoft.com/bulletproofapps1 
> _______________________________________________
> Pcihpd-discuss mailing list Pcihpd-discuss@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pcihpd-discuss
> 

Re: [Pcihpd-discuss] Re: PCI Hot-plug driver patch for 2.5.74 kernel

[Greg KH]

On Fri, Jul 11, 2003 at 09:10:03AM -0700, Sy, Dely L wrote:
> > Would it be possible to split this into smaller patches that
> > each do one particular thing?
> 
> This patch has moved the code around quite a bit to separate out the 
> resource gathering code to support both HRT & ACPI, and to put the 
> code that is specific to the Compaq HPC HW programming model in 
> cpqphp_hpc.c.  If you feel there is a need to split the patch into 
> smaller ones, we can further discuss on that.

Yes, I would feel better if you do that.  This patch is just way to big,
and it's hard to see the changes that you have made.  If you can split
it up into a sequence of patches that change one major thing at a time,
I would really appreciate it.

thanks,

greg k-h

RE: [Pcihpd-discuss] Re: PCI Hot-plug driver patch for 2.5.74 kernel

[Sy, Dely L]

Dan,

> We've looked at the patch a bit and would prefer that it not
> be applied as is.  In particular, it seems to remove proper
> detection for features that are in the driver today.  For example,
> the decisions that are made off the subsytem ID...

All the functionality of the original driver should still be there.
Are you referring to the chunk of code in cpqhpc_probe() that bases
on the subsystem ID to detect the capability of the HPC.  This 
feature is in phphpc_get_ctrl_cap() in cpqphp_hpc.c.  This patch use
a 16-bit variable, pctlrcap, to capture the capability and decode it
when needed. I can provide more detail information on this if you 
need. Let me know if there are some other features you found missing.

> Would it be possible to split this into smaller patches that
> each do one particular thing?

This patch has moved the code around quite a bit to separate out the 
resource gathering code to support both HRT & ACPI, and to put the 
code that is specific to the Compaq HPC HW programming model in 
cpqphp_hpc.c.  If you feel there is a need to split the patch into 
smaller ones, we can further discuss on that.

Thanks,
Dely